From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mx.groups.io with SMTP id smtpd.web12.891.1583207945575151114 for ; Mon, 02 Mar 2020 19:59:05 -0800 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: chasel.chiu@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Mar 2020 19:59:05 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,510,1574150400"; d="scan'208";a="228734986" Received: from kmsmsx152.gar.corp.intel.com ([172.21.73.87]) by orsmga007.jf.intel.com with ESMTP; 02 Mar 2020 19:59:04 -0800 Received: from pgsmsx111.gar.corp.intel.com ([169.254.2.103]) by KMSMSX152.gar.corp.intel.com ([169.254.11.237]) with mapi id 14.03.0439.000; Tue, 3 Mar 2020 11:59:01 +0800 From: "Chiu, Chasel" To: "Shindo, Miki" , "devel@edk2.groups.io" CC: "Chaganty, Rangasai V" , "Desimone, Nathaniel L" , "Agyeman, Prince" Subject: Re: [edk2-platform:PATCH v2] MinPlatformPkg/PeiReportFvLib: Remove redundant Fsp Fv installation Thread-Topic: [edk2-platform:PATCH v2] MinPlatformPkg/PeiReportFvLib: Remove redundant Fsp Fv installation Thread-Index: AQHV8P7ncpLKKN5JoEe1K71KJfGXMKg2PWVg Date: Tue, 3 Mar 2020 03:59:00 +0000 Message-ID: <3C3EFB470A303B4AB093197B6777CCEC506B1093@PGSMSX111.gar.corp.intel.com> References: <20200303014945.25312-1-miki.shindo@intel.com> In-Reply-To: <20200303014945.25312-1-miki.shindo@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [172.30.20.205] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Shindo, Please see my comments below inline. With that updated: Reviewed-by: Chasel Chiu Thanks, Chasel > -----Original Message----- > From: Shindo, Miki > Sent: Tuesday, March 3, 2020 9:50 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Agyeman, Prince > > Subject: [edk2-platform:PATCH v2] MinPlatformPkg/PeiReportFvLib: Remove > redundant Fsp Fv installation >=20 > REF : https://bugzilla.tianocore.org/show_bug.cgi?id=3D2542 >=20 > ReportPreMemFv () has redundant calls to install Fsp FVs. > FSP-M, S, U FVs do not need to be installed when Fsp Wrapper Boot Mode is > disabled. >=20 > Signed-off-by: Miki Shindo > Cc: Sai Chaganty > Cc: Chasel Chiu > Cc: Nate DeSimone > Cc: Prince Agyeman > --- >=20 > Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiRepo= rt > FvLib.c | 38 +++++++------------------------------- >=20 > Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiRepo= rt > FvLib.inf | 6 ------ > 2 files changed, 7 insertions(+), 37 deletions(-) >=20 > diff --git > a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiRe= p > ortFvLib.c > b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiRe= p > ortFvLib.c > index 6158fc9412..1fad384cd6 100644 > --- > a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiRe= p > ortFvLib.c > +++ b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/ > +++ PeiReportFvLib.c > @@ -20,17 +20,9 @@ ReportPreMemFv ( > VOID > ) > { > - if (!PcdGetBool(PcdFspWrapperBootMode)) { > - DEBUG ((DEBUG_INFO, "Install FlashFvFspM - 0x%x, 0x%x\n", PcdGet32 > (PcdFlashFvFspMBase), PcdGet32 (PcdFlashFvFspMSize))); > - PeiServicesInstallFvInfo2Ppi ( > - &(((EFI_FIRMWARE_VOLUME_HEADER *) (UINTN) PcdGet32 > (PcdFlashFvFspMBase))->FileSystemGuid), > - (VOID *) (UINTN) PcdGet32 (PcdFlashFvFspMBase), > - PcdGet32 (PcdFlashFvFspMSize), > - NULL, > - NULL, > - 0 > - ); > - } > + /// > + /// Note : FSP FVs except FSP-T FV are installed in IntelFsp2Wrapper P= kg or > FspPkg in Dispatch mode. > + /// In Dispatch mode FSP FVs will be installed by IntelFsp2WrapperPkg, not FspP= kg, please correct comments for PostMem phase too. > if (PcdGetBool(PcdFspWrapperBootMode)) { > DEBUG ((DEBUG_INFO, "Install FlashFvFspT - 0x%x, 0x%x\n", PcdGet32 > (PcdFlashFvFspTBase), PcdGet32 (PcdFlashFvFspTSize))); > PeiServicesInstallFvInfo2Ppi ( > @@ -80,6 +72,10 @@ ReportPostMemFv ( > Status =3D PeiServicesGetBootMode (&BootMode); > ASSERT_EFI_ERROR (Status); >=20 > + /// > + /// Note : FSP FVs except FSP-T FV are installed in IntelFsp2Wrapper P= kg or > FspPkg in Dispatch mode. > + /// > + > /// > /// Build HOB for DXE > /// > @@ -97,26 +93,6 @@ ReportPostMemFv ( > NULL, > 0 > ); > - if (!PcdGetBool(PcdFspWrapperBootMode)) { > - DEBUG ((DEBUG_INFO, "Install FlashFvFspS - 0x%x, 0x%x\n", > PcdGet32 (PcdFlashFvFspSBase), PcdGet32 (PcdFlashFvFspSSize))); > - PeiServicesInstallFvInfo2Ppi ( > - &(((EFI_FIRMWARE_VOLUME_HEADER *) (UINTN) PcdGet32 > (PcdFlashFvFspSBase))->FileSystemGuid), > - (VOID *) (UINTN) PcdGet32 (PcdFlashFvFspSBase), > - PcdGet32 (PcdFlashFvFspSSize), > - NULL, > - NULL, > - 0 > - ); > - DEBUG ((DEBUG_INFO, "Install FlashFvFspU - 0x%x, 0x%x\n", > PcdGet32 (PcdFlashFvFspUBase), PcdGet32 (PcdFlashFvFspUSize))); > - PeiServicesInstallFvInfo2Ppi ( > - &(((EFI_FIRMWARE_VOLUME_HEADER *) (UINTN) PcdGet32 > (PcdFlashFvFspUBase))->FileSystemGuid), > - (VOID *) (UINTN) PcdGet32 (PcdFlashFvFspUBase), > - PcdGet32 (PcdFlashFvFspUSize), > - NULL, > - NULL, > - 0 > - ); > - } > DEBUG ((DEBUG_INFO, "Install FlashFvUefiBoot - 0x%x, 0x%x\n", > PcdGet32 (PcdFlashFvUefiBootBase), PcdGet32 (PcdFlashFvUefiBootSize))); > PeiServicesInstallFvInfo2Ppi ( > &(((EFI_FIRMWARE_VOLUME_HEADER *) (UINTN) PcdGet32 > (PcdFlashFvUefiBootBase))->FileSystemGuid), > diff --git > a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiRe= p > ortFvLib.inf > b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiRe= p > ortFvLib.inf > index 79cd5ee1f7..4258d0f2e7 100644 > --- > a/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/PeiRe= p > ortFvLib.inf > +++ b/Platform/Intel/MinPlatformPkg/PlatformInit/Library/PeiReportFvLib/ > +++ PeiReportFvLib.inf > @@ -34,14 +34,8 @@ > gMinPlatformPkgTokenSpaceGuid.PcdFspWrapperBootMode > ## CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaBaseAddress > ## CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdFlashAreaSize > ## CONSUMES > - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMBase > ## CONSUMES > - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspMSize > ## CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTBase > ## CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspTSize > ## CONSUMES > - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSBase > ## CONSUMES > - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspSSize > ## CONSUMES > - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspUBase > ## CONSUMES > - gMinPlatformPkgTokenSpaceGuid.PcdFlashFvFspUSize > ## CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPostMemoryBase > ## CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvPostMemorySize > ## CONSUMES > gMinPlatformPkgTokenSpaceGuid.PcdFlashFvUefiBootBase > ## CONSUMES > -- > 2.16.2.windows.1