[PATCH] * IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h

[PATCH] * IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h

[Ethan Tsao]

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2318

Create header for BaseConfigBlockLib

Signed-off-by: Ethan Tsao <ethan.tsao@intel.com>
---
 Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 70 insertions(+)

diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h
new file mode 100644
index 0000000000..110298f088
--- /dev/null
+++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h
@@ -0,0 +1,70 @@
+/** @file
+  Header file for Config Block Lib implementation
+
+Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.<BR>
+This program and the accompanying materials are licensed and made available under 
+the terms and conditions of the BSD License that accompanies this distribution.  
+The full text of the license may be found at
+http://opensource.org/licenses/bsd-license.php.                                          
+
+THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,                     
+WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+
+**/
+
+#ifndef _CONFIG_BLOCK_LIB_H_
+#define _CONFIG_BLOCK_LIB_H_
+
+/**
+  Create config block table
+
+  @param[in]     TotalSize                    - Max size to be allocated for the Config Block Table
+  @param[out]    ConfigBlockTableAddress      - On return, points to a pointer to the beginning of Config Block Table Address
+
+  @retval EFI_INVALID_PARAMETER - Invalid Parameter
+  @retval EFI_OUT_OF_RESOURCES  - Out of resources
+  @retval EFI_SUCCESS           - Successfully created Config Block Table at ConfigBlockTableAddress
+**/
+EFI_STATUS
+EFIAPI
+CreateConfigBlockTable (
+  IN     UINT16    TotalSize,
+  OUT    VOID      **ConfigBlockTableAddress
+  );
+
+/**
+  Add config block into config block table structure
+
+  @param[in]     ConfigBlockTableAddress      - A pointer to the beginning of Config Block Table Address
+  @param[out]    ConfigBlockAddress           - On return, points to a pointer to the beginning of Config Block Address
+
+  @retval EFI_OUT_OF_RESOURCES - Config Block Table is full and cannot add new Config Block or
+                                 Config Block Offset Table is full and cannot add new Config Block.
+  @retval EFI_SUCCESS          - Successfully added Config Block
+**/
+EFI_STATUS
+EFIAPI
+AddConfigBlock (
+  IN     VOID      *ConfigBlockTableAddress,
+  OUT    VOID      **ConfigBlockAddress
+  );
+
+/**
+  Retrieve a specific Config Block data by GUID
+
+  @param[in]      ConfigBlockTableAddress      - A pointer to the beginning of Config Block Table Address
+  @param[in]      ConfigBlockGuid              - A pointer to the GUID uses to search specific Config Block
+  @param[out]     ConfigBlockAddress           - On return, points to a pointer to the beginning of Config Block Address
+
+  @retval EFI_NOT_FOUND         - Could not find the Config Block
+  @retval EFI_SUCCESS           - Config Block found and return
+**/
+EFI_STATUS
+EFIAPI
+GetConfigBlock (
+  IN     VOID      *ConfigBlockTableAddress,
+  IN     EFI_GUID  *ConfigBlockGuid,
+  OUT    VOID      **ConfigBlockAddress
+  );
+
+#endif // _CONFIG_BLOCK_LIB_H_
\ No newline at end of file
-- 
2.16.2.windows.1

[PATCH] * IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h

[Ethan Tsao]

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2318

Create header for BaseConfigBlockLib

Signed-off-by: Ethan Tsao <ethan.tsao@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
---
 Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h | 70 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 70 insertions(+)

diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h
new file mode 100644
index 0000000000..110298f088
--- /dev/null
+++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h
@@ -0,0 +1,70 @@
+/** @file
+  Header file for Config Block Lib implementation
+
+Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.<BR>
+This program and the accompanying materials are licensed and made available under 
+the terms and conditions of the BSD License that accompanies this distribution.  
+The full text of the license may be found at
+http://opensource.org/licenses/bsd-license.php.                                          
+
+THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,                     
+WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
+
+**/
+
+#ifndef _CONFIG_BLOCK_LIB_H_
+#define _CONFIG_BLOCK_LIB_H_
+
+/**
+  Create config block table
+
+  @param[in]     TotalSize                    - Max size to be allocated for the Config Block Table
+  @param[out]    ConfigBlockTableAddress      - On return, points to a pointer to the beginning of Config Block Table Address
+
+  @retval EFI_INVALID_PARAMETER - Invalid Parameter
+  @retval EFI_OUT_OF_RESOURCES  - Out of resources
+  @retval EFI_SUCCESS           - Successfully created Config Block Table at ConfigBlockTableAddress
+**/
+EFI_STATUS
+EFIAPI
+CreateConfigBlockTable (
+  IN     UINT16    TotalSize,
+  OUT    VOID      **ConfigBlockTableAddress
+  );
+
+/**
+  Add config block into config block table structure
+
+  @param[in]     ConfigBlockTableAddress      - A pointer to the beginning of Config Block Table Address
+  @param[out]    ConfigBlockAddress           - On return, points to a pointer to the beginning of Config Block Address
+
+  @retval EFI_OUT_OF_RESOURCES - Config Block Table is full and cannot add new Config Block or
+                                 Config Block Offset Table is full and cannot add new Config Block.
+  @retval EFI_SUCCESS          - Successfully added Config Block
+**/
+EFI_STATUS
+EFIAPI
+AddConfigBlock (
+  IN     VOID      *ConfigBlockTableAddress,
+  OUT    VOID      **ConfigBlockAddress
+  );
+
+/**
+  Retrieve a specific Config Block data by GUID
+
+  @param[in]      ConfigBlockTableAddress      - A pointer to the beginning of Config Block Table Address
+  @param[in]      ConfigBlockGuid              - A pointer to the GUID uses to search specific Config Block
+  @param[out]     ConfigBlockAddress           - On return, points to a pointer to the beginning of Config Block Address
+
+  @retval EFI_NOT_FOUND         - Could not find the Config Block
+  @retval EFI_SUCCESS           - Config Block found and return
+**/
+EFI_STATUS
+EFIAPI
+GetConfigBlock (
+  IN     VOID      *ConfigBlockTableAddress,
+  IN     EFI_GUID  *ConfigBlockGuid,
+  OUT    VOID      **ConfigBlockAddress
+  );
+
+#endif // _CONFIG_BLOCK_LIB_H_
\ No newline at end of file
-- 
2.16.2.windows.1

Re: [PATCH] * IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h

[Ni, Ray]

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Tsao, Ethan <ethan.tsao@intel.com>
> Sent: Monday, December 23, 2019 2:35 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>
> Subject: [PATCH] * IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2318
> 
> Create header for BaseConfigBlockLib
> 
> Signed-off-by: Ethan Tsao <ethan.tsao@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> ---
>  Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h | 70
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++
>  1 file changed, 70 insertions(+)
> 
> diff --git a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h
> b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h
> new file mode 100644
> index 0000000000..110298f088
> --- /dev/null
> +++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h
> @@ -0,0 +1,70 @@
> +/** @file
> +  Header file for Config Block Lib implementation
> +
> +Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.<BR>
> +This program and the accompanying materials are licensed and made
> available under
> +the terms and conditions of the BSD License that accompanies this
> distribution.
> +The full text of the license may be found at
> +http://opensource.org/licenses/bsd-license.php.
> +
> +THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
> +WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
> +
> +**/
> +
> +#ifndef _CONFIG_BLOCK_LIB_H_
> +#define _CONFIG_BLOCK_LIB_H_
> +
> +/**
> +  Create config block table
> +
> +  @param[in]     TotalSize                    - Max size to be allocated for the Config
> Block Table
> +  @param[out]    ConfigBlockTableAddress      - On return, points to a pointer
> to the beginning of Config Block Table Address
> +
> +  @retval EFI_INVALID_PARAMETER - Invalid Parameter
> +  @retval EFI_OUT_OF_RESOURCES  - Out of resources
> +  @retval EFI_SUCCESS           - Successfully created Config Block Table at
> ConfigBlockTableAddress
> +**/
> +EFI_STATUS
> +EFIAPI
> +CreateConfigBlockTable (
> +  IN     UINT16    TotalSize,
> +  OUT    VOID      **ConfigBlockTableAddress
> +  );
> +
> +/**
> +  Add config block into config block table structure
> +
> +  @param[in]     ConfigBlockTableAddress      - A pointer to the beginning of
> Config Block Table Address
> +  @param[out]    ConfigBlockAddress           - On return, points to a pointer to
> the beginning of Config Block Address
> +
> +  @retval EFI_OUT_OF_RESOURCES - Config Block Table is full and cannot
> add new Config Block or
> +                                 Config Block Offset Table is full and cannot add new Config
> Block.
> +  @retval EFI_SUCCESS          - Successfully added Config Block
> +**/
> +EFI_STATUS
> +EFIAPI
> +AddConfigBlock (
> +  IN     VOID      *ConfigBlockTableAddress,
> +  OUT    VOID      **ConfigBlockAddress
> +  );
> +
> +/**
> +  Retrieve a specific Config Block data by GUID
> +
> +  @param[in]      ConfigBlockTableAddress      - A pointer to the beginning of
> Config Block Table Address
> +  @param[in]      ConfigBlockGuid              - A pointer to the GUID uses to
> search specific Config Block
> +  @param[out]     ConfigBlockAddress           - On return, points to a pointer to
> the beginning of Config Block Address
> +
> +  @retval EFI_NOT_FOUND         - Could not find the Config Block
> +  @retval EFI_SUCCESS           - Config Block found and return
> +**/
> +EFI_STATUS
> +EFIAPI
> +GetConfigBlock (
> +  IN     VOID      *ConfigBlockTableAddress,
> +  IN     EFI_GUID  *ConfigBlockGuid,
> +  OUT    VOID      **ConfigBlockAddress
> +  );
> +
> +#endif // _CONFIG_BLOCK_LIB_H_
> \ No newline at end of file
> --
> 2.16.2.windows.1

Re: [PATCH] * IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h

[Chaganty, Rangasai V]

Please update the copyright text to "BSD-2-Clause-Patent" format and start the year with the year of this file creation.
 
Thanks,
Sai

-----Original Message-----
From: Ni, Ray 
Sent: Sunday, December 22, 2019 11:50 PM
To: Tsao, Ethan <ethan.tsao@intel.com>; devel@edk2.groups.io
Cc: Chaganty, Rangasai V <rangasai.v.chaganty@intel.com>
Subject: RE: [PATCH] * IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h

Reviewed-by: Ray Ni <ray.ni@intel.com>

> -----Original Message-----
> From: Tsao, Ethan <ethan.tsao@intel.com>
> Sent: Monday, December 23, 2019 2:35 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V 
> <rangasai.v.chaganty@intel.com>
> Subject: [PATCH] * IntelSiliconPkg/Include/Library:Add 
> ConfigBlockLib.h
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2318
> 
> Create header for BaseConfigBlockLib
> 
> Signed-off-by: Ethan Tsao <ethan.tsao@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Sai Chaganty <rangasai.v.chaganty@intel.com>
> ---
>  Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h | 70
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++
>  1 file changed, 70 insertions(+)
> 
> diff --git 
> a/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h
> b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h
> new file mode 100644
> index 0000000000..110298f088
> --- /dev/null
> +++ b/Silicon/Intel/IntelSiliconPkg/Include/Library/ConfigBlockLib.h
> @@ -0,0 +1,70 @@
> +/** @file
> +  Header file for Config Block Lib implementation
> +
> +Copyright (c) 2015 - 2016, Intel Corporation. All rights 
> +reserved.<BR> This program and the accompanying materials are 
> +licensed and made
> available under
> +the terms and conditions of the BSD License that accompanies this
> distribution.
> +The full text of the license may be found at 
> +http://opensource.org/licenses/bsd-license.php.
> +
> +THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS"
> BASIS,
> +WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER
> EXPRESS OR IMPLIED.
> +
> +**/
> +
> +#ifndef _CONFIG_BLOCK_LIB_H_
> +#define _CONFIG_BLOCK_LIB_H_
> +
> +/**
> +  Create config block table
> +
> +  @param[in]     TotalSize                    - Max size to be allocated for the Config
> Block Table
> +  @param[out]    ConfigBlockTableAddress      - On return, points to a pointer
> to the beginning of Config Block Table Address
> +
> +  @retval EFI_INVALID_PARAMETER - Invalid Parameter  @retval 
> + EFI_OUT_OF_RESOURCES  - Out of resources
> +  @retval EFI_SUCCESS           - Successfully created Config Block Table at
> ConfigBlockTableAddress
> +**/
> +EFI_STATUS
> +EFIAPI
> +CreateConfigBlockTable (
> +  IN     UINT16    TotalSize,
> +  OUT    VOID      **ConfigBlockTableAddress
> +  );
> +
> +/**
> +  Add config block into config block table structure
> +
> +  @param[in]     ConfigBlockTableAddress      - A pointer to the beginning of
> Config Block Table Address
> +  @param[out]    ConfigBlockAddress           - On return, points to a pointer to
> the beginning of Config Block Address
> +
> +  @retval EFI_OUT_OF_RESOURCES - Config Block Table is full and 
> + cannot
> add new Config Block or
> +                                 Config Block Offset Table is full 
> + and cannot add new Config
> Block.
> +  @retval EFI_SUCCESS          - Successfully added Config Block
> +**/
> +EFI_STATUS
> +EFIAPI
> +AddConfigBlock (
> +  IN     VOID      *ConfigBlockTableAddress,
> +  OUT    VOID      **ConfigBlockAddress
> +  );
> +
> +/**
> +  Retrieve a specific Config Block data by GUID
> +
> +  @param[in]      ConfigBlockTableAddress      - A pointer to the beginning of
> Config Block Table Address
> +  @param[in]      ConfigBlockGuid              - A pointer to the GUID uses to
> search specific Config Block
> +  @param[out]     ConfigBlockAddress           - On return, points to a pointer to
> the beginning of Config Block Address
> +
> +  @retval EFI_NOT_FOUND         - Could not find the Config Block
> +  @retval EFI_SUCCESS           - Config Block found and return
> +**/
> +EFI_STATUS
> +EFIAPI
> +GetConfigBlock (
> +  IN     VOID      *ConfigBlockTableAddress,
> +  IN     EFI_GUID  *ConfigBlockGuid,
> +  OUT    VOID      **ConfigBlockAddress
> +  );
> +
> +#endif // _CONFIG_BLOCK_LIB_H_
> \ No newline at end of file
> --
> 2.16.2.windows.1

[PATCH] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h

[TinaX Y Chen]

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2318

Change reference path of ConfigBlockLib to IntelSiliconPkg for Coffeelake.

Change-Id: I433e0a7a00c0cc15a0986050c203c7ca8aef02a2
Signed-off-by: TinaX Y Chen <tinax.y.chen@intel.com>
cc: Ray Ni <ray.ni@intel.com>
cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
cc: Chasel Chiu <chasel.chiu@intel.com>
cc: Ethan Tsao <ethan.tsao@intel.com>
---
 Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc b/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
index 37c77d8f..2f25bdb3 100644
--- a/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
+++ b/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
@@ -1,7 +1,7 @@
 ## @file
 #  Component description file for the Coffee Lake silicon package DSC file.
 #
-# Copyright (c) 2019 Intel Corporation. All rights reserved. <BR>
+# Copyright (c) 2019 - 2020 Intel Corporation. All rights reserved. <BR>
 #
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -147,7 +147,7 @@ gUefiCpuPkgTokenSpaceGuid.PcdCpuApTargetCstate|0
 # Silicon Init Common Library
 #
 !include $(PLATFORM_SI_PACKAGE)/SiPkgCommonLib.dsc
-ConfigBlockLib|ClientSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlockLib.inf
+ConfigBlockLib|IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlockLib.inf
 PchTraceHubInitLib|ClientSiliconPkg/Library/BasePchTraceHubInitLib/BasePchTraceHubInitLib.inf
 
 [LibraryClasses.IA32]
-- 
2.16.2.windows.1

Re: [PATCH] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h

[Chiu, Chasel]

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>

> -----Original Message-----
> From: Chen, TinaX Y <tinax.y.chen@intel.com>
> Sent: Monday, March 16, 2020 10:41 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> Tsao, Ethan <ethan.tsao@intel.com>
> Subject: [PATCH] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2318
> 
> Change reference path of ConfigBlockLib to IntelSiliconPkg for Coffeelake.
> 
> Change-Id: I433e0a7a00c0cc15a0986050c203c7ca8aef02a2
> Signed-off-by: TinaX Y Chen <tinax.y.chen@intel.com>
> cc: Ray Ni <ray.ni@intel.com>
> cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> cc: Chasel Chiu <chasel.chiu@intel.com>
> cc: Ethan Tsao <ethan.tsao@intel.com>
> ---
>  Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
> b/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
> index 37c77d8f..2f25bdb3 100644
> --- a/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
> +++ b/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
> @@ -1,7 +1,7 @@
>  ## @file
>  #  Component description file for the Coffee Lake silicon package DSC file.
>  #
> -# Copyright (c) 2019 Intel Corporation. All rights reserved. <BR>
> +# Copyright (c) 2019 - 2020 Intel Corporation. All rights reserved.
> +<BR>
>  #
>  # SPDX-License-Identifier: BSD-2-Clause-Patent  # @@ -147,7 +147,7 @@
> gUefiCpuPkgTokenSpaceGuid.PcdCpuApTargetCstate|0
>  # Silicon Init Common Library
>  #
>  !include $(PLATFORM_SI_PACKAGE)/SiPkgCommonLib.dsc
> -ConfigBlockLib|ClientSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBl
> -ConfigBlockLib|ockLib.inf
> +ConfigBlockLib|IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigBlo
> +ConfigBlockLib|ckLib.inf
> 
> PchTraceHubInitLib|ClientSiliconPkg/Library/BasePchTraceHubInitLib/BasePch
> TraceHubInitLib.inf
> 
>  [LibraryClasses.IA32]
> --
> 2.16.2.windows.1

Re: [PATCH] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h

[Chiu, Chasel]

Sorry Tina, the commit message and code review subject format were wrong, please refer to other edk2-platform patches and re-send again.

Thanks,
Chasel


> -----Original Message-----
> From: Chiu, Chasel
> Sent: Tuesday, March 17, 2020 8:08 AM
> To: Chen, TinaX Y <tinax.y.chen@intel.com>; devel@edk2.groups.io
> Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> <rangasai.v.chaganty@intel.com>; Tsao, Ethan <ethan.tsao@intel.com>
> Subject: RE: [PATCH] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h
> 
> 
> Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
> 
> > -----Original Message-----
> > From: Chen, TinaX Y <tinax.y.chen@intel.com>
> > Sent: Monday, March 16, 2020 10:41 PM
> > To: devel@edk2.groups.io
> > Cc: Ni, Ray <ray.ni@intel.com>; Chaganty, Rangasai V
> > <rangasai.v.chaganty@intel.com>; Chiu, Chasel <chasel.chiu@intel.com>;
> > Tsao, Ethan <ethan.tsao@intel.com>
> > Subject: [PATCH] IntelSiliconPkg/Include/Library:Add ConfigBlockLib.h
> >
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2318
> >
> > Change reference path of ConfigBlockLib to IntelSiliconPkg for Coffeelake.
> >
> > Change-Id: I433e0a7a00c0cc15a0986050c203c7ca8aef02a2
> > Signed-off-by: TinaX Y Chen <tinax.y.chen@intel.com>
> > cc: Ray Ni <ray.ni@intel.com>
> > cc: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
> > cc: Chasel Chiu <chasel.chiu@intel.com>
> > cc: Ethan Tsao <ethan.tsao@intel.com>
> > ---
> >  Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git
> > a/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
> > b/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
> > index 37c77d8f..2f25bdb3 100644
> > --- a/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
> > +++ b/Silicon/Intel/CoffeelakeSiliconPkg/CoffeelakeSiliconPkg.dsc
> > @@ -1,7 +1,7 @@
> >  ## @file
> >  #  Component description file for the Coffee Lake silicon package DSC
> file.
> >  #
> > -# Copyright (c) 2019 Intel Corporation. All rights reserved. <BR>
> > +# Copyright (c) 2019 - 2020 Intel Corporation. All rights reserved.
> > +<BR>
> >  #
> >  # SPDX-License-Identifier: BSD-2-Clause-Patent  # @@ -147,7 +147,7 @@
> > gUefiCpuPkgTokenSpaceGuid.PcdCpuApTargetCstate|0
> >  # Silicon Init Common Library
> >  #
> >  !include $(PLATFORM_SI_PACKAGE)/SiPkgCommonLib.dsc
> > -ConfigBlockLib|ClientSiliconPkg/Library/BaseConfigBlockLib/BaseConfig
> > -ConfigBlockLib|Bl
> > -ConfigBlockLib|ockLib.inf
> > +ConfigBlockLib|IntelSiliconPkg/Library/BaseConfigBlockLib/BaseConfigB
> > +ConfigBlockLib|lo
> > +ConfigBlockLib|ckLib.inf
> >
> > PchTraceHubInitLib|ClientSiliconPkg/Library/BasePchTraceHubInitLib/Bas
> > PchTraceHubInitLib|ePch
> > TraceHubInitLib.inf
> >
> >  [LibraryClasses.IA32]
> > --
> > 2.16.2.windows.1