From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=zhichao.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1AD33211D59DF for ; Wed, 6 Mar 2019 16:44:35 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Mar 2019 16:44:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.58,449,1544515200"; d="scan'208,217";a="139788095" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga002.jf.intel.com with ESMTP; 06 Mar 2019 16:44:33 -0800 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 6 Mar 2019 16:44:33 -0800 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 6 Mar 2019 16:44:32 -0800 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.158]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.57]) with mapi id 14.03.0415.000; Thu, 7 Mar 2019 08:44:30 +0800 From: "Gao, Zhichao" To: "Carsey, Jaben" , Nariman Poushin CC: "edk2-devel@lists.01.org" , "Gao, Liming" Thread-Topic: [edk2] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni Thread-Index: AQHU1DMihyTjlq4BwkukyTrBY8OReKX+PR4AgAAM2gCAAQlP0A== Date: Thu, 7 Mar 2019 00:44:30 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B7AF179@SHSMSX101.ccr.corp.intel.com> References: <20190306070514.19220-1-zhichao.gao@intel.com> , In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZjkwNGZiOTktZGI0NS00NThkLWExOWQtMDQ3MTRmMGMxZDdiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiQlZkMGF4NDNnd2VOdTFuQlgycTB4dDZYclVyOXJ3UTdyaGVaejhsQm9sakg3R0k3UVMxOXR4cVwvS0k0N1JXQWkifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note in uni X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 07 Mar 2019 00:44:35 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for your careful check. I would update it. Thanks, Zhichao From: Carsey, Jaben Sent: Thursday, March 7, 2019 12:47 AM To: Nariman Poushin Cc: Gao, Zhichao ; edk2-devel@lists.01.org; Gao, Li= ming Subject: Re: [edk2] [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change t= he note in uni Good catch. After fixing this typo, my RB stands. On Mar 6, 2019, at 7:59 AM, Nariman Poushin > wrote: On Wed, 6 Mar 2019 at 15:54, Carsey, Jaben > wrote: Reviewed-by: Jaben Carsey > > -----Original Message----- > From: Gao, Zhichao > Sent: Tuesday, March 05, 2019 11:05 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ray >; Carsey, Jaben <= jaben.carsey@intel.com>; > Gao, Liming > > Subject: [PATCH] ShellPkg/UefiShellAcpiViewCommandLib: Change the note > in uni > Importance: High > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1146 > > Add DSDT and SSDT description in the help information. Depend > on the implement of UefiShellAcpiViewCommandLib, the "acpiview" > command support to show all present type in the system not only > support the listed type in the help information. So change the > help information of this command. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Zhichao Gao > > Cc: Ruiyu Ni > > Cc: Jaben Carsey > > Cc: Liming Gao > > --- > .../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni | 8 > +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) > > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm > andLib.uni > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm > andLib.uni > index 0762eeba53..f2a2400b91 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm > andLib.uni > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm > andLib.uni > @@ -74,10 +74,15 @@ > " 1. The AcpiTable parameter can match any installed table type.\r\n" > " Tables without specific handling will be displayed as a raw hex d= ump > (or\r\n" > " dumped to a file if -d is used).\r\n" > -" 2. Formatted display and checking is provided for these signature > types:\r\n" > +" 2. -s option supports to display the specified AcpiTable type that i= s > present\r\n" > +" in the system. For normal type AcpiTable, it would display the da= ta of > the\r\n" > +" AcpiTable and AcpiTable header. The following type may contain he= ader > type\r\n" > +" other than AcpiTable header. The acual header can refer to the AC= PI > spec 6.2\r\n" > +" Extra A. Particual types:\r\n" Should this be "Particular"? > " APIC - Multiple APIC Description Table (MADT)\r\n" > " BGRT - Boot Graphics Resource Table\r\n" > " DBG2 - Debug Port Table 2\r\n" > +" DSDT - Differentiated System Description Table\r\n" > " FACP - Fixed ACPI Description Table (FADT)\r\n" > " GTDT - Generic Timer Description Table\r\n" > " IORT - IO Remapping Table\r\n" > @@ -87,6 +92,7 @@ > " SLIT - System Locality Information Table\r\n" > " SPCR - Serial Port Console Redirection Table\r\n" > " SRAT - System Resource Affinity Table\r\n" > +" SSDT - Secondary SystemDescription Table\r\n" > " XSDT - Extended System Description Table\r\n" > " \r\n" > ".SH STANDARDS\r\n" > -- > 2.16.2.windows.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel