Re: [PATCH V4 09/17] OvmfPkg/PlatformDebugLibIoPort: Add new APIs

["Gao, Zhichao" <zhichao.gao@intel.com>]

Sorry for forgetting to add tag.
I am new to this community and this wiki page would help me a lot. 

Thanks,
Zhichao

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Friday, March 22, 2019 2:58 AM
> To: Gao, Zhichao <zhichao.gao@intel.com>; edk2-devel@lists.01.org
> Cc: Justen, Jordan L <jordan.l.justen@intel.com>; Ard Biesheuvel
> <ard.biesheuvel@linaro.org>; Gao, Liming <liming.gao@intel.com>; Sean
> Brogan <sean.brogan@microsoft.com>; Michael Turner
> <Michael.Turner@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>
> Subject: Re: [PATCH V4 09/17] OvmfPkg/PlatformDebugLibIoPort: Add new
> APIs
> 
> On 03/21/19 15:04, Zhichao Gao wrote:
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1395
> >
> > Add new APIs' implementation (DebugVPrint, DebugBPrint) in the
> > DebugLib instance. These APIs would expose print routines with VaList
> > parameter and BaseList parameter.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> > Cc: Jordan Justen <jordan.l.justen@intel.com>
> > Cc: Laszlo Ersek <lersek@redhat.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Michael Turner <Michael.Turner@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > ---
> >  OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c | 106
> > +++++++++++++++++++++-
> >  1 file changed, 101 insertions(+), 5 deletions(-)
> 
> This v4 patch is identical to v3.
> 
> When you repost a series in order to update a subset of the patches, you
> should please pick up the feedback tags from the previous review session for
> those patches that you do *not* change.
> 
> This is explained here, for example:
> 
> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-
> guide-for-edk2-contributors-and-maintainers#contrib-26
> 
> https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-
> guide-for-edk2-contributors-and-maintainers#contrib-28
> 
> This makes a huge difference for reviewers -- it costs you a bit of time, but it
> saves reviewers a lot more time.
> 
> For example, the present patch has not been changed from v3 to v4, and I
> gave my A-b in the v3 review session. Therefore you should have edited the
> commit message on this patch, to include my A-b, for the v4 posting.
> 
> Either way, I can give it again here.
> 
> Acked-by: Laszlo Ersek <lersek@redhat.com>
> 
> Thanks
> Laszlo