From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.120; helo=mga04.intel.com; envelope-from=zhichao.gao@intel.com; receiver=edk2-devel@lists.01.org Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E8808211E2EED for ; Tue, 26 Mar 2019 18:21:33 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Mar 2019 18:21:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,274,1549958400"; d="scan'208";a="145518636" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga002.jf.intel.com with ESMTP; 26 Mar 2019 18:21:32 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 26 Mar 2019 18:21:32 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 26 Mar 2019 18:21:31 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.158]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.121]) with mapi id 14.03.0415.000; Wed, 27 Mar 2019 09:21:30 +0800 From: "Gao, Zhichao" To: Leif Lindholm CC: "edk2-devel@lists.01.org" , Ard Biesheuvel , "Gao, Liming" , "Sean Brogan" , Michael Turner , Bret Barkelew Thread-Topic: [PATCH V4 08/17] ArmPkg/SemiHostingDebugLib: Add new APIs Thread-Index: AQHU484j/obPP2lus0quI/qd1NE+gqYepJkw Date: Wed, 27 Mar 2019 01:21:29 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B7B225B@SHSMSX101.ccr.corp.intel.com> References: <20190321140459.18304-1-zhichao.gao@intel.com> <20190321140459.18304-9-zhichao.gao@intel.com> <20190326121906.uke2slmodkqvwvgy@bivouac.eciton.net> In-Reply-To: <20190326121906.uke2slmodkqvwvgy@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH V4 08/17] ArmPkg/SemiHostingDebugLib: Add new APIs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 27 Mar 2019 01:21:34 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for your reply. The variable "mVaListNull" I prefer to keep it as a module data even though= there is only one source file in this DebugLib inf. Thanks, Zhichao > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Tuesday, March 26, 2019 8:19 PM > To: Gao, Zhichao > Cc: edk2-devel@lists.01.org; Ard Biesheuvel ; > Gao, Liming ; Sean Brogan > ; Michael Turner > ; Bret Barkelew > > Subject: Re: [PATCH V4 08/17] ArmPkg/SemiHostingDebugLib: Add new APIs >=20 > Hi Zhichao, >=20 > Apologies for delay in responding, due to holiday and stuff. >=20 > On the whole this looks fine (one comment below), but I don't actually ha= ve > any platform on which to test this. >=20 > Ard: maybe it's time to retire this component? >=20 > On Thu, Mar 21, 2019 at 10:04:50PM +0800, Zhichao Gao wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1395 > > > > Add new APIs' implementation (DebugVPrint, DebugBPrint) in the > > DebugLib instance. These APIs would expose print routines with VaList > > parameter and BaseList parameter. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Zhichao Gao > > Cc: Leif Lindholm > > Cc: Ard Biesheuvel > > Cc: Liming Gao > > Cc: Sean Brogan > > Cc: Michael Turner > > Cc: Bret Barkelew > > --- > > ArmPkg/Library/SemiHostingDebugLib/DebugLib.c | 106 > > ++++++++++++++++++++++++-- > > 1 file changed, 101 insertions(+), 5 deletions(-) > > > > diff --git a/ArmPkg/Library/SemiHostingDebugLib/DebugLib.c > > b/ArmPkg/Library/SemiHostingDebugLib/DebugLib.c > > index ec03edb774..a368dd43b8 100644 > > --- a/ArmPkg/Library/SemiHostingDebugLib/DebugLib.c > > +++ b/ArmPkg/Library/SemiHostingDebugLib/DebugLib.c > > @@ -1,7 +1,7 @@ > > /** @file > > UEFI Debug Library that uses PrintLib to send messages to STDERR. > > > > - Copyright (c) 2006 - 2007, Intel Corporation. All rights > > reserved.
> > + Copyright (c) 2006 - 2019, Intel Corporation. All rights > > + reserved.
> > Portions copyright (c) 2008 - 2009, Apple Inc. All rights reserved.<= BR> > > This program and the accompanying materials > > are licensed and made available under the terms and conditions of > > the BSD License @@ -27,6 +27,12 @@ // #define > > MAX_DEBUG_MESSAGE_LENGTH 0x100 > > > > +// > > +// VA_LIST can not initialize to NULL for all compiler, so we use > > +this to // indicate a null VA_LIST // > > +VA_LIST mVaListNull; >=20 > I would prefer if this was marked STATIC. >=20 > If you feel strongly otherwise, leave it as is. > Either way: > Reviewed-by: Leif Lindholm >=20 > / > Leif >=20 > > + > > /** > > > > Prints a debug message to the debug output device if the specified e= rror > level is enabled. > > @@ -48,9 +54,41 @@ DebugPrint ( > > IN CONST CHAR8 *Format, > > ... > > ) > > +{ > > + VA_LIST Marker; > > + > > + VA_START (Marker, Format); > > + DebugVPrint (ErrorLevel, Format, Marker); > > + VA_END (Marker); > > +} > > + > > + > > +/** > > + Prints a debug message to the debug output device if the specified > > + error level is enabled base on Null-terminated format string and a > > + VA_LIST argument list or a BASE_LIST argument list. > > + > > + If any bit in ErrorLevel is also set in DebugPrintErrorLevelLib > > + function GetDebugPrintErrorLevel (), then print the message > > + specified by Format and the associated variable argument list to the > debug output device. > > + > > + If Format is NULL, then ASSERT(). > > + > > + @param ErrorLevel The error level of the debug message. > > + @param Format Format string for the debug message to print= . > > + @param VaListMarker VA_LIST marker for the variable argument lis= t. > > + @param BaseListMarker BASE_LIST marker for the variable argument > list. > > + > > +**/ > > +VOID > > +DebugPrintMarker ( > > + IN UINTN ErrorLevel, > > + IN CONST CHAR8 *Format, > > + IN VA_LIST VaListMarker, > > + IN BASE_LIST BaseListMarker > > + ) > > { > > CHAR8 AsciiBuffer[MAX_DEBUG_MESSAGE_LENGTH]; > > - VA_LIST Marker; > > > > // > > // If Format is NULL, then ASSERT(). > > @@ -67,14 +105,72 @@ DebugPrint ( > > // > > // Convert the DEBUG() message to a Unicode String > > // > > - VA_START (Marker, Format); > > - AsciiVSPrint (AsciiBuffer, sizeof (AsciiBuffer), Format, Marker); > > - VA_END (Marker); > > + if (BaseListMarker =3D=3D NULL) { > > + AsciiVSPrint (AsciiBuffer, sizeof (AsciiBuffer), Format, > > + VaListMarker); } else { > > + AsciiBSPrint (AsciiBuffer, sizeof (AsciiBuffer), Format, > > + BaseListMarker); } > > > > SemihostWriteString (AsciiBuffer); > > } > > > > > > +/** > > + Prints a debug message to the debug output device if the specified > > + error level is enabled. > > + > > + If any bit in ErrorLevel is also set in DebugPrintErrorLevelLib > > + function GetDebugPrintErrorLevel (), then print the message > > + specified by Format and the associated variable argument list to the > debug output device. > > + > > + If Format is NULL, then ASSERT(). > > + > > + @param ErrorLevel The error level of the debug message. > > + @param Format Format string for the debug message to print. > > + @param VaListMarker VA_LIST marker for the variable argument list. > > + > > +**/ > > +VOID > > +EFIAPI > > +DebugVPrint ( > > + IN UINTN ErrorLevel, > > + IN CONST CHAR8 *Format, > > + IN VA_LIST VaListMarker > > + ) > > +{ > > + DebugPrintMarker (ErrorLevel, Format, VaListMarker, NULL); } > > + > > + > > +/** > > + Prints a debug message to the debug output device if the specified > > + error level is enabled. > > + This function use BASE_LIST which would provide a more compatible > > + service than VA_LIST. > > + > > + If any bit in ErrorLevel is also set in DebugPrintErrorLevelLib > > + function GetDebugPrintErrorLevel (), then print the message > > + specified by Format and the associated variable argument list to the > debug output device. > > + > > + If Format is NULL, then ASSERT(). > > + > > + @param ErrorLevel The error level of the debug message. > > + @param Format Format string for the debug message to print= . > > + @param BaseListMarker BASE_LIST marker for the variable argument > list. > > + > > +**/ > > +VOID > > +EFIAPI > > +DebugBPrint ( > > + IN UINTN ErrorLevel, > > + IN CONST CHAR8 *Format, > > + IN BASE_LIST BaseListMarker > > + ) > > +{ > > + DebugPrintMarker (ErrorLevel, Format, mVaListNull, BaseListMarker); > > +} > > + > > + > > /** > > > > Prints an assert message containing a filename, line number, and > description. > > -- > > 2.16.2.windows.1 > >