From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Ye, Ting" <ting.ye@intel.com>,
Michael Turner <Michael.Turner@microsoft.com>,
Bret Barkelew <Bret.Barkelew@microsoft.com>,
"Gao, Liming" <liming.gao@intel.com>,
Gang Wei <gang.wei@intel.com>
Subject: Re: [PATCH 0/6] Add new APIs for BaseCryptLib
Date: Thu, 28 Mar 2019 04:04:43 +0000 [thread overview]
Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B7B2477@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503F58E264@shsmsx102.ccr.corp.intel.com>
Sorry for late reply. I have write a very simple test case for these new APIs. And the test result is as expected.
Refer to https://github.com/ZhichaoGao/edk2/commit/31938b606c6a6a1fdb560e3d0dd4e41a78e1d7e9
The section to test VerifyEKUsInPkcs7Signature is refer to https://github.com/Microsoft/mu_tiano_plus/tree/release/201808/CryptoPkg/UnitTests/VerifyPkcs7EkuUnitTestApp
Thanks,
Zhichao
> -----Original Message-----
> From: Yao, Jiewen
> Sent: Monday, March 25, 2019 4:22 PM
> To: Gao, Zhichao <zhichao.gao@intel.com>; edk2-devel@lists.01.org
> Cc: Ye, Ting <ting.ye@intel.com>; Michael Turner
> <Michael.Turner@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>; Gao, Liming <liming.gao@intel.com>;
> Gang Wei <gang.wei@intel.com>
> Subject: RE: [edk2] [PATCH 0/6] Add new APIs for BaseCryptLib
>
> Hi
> Would you please describe what unit test has been run for the new API ?
>
>
> > -----Original Message-----
> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> > Zhichao Gao
> > Sent: Monday, March 25, 2019 12:01 PM
> > To: edk2-devel@lists.01.org
> > Cc: Ye, Ting <ting.ye@intel.com>; Michael Turner
> > <Michael.Turner@microsoft.com>; Bret Barkelew
> > <Bret.Barkelew@microsoft.com>; Gao, Liming <liming.gao@intel.com>;
> > Gang Wei <gang.wei@intel.com>
> > Subject: [edk2] [PATCH 0/6] Add new APIs for BaseCryptLib
> >
> > Add new API to get organization name
> > Add new API VerifyEKUsInPkcs7Signature Add PKCS1v2 (RSAES-OAEP)
> > support
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> > Cc: Ting Ye <ting.ye@intel.com>
> > Cc: Gang Wei <gang.wei@intel.com>
> > Cc: Wang Jian J <jian.j.wang@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Michael Turner <Michael.Turner@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> >
> > Bret Barkelew (6):
> > CryptoPkg/BaseCryptLib.h: Add new API to get organization name
> > CryptoPkg/BaseCryptLib: Add new API to get organization name
> > CryptoPkg/BaseCryptLib.h: Add new API VerifyEKUsInPkcs7Signature
> > CryptoPkg/BaseCryptLib: Add new API VerifyEKUsInPkcs7Signature
> > CryptoPkg/BaseCryptLib.h: Add PKCS1v2 (RSAES-OAEP) support.
> > CryptoPkg/BaseCryptLib: Add PKCS1v2 (RSAES-OAEP) support.
> >
> > CryptoPkg/Include/Library/BaseCryptLib.h | 121 ++++-
> > CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 2 +
> > CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 4 +-
> > CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs1Oaep.c | 218 +++++++++
> > .../Library/BaseCryptLib/Pk/CryptPkcs1OaepNull.c | 61 +++
> > .../Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c | 539
> > +++++++++++++++++++++
> > .../BaseCryptLib/Pk/CryptPkcs7VerifyEkuRuntime.c | 75 +++
> > CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c | 102 +++-
> > CryptoPkg/Library/BaseCryptLib/Pk/CryptX509Null.c | 32 ++
> > CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 2 +
> > CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf | 2 +
> > 11 files changed, 1144 insertions(+), 14 deletions(-) create mode
> > 100644 CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs1Oaep.c
> > create mode 100644
> > CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs1OaepNull.c
> > create mode 100644
> > CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEku.c
> > create mode 100644
> > CryptoPkg/Library/BaseCryptLib/Pk/CryptPkcs7VerifyEkuRuntime.c
> >
> > --
> > 2.16.2.windows.1
> >
> > _______________________________________________
> > edk2-devel mailing list
> > edk2-devel@lists.01.org
> > https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2019-03-28 4:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 4:01 [PATCH 0/6] Add new APIs for BaseCryptLib Zhichao Gao
2019-03-25 4:01 ` [PATCH 1/6] CryptoPkg/BaseCryptLib.h: Add new API to get organization name Zhichao Gao
2019-03-25 4:01 ` [PATCH 2/6] CryptoPkg/BaseCryptLib: " Zhichao Gao
2019-03-25 4:01 ` [PATCH 3/6] CryptoPkg/BaseCryptLib.h: Add new API VerifyEKUsInPkcs7Signature Zhichao Gao
2019-03-25 4:01 ` [PATCH 4/6] CryptoPkg/BaseCryptLib: " Zhichao Gao
2019-03-25 4:01 ` [PATCH 5/6] CryptoPkg/BaseCryptLib.h: Add PKCS1v2 (RSAES-OAEP) support Zhichao Gao
2019-03-25 4:01 ` [PATCH 6/6] CryptoPkg/BaseCryptLib: " Zhichao Gao
2019-03-25 8:22 ` [PATCH 0/6] Add new APIs for BaseCryptLib Yao, Jiewen
2019-03-28 4:04 ` Gao, Zhichao [this message]
2019-04-17 5:57 ` [edk2] " Gao, Zhichao
2019-04-17 6:09 ` Wang, Jian J
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CE959C139B4C44DBEA1810E3AA6F9000B7B2477@SHSMSX101.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox