Re: [edk2-devel] [PATCH 1/1] ShellPkg/CommandLib: avoid NULL derefence and memory leak

["Gao, Zhichao" <zhichao.gao@intel.com>]

No problem with the attachment.
I usually use the command "git am --3way --ignore-space-change --keep-cr *.patch". That make the same meaning with your 'am' options if the patch is ok.
Compare with your attachment and the patch extract form the email, seems some blank lines is missing.

Thanks,
Zhichao

> -----Original Message-----
> From: Heinrich Schuchardt [mailto:xypron.glpk@gmx.de]
> Sent: Wednesday, April 10, 2019 12:37 AM
> To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io; Carsey,
> Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>; Leif Lindholm
> <leif.lindholm@linaro.org>
> Cc: Gao, Liming <liming.gao@intel.com>
> Subject: Re: [edk2-devel] [PATCH 1/1] ShellPkg/CommandLib: avoid NULL
> derefence and memory leak
> 
> On 4/9/19 7:33 AM, Gao, Zhichao wrote:
> > The patch code looks good to me.
> > But while I apply this patch, it will shows "error: corrupt patch at line 24"
> and " error: could not build fake ancestor". Maybe you direct change the
> patch file and remove some blank lines.
> > For Uefi BdsDxe driver, the variable "PlatfomLang" would be initialize all the
> time. But maybe other manufacturers may have their own Bds solution and
> do not set this variable. This patch makes the Shell app more compatible.
> >
> > Without the patch warning.
> > Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
> 
> Hello Zhichao,
> 
> I am not able to reproduce the problem. I resend you the patch as
> attachment.
> 
> When applying I had to use --keep-cr:
> 
> git am --keep-cr \
> ../patch/0001-ShellPkg-CommandLib-avoid-NULL-derefence-and-memory-
> .patch
> 
> I have found no way neither on Windows nor on Linux to create a patch that
> applies without --keep-cr.
> 
> If you still have a problem, please, send me your global and local gitconfig
> files, your .gitattributes and indicate on which operating system you are
> working with which git version.
> 
> Best regards
> 
> Heinrich