Re: [edk2-devel] [PATCH 1/5] MdeModulePkg: Change the SMM debug lib instance

["Gao, Zhichao" <zhichao.gao@intel.com>]

Sorry to forget change the commit message. I originally want to use PeiDxeDebugLibReportStatusCode to replace the UefiDebugLibConOut.
There may be some typos in other patches in these series. And there is also a comment conflicted with Doxygen rule . I would check and fix them.

Thanks,
Zhichao

> -----Original Message-----
> From: Wu, Hao A
> Sent: Thursday, April 11, 2019 4:45 PM
> To: devel@edk2.groups.io; Gao, Zhichao <zhichao.gao@intel.com>
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Ni, Ray <ray.ni@intel.com>; Zeng,
> Star <star.zeng@intel.com>; Gao, Liming <liming.gao@intel.com>; Sean
> Brogan <sean.brogan@microsoft.com>; Michael Turner
> <Michael.Turner@microsoft.com>; Bret Barkelew
> <Bret.Barkelew@microsoft.com>
> Subject: RE: [edk2-devel] [PATCH 1/5] MdeModulePkg: Change the SMM
> debug lib instance
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Gao, Zhichao
> > Sent: Wednesday, April 10, 2019 3:03 PM
> > To: devel@edk2.groups.io
> > Cc: Wang, Jian J; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan;
> > Michael Turner; Bret Barkelew
> > Subject: [edk2-devel] [PATCH 1/5] MdeModulePkg: Change the SMM
> debug
> > lib instance
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1416
> >
> > The UefiDebugLibConOut will not support DXE_SMM_DRIVER, change
> > UefiDebugLibConOut to PeiDxeDebugLibReportStatusCode.
> 
> Is this a typo?
> Should be 'BaseDebugLibNull' according to your change.
> 
> With this addressed,
> Reviewed-by: Hao Wu <hao.a.wu@intel.com>
> 
> 
> Best Regards,
> Hao Wu
> 
> >
> > Cc: Jian J Wang <jian.j.wang@intel.com>
> > Cc: Ray Ni <ray.ni@intel.com>
> > Cc: Star Zeng <star.zeng@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Michael Turner <Michael.Turner@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> > ---
> >  MdeModulePkg/MdeModulePkg.dsc | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/MdeModulePkg/MdeModulePkg.dsc
> > b/MdeModulePkg/MdeModulePkg.dsc index 7ef39af847..0da28e74c2
> 100644
> > --- a/MdeModulePkg/MdeModulePkg.dsc
> > +++ b/MdeModulePkg/MdeModulePkg.dsc
> > @@ -144,7 +144,7 @@
> >
> >  [LibraryClasses.common.DXE_SMM_DRIVER]
> >    HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf
> > -
> DebugLib|MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf
> > +  DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf
> >
> >
> MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMe
> > moryAllocationLib.inf
> >
> >
> MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTabl
> > eLib.inf
> >
> >
> SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesT
> > ableLib.inf
> > --
> > 2.21.0.windows.1
> >
> >
> >