From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: zhichao.gao@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Thu, 11 Apr 2019 02:29:04 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 11 Apr 2019 02:29:03 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,336,1549958400"; d="scan'208";a="130439650" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga007.jf.intel.com with ESMTP; 11 Apr 2019 02:29:01 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 11 Apr 2019 02:29:02 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 11 Apr 2019 02:29:02 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.164]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.139]) with mapi id 14.03.0415.000; Thu, 11 Apr 2019 17:28:58 +0800 From: "Gao, Zhichao" To: "Wu, Hao A" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Ni, Ray" , "Zeng, Star" , "Gao, Liming" , Sean Brogan , Michael Turner , Bret Barkelew Subject: Re: [edk2-devel] [PATCH 1/5] MdeModulePkg: Change the SMM debug lib instance Thread-Topic: [edk2-devel] [PATCH 1/5] MdeModulePkg: Change the SMM debug lib instance Thread-Index: AQHU72uYPKb2CmnknkGp9Ny30+jS1qY2pnUAgAALIXA= Date: Thu, 11 Apr 2019 09:28:58 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B7C17DA@SHSMSX101.ccr.corp.intel.com> References: <20190410070313.15092-1-zhichao.gao@intel.com> <20190410070313.15092-2-zhichao.gao@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Sorry to forget change the commit message. I originally want to use PeiDxeD= ebugLibReportStatusCode to replace the UefiDebugLibConOut. There may be some typos in other patches in these series. And there is als= o a comment conflicted with Doxygen rule . I would check and fix them. Thanks, Zhichao > -----Original Message----- > From: Wu, Hao A > Sent: Thursday, April 11, 2019 4:45 PM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Wang, Jian J ; Ni, Ray ; Ze= ng, > Star ; Gao, Liming ; Sean > Brogan ; Michael Turner > ; Bret Barkelew > > Subject: RE: [edk2-devel] [PATCH 1/5] MdeModulePkg: Change the SMM > debug lib instance >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Gao, Zhichao > > Sent: Wednesday, April 10, 2019 3:03 PM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan; > > Michael Turner; Bret Barkelew > > Subject: [edk2-devel] [PATCH 1/5] MdeModulePkg: Change the SMM > debug > > lib instance > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1416 > > > > The UefiDebugLibConOut will not support DXE_SMM_DRIVER, change > > UefiDebugLibConOut to PeiDxeDebugLibReportStatusCode. >=20 > Is this a typo? > Should be 'BaseDebugLibNull' according to your change. >=20 > With this addressed, > Reviewed-by: Hao Wu >=20 >=20 > Best Regards, > Hao Wu >=20 > > > > Cc: Jian J Wang > > Cc: Ray Ni > > Cc: Star Zeng > > Cc: Liming Gao > > Cc: Sean Brogan > > Cc: Michael Turner > > Cc: Bret Barkelew > > Signed-off-by: Zhichao Gao > > --- > > MdeModulePkg/MdeModulePkg.dsc | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/MdeModulePkg/MdeModulePkg.dsc > > b/MdeModulePkg/MdeModulePkg.dsc index 7ef39af847..0da28e74c2 > 100644 > > --- a/MdeModulePkg/MdeModulePkg.dsc > > +++ b/MdeModulePkg/MdeModulePkg.dsc > > @@ -144,7 +144,7 @@ > > > > [LibraryClasses.common.DXE_SMM_DRIVER] > > HobLib|MdePkg/Library/DxeHobLib/DxeHobLib.inf > > - > DebugLib|MdePkg/Library/UefiDebugLibConOut/UefiDebugLibConOut.inf > > + DebugLib|MdePkg/Library/BaseDebugLibNull/BaseDebugLibNull.inf > > > > > MemoryAllocationLib|MdePkg/Library/SmmMemoryAllocationLib/SmmMe > > moryAllocationLib.inf > > > > > MmServicesTableLib|MdePkg/Library/MmServicesTableLib/MmServicesTabl > > eLib.inf > > > > > SmmServicesTableLib|MdePkg/Library/SmmServicesTableLib/SmmServicesT > > ableLib.inf > > -- > > 2.21.0.windows.1 > > > > > >=20