Re: [edk2-devel] [edk2] [PATCH] MdeModulePkg/CapsulePei: Update the debug code to print 64bit data

["Gao, Zhichao" <zhichao.gao@intel.com>]

Hi Phil,

Sorry I missed this email again.

When you reply to me, I get the email from the groups.io. It is not directly to me.
I make a folder contained all the email from groups.io. And it would receive so many emails and it is hard for me to view them all. So I may miss some important emails.
I just join the groups.io and install a Extractpatch tool to the email software. Did I miss something or some settings?

Thanks,
Zhichao

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Philippe Mathieu-Daudé
> Sent: Thursday, April 11, 2019 6:33 PM
> To: devel@edk2.groups.io; Gao, Zhichao <zhichao.gao@intel.com>; Wu, Hao
> A <hao.a.wu@intel.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>; Michael Turner
> <Michael.Turner@microsoft.com>; Gao, Liming <liming.gao@intel.com>;
> Zeng, Star <star.zeng@intel.com>; Wang, Jian J <jian.j.wang@intel.com>;
> stephano <stephano.cetola@linux.intel.com>
> Subject: Re: [edk2-devel] [edk2] [PATCH] MdeModulePkg/CapsulePei:
> Update the debug code to print 64bit data
> 
> Hi Zhichao,
> 
> This is not a technical comment related to your patch.
> 
> I understand the migration from lists.01.org to edk2.groups.io was in part
> motivated to help developpers having a restricted email setup to easily use a
> mailing list. I see you top posting your replies so I wonder if groups.io is really
> helpful to you.
> Are you missing other features that would make your list email workflow
> easier?
> 
> Thanks,
> 
> Phil.
> 
> On 4/11/19 11:33 AM, Gao, Zhichao wrote:
> > Thanks for you advices.
> >
> > I would better to keep the 'UINTN' with '%x' because PEIM is compiled as
> 32 bit object. And lots of PEIMs keep this combine.
> >
> > Thanks,
> > Zhichao
> >
> >> -----Original Message-----
> >> From: Wu, Hao A
> >> Sent: Thursday, April 11, 2019 4:12 PM
> >> To: Gao, Zhichao <zhichao.gao@intel.com>; Philippe Mathieu-Daudé
> >> <philmd@redhat.com>; devel@edk2.groups.io
> >> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>; Michael Turner
> >> <Michael.Turner@microsoft.com>; Gao, Liming <liming.gao@intel.com>;
> >> Zeng, Star <star.zeng@intel.com>; Wang, Jian J
> >> <jian.j.wang@intel.com>
> >> Subject: RE: [edk2] [PATCH] MdeModulePkg/CapsulePei: Update the
> debug
> >> code to print 64bit data
> >>
> >>> -----Original Message-----
> >>> From: Gao, Zhichao
> >>> Sent: Thursday, April 11, 2019 3:47 PM
> >>> To: Philippe Mathieu-Daudé; devel@edk2.groups.io
> >>> Cc: Bret Barkelew; Michael Turner; Gao, Liming; Zeng, Star; Wu, Hao
> >>> A; Wang, Jian J
> >>> Subject: RE: [edk2] [PATCH] MdeModulePkg/CapsulePei: Update the
> >> debug
> >>> code to print 64bit data
> >>>
> >>> Sorry for missing this email.
> >>>
> >>> While I change the code, it couldn't pass the Patchcher.py because
> >>> of the 'EFI_D_" version MACRO. So I change all the debug message in
> >>> this
> >> driver.
> >>> Maybe that is a redundant work.
> >>
> >> Hello Zhichao,
> >>
> >> For this case, you can work out a first patch to replace all the
> >> macros starting with 'EFI_D_' with 'DEBUG_'. And a second patch to
> address the real issue.
> >>
> >>>
> >>> Thanks,
> >>> Zhichao
> >>>
> >>>> -----Original Message-----
> >>>> From: Philippe Mathieu-Daudé [mailto:philmd@redhat.com]
> >>>> Sent: Tuesday, April 2, 2019 11:36 PM
> >>>> To: Gao, Zhichao <zhichao.gao@intel.com>; edk2-devel@lists.01.org
> >>>> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>; Michael Turner
> >>>> <Michael.Turner@microsoft.com>; Gao, Liming
> <liming.gao@intel.com>;
> >>>> Zeng, Star <star.zeng@intel.com>
> >>>> Subject: Re: [edk2] [PATCH] MdeModulePkg/CapsulePei: Update the
> >>> debug
> >>>> code to print 64bit data
> >>>>
> >>>> Hi Bret,
> >>>>
> >>>> On 4/2/19 7:50 AM, Zhichao Gao wrote:
> >>>>> From: Bret Barkelew <Bret.Barkelew@microsoft.com>
> >>>>>
> >>>>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1677
> >>>>>
> >>>>> For some pointer and UINT64 data, the debug code print with '%x'.
> >>>>> Which would loss the upper 32bit data. So update '%x' to '%lx'
> >>>>> for these data.
> >>>>
> >>>> Some are UINTN. Per Laszlo answer on this thread:
> >>>> https://lists.01.org/pipermail/edk2-devel/2016-
> September/002093.htm
> >>>> l for those, casting and changing format is the accepted way.
> >>
> >> After a skim of the patch, I think there seems only 2 cases that are
> >> handled in this patch:
> >>
> >> 1. UINT64
> >> For this one, the change in this patch looks good to me.
> >>
> >> 2. Pointers
> >> I think we can directly use '%p' for pointers.
> >>
> >> If I happen to miss other cases, please do follow the above link to
> >> handle UINTN.
> >>
> >>
> >> Best Regards,
> >> Hao Wu
> >>
> >>>>
> >>>> However this is a change,
> >>>>
> >>>>> Change the DEBUG PrintLevel from EFI_D_ version to DEBUG_ version.
> >>>>> DEBUG_ version is recommended to use.
> >>>>
> >>>> and this is another change.
> >>>>
> >>>> Splitting this patch in 2 would make it more digestable.
> [...]
> 
>