From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: zhichao.gao@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Sun, 21 Apr 2019 19:51:02 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Apr 2019 19:51:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,380,1549958400"; d="scan'208";a="137676357" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga006.jf.intel.com with ESMTP; 21 Apr 2019 19:51:01 -0700 Received: from fmsmsx119.amr.corp.intel.com (10.18.124.207) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 21 Apr 2019 19:51:00 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX119.amr.corp.intel.com (10.18.124.207) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 21 Apr 2019 19:49:58 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.164]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.93]) with mapi id 14.03.0415.000; Mon, 22 Apr 2019 10:49:56 +0800 From: "Gao, Zhichao" To: "Bu, Daocheng" , "devel@edk2.groups.io" CC: "Piwko, Maciej" , "Oram, Isaac W" , "Gao, Liming" Subject: Re: [edk2-platforms/devel-MinPlatform][PATCH 3/5] LewisburgPkg/DxeRuntimeResetSystemLib: Add a new API ResetSystem Thread-Topic: [edk2-platforms/devel-MinPlatform][PATCH 3/5] LewisburgPkg/DxeRuntimeResetSystemLib: Add a new API ResetSystem Thread-Index: AQHU8zh0c8w3+wctUEGoZc/9yFS7a6Y82i3QgASOg9A= Date: Mon, 22 Apr 2019 02:49:55 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B7C37FA@SHSMSX101.ccr.corp.intel.com> References: <20190415030739.14328-1-zhichao.gao@intel.com> <20190415030739.14328-5-zhichao.gao@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, I didn't receive any comments with this patch yet. Maybe you missed this em= ail. The new added function is only a few part of the ResetSystemRuntimeDxe to p= rovide the reset function. As I know, platforms always have their own ResetSystemLib instance and do n= ot use the instance in MdeModulePkg. While the platform contains a driver base on the new interface(the driver m= ay be in the edk2 repo), the driver would not find the interface's implemen= t and cause a link error. I suggest all platform code should update it to avoid the link error if the= platform is working with the edk2 master repo. Thanks, Zhichao > -----Original Message----- > From: Bu, Daocheng > Sent: Monday, April 15, 2019 3:56 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Piwko, Maciej ; Oram, Isaac W > ; Gao, Liming > Subject: RE: [edk2-platforms/devel-MinPlatform][PATCH 3/5] > LewisburgPkg/DxeRuntimeResetSystemLib: Add a new API ResetSystem >=20 >=20 > Hi Maciej, >=20 > Please help review this code from PCH perspective. > If you approve this change , please also help cherry pick this change to > ServerSiliconPkg\Pch\SouthClusterLbg pkg @10nm trunk. >=20 > Thanks, > Amos >=20 > UEFI FW, IAFW or System Firmware is more generic & accurate it's not BIOS > anymore! >=20 > -----Original Message----- > From: Gao, Zhichao > Sent: Monday, April 15, 2019 11:08 AM > To: devel@edk2.groups.io > Cc: Piwko, Maciej ; Bu, Daocheng > ; Oram, Isaac W ; Gao, > Liming > Subject: [edk2-platforms/devel-MinPlatform][PATCH 3/5] > LewisburgPkg/DxeRuntimeResetSystemLib: Add a new API ResetSystem >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1460 >=20 > Add a new API ResetSystem to this ResetSystemLib instance. > It only adds the basic functions from ResetSystemRuntimeDxe. > Lacking of this interface may cause link error, if some drivers use this = new API > and link to this library instance. > Make the ResetPlatformSpecific's parameters same with the interface in > Edk2 repo. > Notes: > This library API only provide a basic function of reset. If the consumers= want > full functions, they should use the instance in the MdeModulePkg and make > sure the depex driver is dispatched. >=20 > Cc: "Piwko, Maciej" > Cc: "Bu, Daocheng" > Cc: "Oram, Isaac W" > Cc: Liming Gao > Signed-off-by: Zhichao Gao > --- > .../DxeRuntimeResetSystemLib/PchReset.c | 47 +++++++++++++++++-- > 1 file changed, 44 insertions(+), 3 deletions(-) >=20 > diff --git > a/Silicon/Intel/LewisburgPkg/Library/DxeRuntimeResetSystemLib/PchReset. > c > b/Silicon/Intel/LewisburgPkg/Library/DxeRuntimeResetSystemLib/PchReset. > c > index cdc0f19c17..673f42e72c 100644 > --- > a/Silicon/Intel/LewisburgPkg/Library/DxeRuntimeResetSystemLib/PchReset. > c > +++ > b/Silicon/Intel/LewisburgPkg/Library/DxeRuntimeResetSystemLib/PchRes > +++ et.c > @@ -1,6 +1,6 @@ > /** @file >=20 > -Copyright (c) 2018, Intel Corporation. All rights reserved.
> +Copyright (c) 2018 - 2019, Intel Corporation. All rights reserved.
> This program and the accompanying materials are licensed and made > available under the terms and conditions of the BSD License that > accompanies this distribution. > The full text of the license may be found at @@ -255,7 +255,6 @@ > ResetShutdown ( > /** > Calling this function causes the system to enter a power state for pla= tform > specific. >=20 > - @param[in] ResetStatus The status code for the reset. > @param[in] DataSize The size of ResetData in bytes. > @param[in] ResetData Optional element used to introduce a p= latform > specific reset. > The exact type of the reset is defined= by the EFI_GUID that > follows @@ -265,7 +264,6 @@ ResetShutdown ( VOID EFIAPI > ResetPlatformSpecific ( > - IN EFI_STATUS ResetStatus, > IN UINTN DataSize, > IN VOID *ResetData OPTIONAL > ) > @@ -306,6 +304,49 @@ EnterS3WithImmediateWake ( > PchReset (mPchResetInstance, (PCH_RESET_TYPE) EfiResetWarm); } >=20 > +/** > + The ResetSystem function resets the entire platform. > + > + @param[in] ResetType The type of reset to perform. > + @param[in] ResetStatus The status code for the reset. > + @param[in] DataSize The size, in bytes, of ResetData. > + @param[in] ResetData For a ResetType of EfiResetCold, EfiResetWar= m, > or EfiResetShutdown > + the data buffer starts with a Null-terminate= d string, optionally > + followed by additional binary data. The stri= ng is a description > + that the caller may use to further indicate = the reason for the > + system reset. > +**/ > +VOID > +EFIAPI > +ResetSystem ( > + IN EFI_RESET_TYPE ResetType, > + IN EFI_STATUS ResetStatus, > + IN UINTN DataSize, > + IN VOID *ResetData OPTIONAL > + ) > +{ > + switch (ResetType) { > + case EfiResetWarm: > + ResetWarm (); > + break; > + > + case EfiResetCold: > + ResetCold (); > + break; > + > + case EfiResetShutdown: > + ResetShutdown (); > + return ; > + > + case EfiResetPlatformSpecific: > + ResetPlatformSpecific (DataSize, ResetData); > + return; > + > + default: > + return ; > + } > +} > + > /** > PchReset Runtime DXE Driver Entry Point\n > - Introduction\n > -- > 2.21.0.windows.1