Re: [edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: Remove the blank line in the comments

Re: [edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: Remove the blank line in the comments

[Gao, Zhichao]

Add Dandan
And I have checked with Ecc tool. It would not cause 'error code: 9001' with this patch.

Thanks,
Zhichao

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Gao, Zhichao
> Sent: Sunday, April 28, 2019 10:26 AM
> To: devel@edk2.groups.io
> Cc: Wang, Jian J <jian.j.wang@intel.com>; Ye, Ting <ting.ye@intel.com>
> Subject: [edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: Remove the blank
> line in the comments
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1736
> 
> For accroding with the doxygen special documention blocks in section 2.3.5,
> removing the blank line in the file comments of the file header for
> PeiCryptLib.inf
> 
> Cc: Jian Wang <jian.j.wang@intel.com>
> Cc: Ting Ye <ting.ye@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
>  CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> index 0166f0b360..415dda3078 100644
> --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> @@ -15,7 +15,6 @@
>  #
>  #  Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.<BR>  #
> SPDX-License-Identifier: BSD-2-Clause-Patent
> -
>  #
>  ##
> 
> --
> 2.21.0.windows.1
> 
> 
> 

Re: [edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: Remove the blank line in the comments

[Wang, Jian J]

Pushed at 038f929c921c3b6f2fb47a79f0e89caa0ed649c0

Regards,
Jian


> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Wang,
> Jian J
> Sent: Sunday, April 28, 2019 4:02 PM
> To: Gao, Zhichao <zhichao.gao@intel.com>; devel@edk2.groups.io
> Cc: Ye, Ting <ting.ye@intel.com>
> Subject: Re: [edk2-devel] [PATCH] CryptoPkg/BaseCryptLib: Remove the blank
> line in the comments
> 
> 
> 
> Reviewed-by: Jian J Wang <jian.j.wang@intel.com>
> 
> > -----Original Message-----
> > From: Gao, Zhichao
> > Sent: Sunday, April 28, 2019 10:26 AM
> > To: devel@edk2.groups.io
> > Cc: Wang, Jian J <jian.j.wang@intel.com>; Ye, Ting <ting.ye@intel.com>
> > Subject: [PATCH] CryptoPkg/BaseCryptLib: Remove the blank line in the
> > comments
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1736
> >
> > For accroding with the doxygen special documention blocks
> > in section 2.3.5, removing the blank line in the file comments
> > of the file header for PeiCryptLib.inf
> >
> > Cc: Jian Wang <jian.j.wang@intel.com>
> > Cc: Ting Ye <ting.ye@intel.com>
> > Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> > ---
> >  CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> > b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> > index 0166f0b360..415dda3078 100644
> > --- a/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> > +++ b/CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf
> > @@ -15,7 +15,6 @@
> >  #
> >  #  Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.<BR>
> >  #  SPDX-License-Identifier: BSD-2-Clause-Patent
> > -
> >  #
> >  ##
> >
> > --
> > 2.21.0.windows.1
> 
> 
>