From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: zhichao.gao@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Wed, 08 May 2019 20:39:28 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 May 2019 20:39:27 -0700 X-ExtLoop1: 1 Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga002.jf.intel.com with ESMTP; 08 May 2019 20:39:27 -0700 Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 8 May 2019 20:39:27 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 8 May 2019 20:39:26 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.129]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.33]) with mapi id 14.03.0415.000; Thu, 9 May 2019 11:39:24 +0800 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "krzysztof.koch@arm.com" , "Gao, Liming" CC: "Carsey, Jaben" , "Ni, Ray" , "Sami.Mujawar@arm.com" , "Girish.Pathak@arm.com" , "Pierre.Gondois@arm.com" , "Matteo.Carlini@arm.com" , "Stephanie.Hughes-Fitt@arm.com" , "nd@arm.com" Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg: Display VENDOR_ID in ASCII when parsing PPTT Thread-Topic: [edk2-devel] [PATCH v1 1/1] ShellPkg: Display VENDOR_ID in ASCII when parsing PPTT Thread-Index: AQHVBZ/38rDmHHlMdEWs/dvWOjbryaZiHE8Q Date: Thu, 9 May 2019 03:39:23 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B7D21C2@SHSMSX101.ccr.corp.intel.com> References: <20190508131354.59672-1-krzysztof.koch@arm.com> In-Reply-To: <20190508131354.59672-1-krzysztof.koch@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The patch looks good for me. And make the Vender Id to be ASCII format make more sense than hex data fo= rmat depend on the info in https://uefi.org/ACPI_ID_List?search. I'd like to test it on some real open platform. But seems most platforms d= o not install PPTT. By the way I can't 'am' your patch directly. I extract your patch form ema= il with some warning. Maybe it is because of your addition info below Signe= d-off-by tag. Without that. Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Krzysztof Koch > Sent: Wednesday, May 8, 2019 9:14 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Sami.Mujawar@arm.com; Girish.Pathak@arm.com; > Pierre.Gondois@arm.com; Matteo.Carlini@arm.com; Stephanie.Hughes- > Fitt@arm.com; nd@arm.com > Subject: [edk2-devel] [PATCH v1 1/1] ShellPkg: Display VENDOR_ID in ASCI= I > when parsing PPTT >=20 > The ID Type Structure (Type 2) inside the Processor Properties Topology > Table (PPTT) has a VENDOR_ID field which identifies the node vendor. The > approved values are listed in the ACPI ID Registry and they are meant to= be > interpreted as arrays of ASCII characters. >=20 > This change to the acpiview parser for PPTT aims to reflect that. >=20 > Signed-off-by: Krzysztof Koch > --- >=20 > The changes can be seen at: > https://github.com/KrzysztofKoch1/edk2/tree/woa_500_print_vendor_id_a > scii_v1 >=20 > Notes: > v1: > - Display VENDOR_ID in ASCII [Krzysztof] >=20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c > | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser. > c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser. > c > index > c6588a12b4639f2bf6f0953d98410befbab66e31..ffcc53cda7d8df1d2f0787c1b4b > 1d30de87ac854 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser. > c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttPars > +++ er.c > @@ -150,7 +150,7 @@ STATIC CONST ACPI_PARSER IdStructureParser[] =3D { > {L"Length", 1, 1, L"%d", NULL, NULL, NULL, NULL}, > {L"Reserved", 2, 2, L"0x%x", NULL, NULL, NULL, NULL}, >=20 > - {L"VENDOR_ID", 4, 4, L"0x%x", NULL, NULL, NULL, NULL}, > + {L"VENDOR_ID", 4, 4, NULL, Dump4Chars, NULL, NULL, NULL}, > {L"LEVEL_1_ID", 8, 8, L"0x%x", NULL, NULL, NULL, NULL}, > {L"LEVEL_2_ID", 8, 16, L"0x%x", NULL, NULL, NULL, NULL}, > {L"MAJOR_REV", 2, 24, L"0x%x", NULL, NULL, NULL, NULL}, > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20 >=20 > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended rec= ipient, > please notify the sender immediately and do not disclose the contents to= any > other person, use it for any purpose, or store or copy the information i= n any > medium. Thank you. >=20 >=20