From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: zhichao.gao@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Thu, 16 May 2019 19:26:33 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 May 2019 19:26:32 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga006.jf.intel.com with ESMTP; 16 May 2019 19:26:32 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 16 May 2019 19:26:31 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 16 May 2019 19:26:31 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.129]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.126]) with mapi id 14.03.0415.000; Fri, 17 May 2019 10:26:29 +0800 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "sami.mujawar@arm.com" CC: "Carsey, Jaben" , "Ni, Ray" , Matteo Carlini , Stephanie Hughes-Fitt , nd , Krzysztof Koch Subject: Re: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation Thread-Topic: [edk2-devel] [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validation Thread-Index: AQHVBmxOnaLWZ8nSpUOOxpVdAUUJE6ZulFQg Date: Fri, 17 May 2019 02:26:27 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B7D3832@SHSMSX101.ccr.corp.intel.com> References: <20190131133008.14620-1-krzysztof.koch@arm.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhichao Gao > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Sami Mujawar > Sent: Thursday, May 9, 2019 9:37 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Matteo Carlini ; Stephanie Hughes-Fitt > ; nd ; Krzysztof Koch > > Subject: Re: [edk2-devel] [PATCH v1 1/1] > ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT cache attributes validati= on >=20 > Reviewed-by: Sami Mujawar >=20 > Regards, >=20 > Sami Mujawar >=20 > -----Original Message----- > From: Krzysztof Koch > Sent: 31 January 2019 01:30 PM > To: edk2-devel@lists.01.org > Cc: jaben.carsey@intel.com; ray.ni@intel.com; Matteo Carlini > ; Stephanie Hughes-Fitt Fitt@arm.com>; Sami Mujawar ; nd > > Subject: [PATCH v1 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Fix PPTT > cache attributes validation >=20 > Removed conditional pre-compiling for ARM CPUs because function > ValidateCacheAttributes(..) is based on ACPI PPTT specification. >=20 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Krzysztof Koch > Reported-by: Zhichao Gao > --- >=20 > The code can be found at: > https://github.com/KrzysztofKoch1/edk2/tree/woa_422_cache_valid_fix_v1 >=20 > Notes: > v1: > - removed conditional precompilation [Krzysztof] >=20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c > | 3 --- > 1 file changed, 3 deletions(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser. > c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser. > c > index > bc56fe9ea1dd9c1e98a6a568d3f9191263bedc90..b6b420890a3494869020ed8bc > c7b791fcf7d70f3 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser. > c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser. > c > @@ -86,11 +86,9 @@ ValidateCacheAttributes ( > IN VOID* Context > ) > { > -#if defined(MDE_CPU_ARM) || defined (MDE_CPU_AARCH64) > // Reference: Advanced Configuration and Power Interface (ACPI) > Specification > // Version 6.2 Errata A, September 2017 > // Table 5-153: Cache Type Structure > - > UINT8 Attributes; > Attributes =3D *(UINT8*)Ptr; >=20 > @@ -102,7 +100,6 @@ ValidateCacheAttributes ( > ); > return; > } > -#endif > } >=20 > /** > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20 >=20 >=20