From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
"Carsey, Jaben" <jaben.carsey@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency
Date: Tue, 21 May 2019 01:35:42 +0000 [thread overview]
Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B7D4235@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E44E09F@SHSMSX104.ccr.corp.intel.com>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
> -----Original Message-----
> From: Gao, Liming
> Sent: Tuesday, May 21, 2019 9:06 AM
> To: Carsey, Jaben <jaben.carsey@intel.com>; devel@edk2.groups.io
> Cc: Gao, Zhichao <zhichao.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: RE: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the
> package dependency
>
> Jaben:
> Yes. MdeModulePkg is still required.
>
> Thanks
> Liming
> > -----Original Message-----
> > From: Carsey, Jaben
> > Sent: Tuesday, May 21, 2019 12:35 AM
> > To: Gao, Liming <liming.gao@intel.com>; devel@edk2.groups.io
> > Cc: Gao, Zhichao <zhichao.gao@intel.com>; Ni, Ray <ray.ni@intel.com>
> > Subject: RE: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as
> > the package dependency
> >
> > Netlib class definition and instance are both moving?
> >
> > Are these modules using MdeModulePkg for a different lib or can we
> remove it?
> >
> > > -----Original Message-----
> > > From: Gao, Liming
> > > Sent: Monday, May 20, 2019 6:09 AM
> > > To: devel@edk2.groups.io
> > > Cc: Gao, Zhichao <zhichao.gao@intel.com>; Ni, Ray
> > > <ray.ni@intel.com>; Carsey, Jaben <jaben.carsey@intel.com>
> > > Subject: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the
> > > package dependency
> > > Importance: High
> > >
> > > NetLib will be moved from MdeModulePkg and NetworkPkg.
> > > So, the module that consumes NetLib need to depend on
> NetworkPkg.dec.
> > >
> > > Signed-off-by: Liming Gao <liming.gao@intel.com>
> > > Cc: Zhichao Gao <zhichao.gao@intel.com>
> > > Cc: Ray Ni <ray.ni@intel.com>
> > > Cc: Jaben Carsey <jaben.carsey@intel.com>
> > > ---
> > > ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
> | 3
> > > ++-
> > >
> > >
> ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand.
> > > inf | 3 ++-
> > > .../UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.in
> f
> > > | 3 ++-
> > > .../UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.in
> f
> > > | 3 ++-
> > > 4 files changed, 8 insertions(+), 4 deletions(-)
> > >
> > > diff --git
> a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
> > > b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
> > > index 9d57e59c63..bc13c89a97 100644
> > > --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
> > > +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf
> > > @@ -1,7 +1,7 @@
> > > ## @file
> > > # Provides Shell 'tftp' standalone application.
> > > #
> > > -# Copyright (c) 2010 - 2017, Intel Corporation. All rights
> > > reserved. <BR>
> > > +# Copyright (c) 2010 - 2019, Intel Corporation. All rights
> > > +reserved. <BR>
> > > # Copyright (c) 2015, ARM Ltd. All rights reserved.<BR> # #
> > > SPDX-License-Identifier: BSD-2-Clause-Patent @@ -31,6 +31,7 @@
> > > [Packages]
> > > MdePkg/MdePkg.dec
> > > ShellPkg/ShellPkg.dec
> > > MdeModulePkg/MdeModulePkg.dec
> > > + NetworkPkg/NetworkPkg.dec
> > >
> > > [LibraryClasses]
> > > MemoryAllocationLib
> > > diff --git
> > >
> a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> > > d.inf
> > >
> b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> > > d.inf
> > > index f23445102a..b0c8e8f84b 100644
> > > ---
> > >
> a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> > > d.inf
> > > +++
> > >
> b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman
> > > d.inf
> > > @@ -1,7 +1,7 @@
> > > ## @file
> > > # Provides Shell 'tftp' dynamic command.
> > > #
> > > -# Copyright (c) 2010 - 2017, Intel Corporation. All rights
> > > reserved. <BR>
> > > +# Copyright (c) 2010 - 2019, Intel Corporation. All rights
> > > +reserved. <BR>
> > > # Copyright (c) 2015, ARM Ltd. All rights reserved.<BR> # #
> > > SPDX-License-Identifier: BSD-2-Clause-Patent @@ -32,6 +32,7 @@
> > > [Packages]
> > > MdePkg/MdePkg.dec
> > > ShellPkg/ShellPkg.dec
> > > MdeModulePkg/MdeModulePkg.dec
> > > + NetworkPkg/NetworkPkg.dec
> > >
> > > [LibraryClasses]
> > > MemoryAllocationLib
> > > diff --git
> > >
> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> > > mandsLib.inf
> > >
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> > > mandsLib.inf
> > > index 8054dc6f51..1e6ce63e3e 100644
> > > ---
> > >
> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> > > mandsLib.inf
> > > +++
> > >
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> > > mandsLib.inf
> > > @@ -1,7 +1,7 @@
> > > ## @file
> > > # Provides shell network1 functions # -# Copyright (c) 2010 -
> > > 2018, Intel Corporation. All rights reserved. <BR>
> > > +# Copyright (c) 2010 - 2019, Intel Corporation. All rights
> > > +reserved. <BR>
> > > #
> > > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -29,6 +29,7
> > > @@ [Packages]
> > > MdePkg/MdePkg.dec
> > > ShellPkg/ShellPkg.dec
> > > MdeModulePkg/MdeModulePkg.dec
> > > + NetworkPkg/NetworkPkg.dec
> > >
> > > [LibraryClasses]
> > > MemoryAllocationLib
> > > diff --git
> > >
> a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> > > mandsLib.inf
> > >
> b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> > > mandsLib.inf
> > > index a9ca31a310..9ffcf85248 100644
> > > ---
> > >
> a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> > > mandsLib.inf
> > > +++
> > >
> b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> > > mandsLib.inf
> > > @@ -1,7 +1,7 @@
> > > ## @file
> > > # Provides shell network2 functions # -# Copyright (c) 2016, Intel
> > > Corporation. All rights reserved. <BR>
> > > +# Copyright (c) 2016 - 2019, Intel Corporation. All rights
> > > +reserved. <BR>
> > > #
> > > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -29,6 +29,7
> > > @@ [Packages]
> > > MdePkg/MdePkg.dec
> > > ShellPkg/ShellPkg.dec
> > > MdeModulePkg/MdeModulePkg.dec
> > > + NetworkPkg/NetworkPkg.dec
> > >
> > > [LibraryClasses]
> > > MemoryAllocationLib
> > > --
> > > 2.13.0.windows.1
next prev parent reply other threads:[~2019-05-21 1:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-20 13:09 [Patch 0/2] Add NetworkPkg/NetworkPkg.dec as the package dependency Liming Gao
2019-05-20 13:09 ` [Patch 1/2] ShellPkg: " Liming Gao
2019-05-20 16:35 ` Carsey, Jaben
2019-05-21 1:06 ` Liming Gao
2019-05-21 1:35 ` Gao, Zhichao [this message]
2019-05-20 13:09 ` [Patch 2/2] EmulatorPkg: " Liming Gao
[not found] ` <15A06622069DE087.2198@groups.io>
[not found] ` <4A89E2EF3DFEDB4C8BFDE51014F606A14E44E13E@SHSMSX104.ccr.corp.intel.com>
[not found] ` <734D49CCEBEEF84792F5B80ED585239D5C1540A6@SHSMSX104.ccr.corp.intel.com>
2019-05-22 2:05 ` FW: [edk2-devel] " Liming Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CE959C139B4C44DBEA1810E3AA6F9000B7D4235@SHSMSX101.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox