From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: zhichao.gao@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Mon, 20 May 2019 18:35:46 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 May 2019 18:35:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,493,1549958400"; d="scan'208";a="173818031" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga002.fm.intel.com with ESMTP; 20 May 2019 18:35:46 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 20 May 2019 18:35:46 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 20 May 2019 18:35:45 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.129]) by shsmsx102.ccr.corp.intel.com ([169.254.2.249]) with mapi id 14.03.0415.000; Tue, 21 May 2019 09:35:43 +0800 From: "Gao, Zhichao" To: "Gao, Liming" , "Carsey, Jaben" , "devel@edk2.groups.io" CC: "Ni, Ray" Subject: Re: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency Thread-Topic: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the package dependency Thread-Index: AQHVDw1AVQUS6E3JnEOFiqmheIA6EqZzr8IAgACO0wCAAI4P8A== Date: Tue, 21 May 2019 01:35:42 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B7D4235@SHSMSX101.ccr.corp.intel.com> References: <20190520130920.9464-1-liming.gao@intel.com> <20190520130920.9464-2-liming.gao@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E44E09F@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E44E09F@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhichao Gao > -----Original Message----- > From: Gao, Liming > Sent: Tuesday, May 21, 2019 9:06 AM > To: Carsey, Jaben ; devel@edk2.groups.io > Cc: Gao, Zhichao ; Ni, Ray > Subject: RE: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the > package dependency >=20 > Jaben: > Yes. MdeModulePkg is still required. >=20 > Thanks > Liming > > -----Original Message----- > > From: Carsey, Jaben > > Sent: Tuesday, May 21, 2019 12:35 AM > > To: Gao, Liming ; devel@edk2.groups.io > > Cc: Gao, Zhichao ; Ni, Ray > > Subject: RE: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as > > the package dependency > > > > Netlib class definition and instance are both moving? > > > > Are these modules using MdeModulePkg for a different lib or can we > remove it? > > > > > -----Original Message----- > > > From: Gao, Liming > > > Sent: Monday, May 20, 2019 6:09 AM > > > To: devel@edk2.groups.io > > > Cc: Gao, Zhichao ; Ni, Ray > > > ; Carsey, Jaben > > > Subject: [Patch 1/2] ShellPkg: Add NetworkPkg/NetworkPkg.dec as the > > > package dependency > > > Importance: High > > > > > > NetLib will be moved from MdeModulePkg and NetworkPkg. > > > So, the module that consumes NetLib need to depend on > NetworkPkg.dec. > > > > > > Signed-off-by: Liming Gao > > > Cc: Zhichao Gao > > > Cc: Ray Ni > > > Cc: Jaben Carsey > > > --- > > > ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf > | 3 > > > ++- > > > > > > > ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand. > > > inf | 3 ++- > > > .../UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.in > f > > > | 3 ++- > > > .../UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.in > f > > > | 3 ++- > > > 4 files changed, 8 insertions(+), 4 deletions(-) > > > > > > diff --git > a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf > > > b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf > > > index 9d57e59c63..bc13c89a97 100644 > > > --- a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf > > > +++ b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpApp.inf > > > @@ -1,7 +1,7 @@ > > > ## @file > > > # Provides Shell 'tftp' standalone application. > > > # > > > -# Copyright (c) 2010 - 2017, Intel Corporation. All rights > > > reserved.
> > > +# Copyright (c) 2010 - 2019, Intel Corporation. All rights > > > +reserved.
> > > # Copyright (c) 2015, ARM Ltd. All rights reserved.
# # > > > SPDX-License-Identifier: BSD-2-Clause-Patent @@ -31,6 +31,7 @@ > > > [Packages] > > > MdePkg/MdePkg.dec > > > ShellPkg/ShellPkg.dec > > > MdeModulePkg/MdeModulePkg.dec > > > + NetworkPkg/NetworkPkg.dec > > > > > > [LibraryClasses] > > > MemoryAllocationLib > > > diff --git > > > > a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman > > > d.inf > > > > b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman > > > d.inf > > > index f23445102a..b0c8e8f84b 100644 > > > --- > > > > a/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman > > > d.inf > > > +++ > > > > b/ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicComman > > > d.inf > > > @@ -1,7 +1,7 @@ > > > ## @file > > > # Provides Shell 'tftp' dynamic command. > > > # > > > -# Copyright (c) 2010 - 2017, Intel Corporation. All rights > > > reserved.
> > > +# Copyright (c) 2010 - 2019, Intel Corporation. All rights > > > +reserved.
> > > # Copyright (c) 2015, ARM Ltd. All rights reserved.
# # > > > SPDX-License-Identifier: BSD-2-Clause-Patent @@ -32,6 +32,7 @@ > > > [Packages] > > > MdePkg/MdePkg.dec > > > ShellPkg/ShellPkg.dec > > > MdeModulePkg/MdeModulePkg.dec > > > + NetworkPkg/NetworkPkg.dec > > > > > > [LibraryClasses] > > > MemoryAllocationLib > > > diff --git > > > > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > > > mandsLib.inf > > > > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > > > mandsLib.inf > > > index 8054dc6f51..1e6ce63e3e 100644 > > > --- > > > > a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > > > mandsLib.inf > > > +++ > > > > b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com > > > mandsLib.inf > > > @@ -1,7 +1,7 @@ > > > ## @file > > > # Provides shell network1 functions # -# Copyright (c) 2010 - > > > 2018, Intel Corporation. All rights reserved.
> > > +# Copyright (c) 2010 - 2019, Intel Corporation. All rights > > > +reserved.
> > > # > > > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -29,6 +29,7 > > > @@ [Packages] > > > MdePkg/MdePkg.dec > > > ShellPkg/ShellPkg.dec > > > MdeModulePkg/MdeModulePkg.dec > > > + NetworkPkg/NetworkPkg.dec > > > > > > [LibraryClasses] > > > MemoryAllocationLib > > > diff --git > > > > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > > > mandsLib.inf > > > > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > > > mandsLib.inf > > > index a9ca31a310..9ffcf85248 100644 > > > --- > > > > a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > > > mandsLib.inf > > > +++ > > > > b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com > > > mandsLib.inf > > > @@ -1,7 +1,7 @@ > > > ## @file > > > # Provides shell network2 functions # -# Copyright (c) 2016, Intel > > > Corporation. All rights reserved.
> > > +# Copyright (c) 2016 - 2019, Intel Corporation. All rights > > > +reserved.
> > > # > > > # SPDX-License-Identifier: BSD-2-Clause-Patent # @@ -29,6 +29,7 > > > @@ [Packages] > > > MdePkg/MdePkg.dec > > > ShellPkg/ShellPkg.dec > > > MdeModulePkg/MdeModulePkg.dec > > > + NetworkPkg/NetworkPkg.dec > > > > > > [LibraryClasses] > > > MemoryAllocationLib > > > -- > > > 2.13.0.windows.1