From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: zhichao.gao@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Tue, 21 May 2019 17:17:39 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 May 2019 17:17:38 -0700 X-ExtLoop1: 1 Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 21 May 2019 17:17:38 -0700 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 21 May 2019 17:17:38 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by fmsmsx123.amr.corp.intel.com (10.18.125.38) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 21 May 2019 17:17:38 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.129]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.33]) with mapi id 14.03.0415.000; Wed, 22 May 2019 08:17:35 +0800 From: "Gao, Zhichao" To: PierreGondois , "devel@edk2.groups.io" CC: "sami.mujawar@arm.com" , "Carsey, Jaben" , "Ni, Ray" , "Matteo.Carlini@arm.com" , "Stephanie.Hughes-Fitt@arm.com" , "nd@arm.com" Subject: Re: [PATCH V1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 Thread-Topic: [PATCH V1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 Thread-Index: AQHVDxC7TbGteKhilki0kDHXoXX346Z1N9GQ Date: Wed, 22 May 2019 00:17:35 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B7D46AC@SHSMSX101.ccr.corp.intel.com> References: <20190520133315.29284-1-pierre.gondois@arm.com> In-Reply-To: <20190520133315.29284-1-pierre.gondois@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The code change looks good for me.=20 But when I try to apply your patch to my local edk2 code, I would encounter= an error "error: corrupt patch at line 23". Making sure the patch that can apply to the edk2 trunk is important. Otherw= ise, the testers and maintainers may take time to write the whole change to= their own repo. Most time, it is impossible for them to write the code again because the p= atches are too many. Thanks, Zhichao > -----Original Message----- > From: PierreGondois [mailto:pierre.gondois@arm.com] > Sent: Monday, May 20, 2019 9:33 PM > To: devel@edk2.groups.io > Cc: sami.mujawar@arm.com; Carsey, Jaben ; Ni, > Ray ; Gao, Zhichao ; > Matteo.Carlini@arm.com; Stephanie.Hughes-Fitt@arm.com; nd@arm.com > Subject: [PATCH V1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 >=20 > From: Pierre Gondois >=20 > The ACPI 6.3 specification introduces support to describe the ARMv8.1 vir= tual > EL2 timers. This patch updates the GTDT parser of acpiview to decode the = EL2 > virtual timer fields. >=20 > Signed-off-by: Pierre Gondois > --- >=20 > The changes can be seen at: > https://github.com/PierreARM/edk2/tree/382_acpiview_gtdt_acpi6_3_upd > ate_v1 >=20 > Notes: > v1: > - GTDT updates for ACPI 6.3 [Pierre] >=20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c > | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > .c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > .c > index > 1b7e56486c8fb98a8fe063ae5fa25d86500a58a9..3b05ff3015d4a3af62dd9fab05 > 7c32369a456267 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > .c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtPars > +++ er.c > @@ -5,7 +5,7 @@ > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @par Reference(s): > - - ACPI 6.2 Specification - Errata A, September 2017 > + - ACPI 6.3 Specification - January 2019 > **/ >=20 > #include > @@ -77,7 +77,9 @@ STATIC CONST ACPI_PARSER GtdtParser[] =3D { > {L"Platform Timer Count", 4, 88, L"%d", NULL, > (VOID**)&GtdtPlatformTimerCount, NULL, NULL}, > {L"Platform Timer Offset", 4, 92, L"0x%x", NULL, > - (VOID**)&GtdtPlatformTimerOffset, NULL, NULL} > + (VOID**)&GtdtPlatformTimerOffset, NULL, NULL}, {L"Virtual EL2 Timer > + GSIV", 4, 96, L"0x%x", NULL, NULL, NULL, NULL}, {L"Virtual EL2 Timer > + Flags", 4, 100, L"0x%x", NULL, NULL, NULL, NULL} > }; >=20 > /** > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'