From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: zhichao.gao@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Wed, 29 May 2019 08:01:16 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 May 2019 08:01:16 -0700 X-ExtLoop1: 1 Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga008.jf.intel.com with ESMTP; 29 May 2019 08:01:15 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 29 May 2019 08:01:15 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 29 May 2019 08:01:15 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.10]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.137]) with mapi id 14.03.0415.000; Wed, 29 May 2019 23:01:13 +0800 From: "Gao, Zhichao" To: Leif Lindholm , "devel@edk2.groups.io" CC: Bret Barkelew , "Wang, Jian J" , "Wu, Hao A" , "Ni, Ray" , "Zeng, Star" , "Gao, Liming" , Sean Brogan , "Michael Turner" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize the CapsulePei Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize the CapsulePei Thread-Index: AQHVFbfnkfGMh9DmmU2l06xK0pI9fqaBbQuAgADEstA= Date: Wed, 29 May 2019 15:01:12 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B7DB95D@SHSMSX101.ccr.corp.intel.com> References: <20190529004555.45364-1-zhichao.gao@intel.com> <20190529111143.whfxiphgc3y6jap4@bivouac.eciton.net> In-Reply-To: <20190529111143.whfxiphgc3y6jap4@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I just update the date of copyright. And the code in Mu project didn't add = its own copyright. If it is required, I would add it for them. And I also make some minor changes on it. Thanks, Zhichao > -----Original Message----- > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > Sent: Wednesday, May 29, 2019 7:12 PM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Bret Barkelew ; Wang, Jian J > ; Wu, Hao A ; Ni, Ray > ; Zeng, Star ; Gao, Liming > ; Sean Brogan ; > Michael Turner > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize the > CapsulePei >=20 > On Wed, May 29, 2019 at 08:45:55AM +0800, Gao, Zhichao wrote: > > From: Bret Barkelew >=20 > If this code is from Microsoft... >=20 > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1853 > > > > Sperate the capsule check function from GetCapsuleDescriptors and name > > it to AreCapsulesStaged. > > Rename GetCapsuleDescriptors to GetScatterGatherHeadEntries. > > And optimize its to remove the duplicated code. > > > > Cc: Jian J Wang > > Cc: Hao A Wu > > Cc: Ray Ni > > Cc: Star Zeng > > Cc: Liming Gao > > Cc: Sean Brogan > > Cc: Michael Turner > > Cc: Bret Barkelew > > Signed-off-by: Zhichao gao > > --- > > MdeModulePkg/Universal/CapsulePei/Capsule.h | 3 +- > > .../Universal/CapsulePei/CapsulePei.inf | 3 +- > > .../Universal/CapsulePei/UefiCapsule.c | 357 ++++++++++-------- > > 3 files changed, 194 insertions(+), 169 deletions(-) > > > > diff --git a/MdeModulePkg/Universal/CapsulePei/Capsule.h > > b/MdeModulePkg/Universal/CapsulePei/Capsule.h > > index baf40423af..fc20dd8b92 100644 > > --- a/MdeModulePkg/Universal/CapsulePei/Capsule.h > > +++ b/MdeModulePkg/Universal/CapsulePei/Capsule.h > > @@ -1,6 +1,6 @@ > > /** @file > > > > -Copyright (c) 2006 - 2018, Intel Corporation. All rights > > reserved.
> > +Copyright (c) 2006 - 2019, Intel Corporation. All rights > > +reserved.
> > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > @@ -30,6 +30,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > #include #include > > #include > > +#include > > #include #include > > "Common/CommonHeader.h" > > > > diff --git a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > index 5d43df3075..9c88b3986f 100644 > > --- a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > +++ b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > @@ -6,7 +6,7 @@ > > # This external input must be validated carefully to avoid security > > issue like # buffer overflow, integer overflow. > > # > > -# Copyright (c) 2006 - 2018, Intel Corporation. All rights > > reserved.
> > +# Copyright (c) 2006 - 2019, Intel Corporation. All rights > > +reserved.
>=20 > ...why does Intel get the copyright? >=20 > / > Leif