From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: zhichao.gao@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Mon, 03 Jun 2019 01:18:06 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jun 2019 01:18:05 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga007.fm.intel.com with ESMTP; 03 Jun 2019 01:18:05 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 3 Jun 2019 01:18:05 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.408.0; Mon, 3 Jun 2019 01:18:05 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.10]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.188]) with mapi id 14.03.0415.000; Mon, 3 Jun 2019 16:18:03 +0800 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "leif.lindholm@linaro.org" CC: Bret Barkelew , "Wang, Jian J" , "Wu, Hao A" , "Ni, Ray" , "Zeng, Star" , "Gao, Liming" , Sean Brogan , "Michael Turner" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize the CapsulePei Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize the CapsulePei Thread-Index: AQHVFbfnkfGMh9DmmU2l06xK0pI9fqaBbQuAgADEstD//32mAIACx0HQgAB3zoCABKcIUA== Date: Mon, 3 Jun 2019 08:18:03 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B7E329A@SHSMSX101.ccr.corp.intel.com> References: <20190529004555.45364-1-zhichao.gao@intel.com> <20190529111143.whfxiphgc3y6jap4@bivouac.eciton.net> <3CE959C139B4C44DBEA1810E3AA6F9000B7DB95D@SHSMSX101.ccr.corp.intel.com> <20190529150910.bxrhcbu4j7pezuc2@bivouac.eciton.net> <3CE959C139B4C44DBEA1810E3AA6F9000B7E1D64@SHSMSX101.ccr.corp.intel.com> <20190531164339.bytd5w5sfiub75ic@bivouac.eciton.net> In-Reply-To: <20190531164339.bytd5w5sfiub75ic@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Saturday, June 1, 2019 12:44 AM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Bret Barkelew ; Wang, Jian J > ; Wu, Hao A ; Ni, Ray > ; Zeng, Star ; Gao, Liming > ; Sean Brogan ; > Michael Turner > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: Optimize the > CapsulePei >=20 > On Fri, May 31, 2019 at 01:46:14AM +0000, Gao, Zhichao wrote: > > > So what modifications were made to the code on the way from the > > > project Mu repository? That would be useful to mention in the commit > message. > > > > I would add this info blow commit message(not in commit message). It > > is helpful for review. But it may not be useful to add them in the > > commit message. > > On my opinion, the commit message should contain the summary and > impact of the changes. >=20 > You are importing a file from a different repository, produced by a diff= erent > company. As part of that import, you are claiming Intel copyright for 20= 19 for > the code provided in the patch. >=20 > This means that you are making a legal claim to the intellectual propert= y > provided by the patch on behalf of Intel. > Either: > - you have modified the code compared to the original, at which > point the commit mesage *must* reflect this - it is no longer the > contribution that the original message describes. > For an example, see how Laszlo reflected his changes to 94e0dd1afe53. Sorry. I can't understand the example. But maybe I got your point. I would= update the commit message with the MU link and mention what changes I made= . Then I would update the copyright of Intel. Is that the correct flow?=20 By the way, I have done that in V2 but the link and change info didn't inc= lude to the commit message. I would put them into the commit message in nex= t patch. Thanks, Zhichao > - the Intel copyright addition is a mistake (and must be dropped). >=20 > Regards, >=20 > Leif >=20 > > > > Thanks, > > Zhichao > > > > > > > > Regards, > > > > > > Leif > > > > > > > And I also make some minor changes on it. > > > > > > > > Thanks, > > > > Zhichao > > > > > > > > > -----Original Message----- > > > > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > > > > Sent: Wednesday, May 29, 2019 7:12 PM > > > > > To: devel@edk2.groups.io; Gao, Zhichao > > > > > Cc: Bret Barkelew ; Wang, Jian J > > > > > ; Wu, Hao A ; Ni, Ray > > > > > ; Zeng, Star ; Gao, > > > > > Liming ; Sean Brogan > > > > > ; Michael Turner > > > > > > > > > > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/CapsulePei: > > > > > Optimize the CapsulePei > > > > > > > > > > On Wed, May 29, 2019 at 08:45:55AM +0800, Gao, Zhichao wrote: > > > > > > From: Bret Barkelew > > > > > > > > > > If this code is from Microsoft... > > > > > > > > > > > > > > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1853 > > > > > > > > > > > > Sperate the capsule check function from GetCapsuleDescriptors > > > > > > and name it to AreCapsulesStaged. > > > > > > Rename GetCapsuleDescriptors to GetScatterGatherHeadEntries. > > > > > > And optimize its to remove the duplicated code. > > > > > > > > > > > > Cc: Jian J Wang > > > > > > Cc: Hao A Wu > > > > > > Cc: Ray Ni > > > > > > Cc: Star Zeng > > > > > > Cc: Liming Gao > > > > > > Cc: Sean Brogan > > > > > > Cc: Michael Turner > > > > > > Cc: Bret Barkelew > > > > > > Signed-off-by: Zhichao gao > > > > > > --- > > > > > > MdeModulePkg/Universal/CapsulePei/Capsule.h | 3 +- > > > > > > .../Universal/CapsulePei/CapsulePei.inf | 3 +- > > > > > > .../Universal/CapsulePei/UefiCapsule.c | 357 +++++++++= +------- > - > > > > > > 3 files changed, 194 insertions(+), 169 deletions(-) > > > > > > > > > > > > diff --git a/MdeModulePkg/Universal/CapsulePei/Capsule.h > > > > > > b/MdeModulePkg/Universal/CapsulePei/Capsule.h > > > > > > index baf40423af..fc20dd8b92 100644 > > > > > > --- a/MdeModulePkg/Universal/CapsulePei/Capsule.h > > > > > > +++ b/MdeModulePkg/Universal/CapsulePei/Capsule.h > > > > > > @@ -1,6 +1,6 @@ > > > > > > /** @file > > > > > > > > > > > > -Copyright (c) 2006 - 2018, Intel Corporation. All rights > > > > > > reserved.
> > > > > > +Copyright (c) 2006 - 2019, Intel Corporation. All rights > > > > > > +reserved.
> > > > > > > > > > > > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > > > > > > > @@ -30,6 +30,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > > > > > #include #include > > > > > > #include > > > > > > > > > > > > +#include > > > > > > #include #include > > > > > > "Common/CommonHeader.h" > > > > > > > > > > > > diff --git a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > > > > > b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > > > > > index 5d43df3075..9c88b3986f 100644 > > > > > > --- a/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > > > > > +++ b/MdeModulePkg/Universal/CapsulePei/CapsulePei.inf > > > > > > @@ -6,7 +6,7 @@ > > > > > > # This external input must be validated carefully to avoid > > > > > > security issue like # buffer overflow, integer overflow. > > > > > > # > > > > > > -# Copyright (c) 2006 - 2018, Intel Corporation. All rights > > > > > > reserved.
> > > > > > +# Copyright (c) 2006 - 2019, Intel Corporation. All rights > > > > > > +reserved.
> > > > > > > > > > ...why does Intel get the copyright? > > > > > > > > > > / > > > > > Leif > > > > > > > > > > > > > > > > > > >=20 >=20