From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: zhichao.gao@intel.com) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by groups.io with SMTP; Sun, 09 Jun 2019 20:09:11 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jun 2019 20:09:10 -0700 X-ExtLoop1: 1 Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 09 Jun 2019 20:09:10 -0700 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 9 Jun 2019 20:09:10 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.408.0; Sun, 9 Jun 2019 20:09:10 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.10]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.187]) with mapi id 14.03.0415.000; Mon, 10 Jun 2019 11:09:08 +0800 From: "Gao, Zhichao" To: PierreGondois , "devel@edk2.groups.io" CC: "Carsey, Jaben" , "Ni, Ray" , "sami.mujawar@arm.com" , "Matteo.Carlini@arm.com" , "Stephanie.Hughes-Fitt@arm.com" , "nd@arm.com" Subject: Re: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 Thread-Topic: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 Thread-Index: AQHVHGNoL01NZA/H0kq783hb531WNqaUOnrw Date: Mon, 10 Jun 2019 03:09:06 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B7E50F2@SHSMSX101.ccr.corp.intel.com> References: <20190606122836.8888-1-pierre.gondois@arm.com> In-Reply-To: <20190606122836.8888-1-pierre.gondois@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhichao Gao I would collect the R-B and send to the maintainer to push. Thanks, Zhichao > -----Original Message----- > From: PierreGondois [mailto:pierre.gondois@arm.com] > Sent: Thursday, June 6, 2019 8:29 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao ; sami.mujawar@arm.com; > Matteo.Carlini@arm.com; Stephanie.Hughes-Fitt@arm.com; > pierre.gondois@arm.com; nd@arm.com > Subject: [PATCH v1 1/1] ShellPkg/acpiview: GTDT updates for ACPI 6.3 >=20 > From: Pierre Gondois >=20 > The ACPI 6.3 specification introduces support to describe the ARMv8.1 vir= tual > EL2 timers. This patch updates the GTDT parser of acpiview to decode the = EL2 > virtual timer fields. >=20 > Signed-off-by: Pierre Gondois > --- >=20 > The changes can be seen at: > https://github.com/PierreARM/edk2/tree/382_acpiview_gtdt_acpi6_3_upd > ate_v1 >=20 > Notes: > v1: > - GTDT updates for ACPI 6.3 [Pierre] >=20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c > | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > .c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > .c > index > 1b7e56486c8fb98a8fe063ae5fa25d86500a58a9..3b05ff3015d4a3af62dd9fab05 > 7c32369a456267 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser > .c > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtPars > +++ er.c > @@ -5,7 +5,7 @@ > SPDX-License-Identifier: BSD-2-Clause-Patent >=20 > @par Reference(s): > - - ACPI 6.2 Specification - Errata A, September 2017 > + - ACPI 6.3 Specification - January 2019 > **/ >=20 > #include > @@ -77,7 +77,9 @@ STATIC CONST ACPI_PARSER GtdtParser[] =3D { > {L"Platform Timer Count", 4, 88, L"%d", NULL, > (VOID**)&GtdtPlatformTimerCount, NULL, NULL}, > {L"Platform Timer Offset", 4, 92, L"0x%x", NULL, > - (VOID**)&GtdtPlatformTimerOffset, NULL, NULL} > + (VOID**)&GtdtPlatformTimerOffset, NULL, NULL}, {L"Virtual EL2 Timer > + GSIV", 4, 96, L"0x%x", NULL, NULL, NULL, NULL}, {L"Virtual EL2 Timer > + Flags", 4, 100, L"0x%x", NULL, NULL, NULL, NULL} > }; >=20 > /** > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'