Re: [edk2-devel] [PATCH] CryptoPkg: Add lacking instances for build only

["Gao, Zhichao" <zhichao.gao@intel.com>]

I would fix the typo and replace the word 'lacking' with 'missing' in both BZ and the subject.

Thanks,
Zhichao

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Laszlo Ersek
> Sent: Wednesday, June 12, 2019 4:38 PM
> To: devel@edk2.groups.io; Gao, Zhichao <zhichao.gao@intel.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>; Wang, Jian J
> <jian.j.wang@intel.com>; Ye, Ting <ting.ye@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Sean Brogan <sean.brogan@microsoft.com>;
> Michael Turner <Michael.Turner@microsoft.com>
> Subject: Re: [edk2-devel] [PATCH] CryptoPkg: Add lacking instances for build
> only
> 
> On 06/12/19 04:39, Gao, Zhichao wrote:
> > From: Bret Barkelew <Bret.Barkelew@microsoft.com>
> >
> > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1900
> >
> > Add the lacking instance to [Componnets] of dsc file for build only.
> >
> > Cc: Jian Wang <jian.j.wang@intel.com>
> > Cc: Ting Ye <ting.ye@intel.com>
> > Cc: Liming Gao <liming.gao@intel.com>
> > Cc: Sean Brogan <sean.brogan@microsoft.com>
> > Cc: Michael Turner <Michael.Turner@microsoft.com>
> > Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> > Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> > ---
> >  CryptoPkg/CryptoPkg.dsc | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/CryptoPkg/CryptoPkg.dsc b/CryptoPkg/CryptoPkg.dsc index
> > 9dfa349f6d..c90e76c721 100644
> > --- a/CryptoPkg/CryptoPkg.dsc
> > +++ b/CryptoPkg/CryptoPkg.dsc
> > @@ -116,6 +116,7 @@
> >    CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> >    CryptoPkg/Library/TlsLib/TlsLib.inf
> >    CryptoPkg/Library/OpensslLib/OpensslLib.inf
> > +  CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf
> >
> >  [Components.IA32, Components.X64]
> >    CryptoPkg/Library/BaseCryptLib/SmmCryptLib.inf
> >
> 
> I'd like to suggest wording / spelling improvements:
> 
> - [Componnets] should be [Components]
> 
> - While I'm not a native English speaker, I believe "missing" would be more
> precise than "lacking". To me, "lacking" implies that the library instances in
> question have shortcomings. However, that's not what we mean here --
> those library instances are just fine, they are just missing from the DSC files.
> Hence my suggestion to say "missing" (in both the subject line and the
> commit message).
> 
> Thank you
> Laszlo
> 
>