From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: zhichao.gao@intel.com) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by groups.io with SMTP; Wed, 19 Jun 2019 19:42:57 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Jun 2019 19:42:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,395,1557212400"; d="scan'208";a="150797112" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga007.jf.intel.com with ESMTP; 19 Jun 2019 19:42:56 -0700 Received: from shsmsx153.ccr.corp.intel.com (10.239.6.53) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 19 Jun 2019 19:42:56 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.87]) by SHSMSX153.ccr.corp.intel.com ([169.254.12.76]) with mapi id 14.03.0439.000; Thu, 20 Jun 2019 10:42:54 +0800 From: "Gao, Zhichao" To: "Ni, Ray" , "devel@edk2.groups.io" CC: Bret Barkelew , "Wang, Jian J" , "Wu, Hao A" , "Zeng, Star" , "Gao, Liming" , Sean Brogan , Michael Turner Subject: Re: [PATCH V4 1/2] MdeModulePkg: Add a pcd to set the OS indications bit Thread-Topic: [PATCH V4 1/2] MdeModulePkg: Add a pcd to set the OS indications bit Thread-Index: AQHVJkyXCpyHCy1sFkyPvloVJnPalKaibJlQgAFoG6A= Date: Thu, 20 Jun 2019 02:42:53 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B7F655B@SHSMSX101.ccr.corp.intel.com> References: <20190619031023.10820-1-zhichao.gao@intel.com> <20190619031023.10820-2-zhichao.gao@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C1D9489@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C1D9489@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I am so sorry for my mistake. There are still ECC errors in the change of uni file. The additional string= should be STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPlatformRecoverySupport_PROMPT STR_gEfiMdeModulePkgTokenSpaceGuid_PcdPlatformRecoverySupport_HELP I would update the patch. Thanks, Zhichao > -----Original Message----- > From: Ni, Ray > Sent: Wednesday, June 19, 2019 1:06 PM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Bret Barkelew ; Wang, Jian J > ; Wu, Hao A ; Zeng, Star > ; Gao, Liming ; Sean Brogan > ; Michael Turner > > Subject: RE: [PATCH V4 1/2] MdeModulePkg: Add a pcd to set the OS > indications bit >=20 > Reviewed-by: Ray Ni >=20 > > -----Original Message----- > > From: Gao, Zhichao > > Sent: Wednesday, June 19, 2019 11:10 AM > > To: devel@edk2.groups.io > > Cc: Bret Barkelew ; Wang, Jian J > > ; Wu, Hao A ; Ni, Ray > > ; Zeng, Star ; Gao, Liming > > ; Sean Brogan ; > > Michael Turner > > Subject: [PATCH V4 1/2] MdeModulePkg: Add a pcd to set the OS > > indications bit > > > > From: Bret Barkelew > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1678 > > > > Add a pcd PcdPlatformRecoverySupport to conditionally set an OS > > indications bit and set the 'PlatformRecovery####' > > variable. This pcd would also control whether the BDS support platform > > recovery or not. > > Update the uni file for description of the pcd. > > > > Cc: Jian J Wang > > Cc: Hao Wu > > Cc: Ray Ni > > Cc: Star Zeng > > Cc: Liming Gao > > Cc: Sean Brogan > > Cc: Michael Turner > > Cc: Bret Barkelew > > Signed-off-by: Zhichao Gao > > --- > > MdeModulePkg/MdeModulePkg.dec | 6 ++++++ > > MdeModulePkg/MdeModulePkg.uni | 2 ++ > > 2 files changed, 8 insertions(+) > > > > diff --git a/MdeModulePkg/MdeModulePkg.dec > > b/MdeModulePkg/MdeModulePkg.dec index 0a9fcddecc..da2b85770c > > 100644 > > --- a/MdeModulePkg/MdeModulePkg.dec > > +++ b/MdeModulePkg/MdeModulePkg.dec > > @@ -1660,6 +1660,12 @@ > > # @Prompt Reset on memory type information change. > > > > > gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationC > h > > ange|TRUE|BOOLEAN|0x00010056 > > > > + ## Indicates if the BDS supports Platform Recovery.

> > + # TRUE - BDS supports Platform Recovery.
> > + # FALSE - BDS does not support Platform Recovery.
> > + # @Prompt Support Platform Recovery. > > + > > + > > > gEfiMdeModulePkgTokenSpaceGuid.PcdPlatformRecoverySupport|TRUE|B > O > > OLEAN > > + |0x00010078 > > + > > ## Specify the foreground color for Subtile text in HII Form > > Browser. The default value is EFI_BLUE. > > # Only following values defined in UEFI specification are valid:
> > # 0x00 (EFI_BLACK)
> > diff --git a/MdeModulePkg/MdeModulePkg.uni > > b/MdeModulePkg/MdeModulePkg.uni index ed8ac9eadc..a265452eba > > 100644 > > --- a/MdeModulePkg/MdeModulePkg.uni > > +++ b/MdeModulePkg/MdeModulePkg.uni > > @@ -441,6 +441,8 @@ > > > > #string > > > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdResetOnMemoryTypeInforma > ti > > onChange_PROMPT #language en-US "Reset on memory type information > > change" > > > > +#string > > > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdResetOnMemoryTypeInforma > ti > > onChange #language en-US "Indicate the system support platform > > recovery or not" > > + > > #string > > > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdResetOnMemoryTypeInforma > ti > > onChange_HELP #language en-US "Indicates if to reset system when > > memory type information changes.

\n" > > > > "TRUE - Resets system when memory type information changes.
\n" > > > > "FALSE - Does not reset system when memory type information > changes.
" > > -- > > 2.21.0.windows.1