From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.120, mailfrom: zhichao.gao@intel.com) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by groups.io with SMTP; Wed, 10 Jul 2019 19:36:52 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2019 19:36:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,476,1557212400"; d="scan'208";a="186280265" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga001.fm.intel.com with ESMTP; 10 Jul 2019 19:36:51 -0700 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jul 2019 19:36:51 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jul 2019 19:36:51 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.134]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.109]) with mapi id 14.03.0439.000; Thu, 11 Jul 2019 10:36:49 +0800 From: "Gao, Zhichao" To: "Dong, Eric" , "devel@edk2.groups.io" CC: Sean Brogan , "Ni, Ray" , Laszlo Ersek , "Gao, Liming" , Michael Turner , Bret Barkelew Subject: Re: [PATCH V2 2/4] UefiCpuPkg/CpuDxe: Implement Cpu2 protocol Thread-Topic: [PATCH V2 2/4] UefiCpuPkg/CpuDxe: Implement Cpu2 protocol Thread-Index: AQHVNjH1ykrnHmoJ7UO9MS04aglDtqbEsi1ggAAApwA= Date: Thu, 11 Jul 2019 02:36:48 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B807187@SHSMSX101.ccr.corp.intel.com> References: <20190709083956.13024-1-zhichao.gao@intel.com> <20190709083956.13024-3-zhichao.gao@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Dong, Eric > Sent: Thursday, July 11, 2019 10:22 AM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Sean Brogan ; Ni, Ray ; > Laszlo Ersek ; Gao, Liming ; > Michael Turner ; Bret Barkelew > > Subject: RE: [PATCH V2 2/4] UefiCpuPkg/CpuDxe: Implement Cpu2 protocol >=20 > Hi Zhizhao, >=20 > The new add files don't have copyright info, is it ok? I forgot add file comment for Ia32/EnableInterruptsAndSleep.c. Also lose th= e BSD+Patent License. I would add them in the future. For the copyright: The code is contributed by Microsoft at https://github.com/Microsoft/mu_bas= ecore/blob/release/201808/MdePkg/Library/BaseLib/X64/EnableInterrupts.nasm#= L48 I move the code from MdePkg to UefiCpuPkg to a single file. It is inappropr= iate to add both intel (not contributor) and Microsoft (they didn't add in = the above link). So I keep the copyright blank. I don't know whether it is ok without copyri= ght. Hi Liming, What's your opinion? Thanks, Zhichao >=20 > Thanks, > Eric >=20 > > -----Original Message----- > > From: Gao, Zhichao > > Sent: Tuesday, July 9, 2019 4:40 PM > > To: devel@edk2.groups.io > > Cc: Sean Brogan ; Dong, Eric > > ; Ni, Ray ; Laszlo Ersek > > ; Gao, Liming ; Michael > > Turner ; Bret Barkelew > > > > Subject: [PATCH V2 2/4] UefiCpuPkg/CpuDxe: Implement Cpu2 protocol > > > > From: Sean Brogan > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1400 > > > > Implement Cp2 protocol: it has one interface to enable the interrupt > > and put cpu to sleep and wait for an interrupt. > > > > Cc: Eric Dong > > Cc: Ray Ni > > Cc: Laszlo Ersek > > Cc: Liming Gao > > Cc: Sean Brogan > > Cc: Michael Turner > > Cc: Bret Barkelew > > Signed-off-by: Zhichao Gao > > --- > > UefiCpuPkg/CpuDxe/CpuDxe.c | 38 +++++++++++++++++++ > > UefiCpuPkg/CpuDxe/CpuDxe.h | 25 ++++++++++++ > > UefiCpuPkg/CpuDxe/CpuDxe.inf | 3 ++ > > .../CpuDxe/Ia32/EnableInterruptsAndSleep.c | 24 ++++++++++++ > > .../CpuDxe/X64/EnableInterruptsAndSleep.nasm | 31 +++++++++++++++ > > 5 files changed, 121 insertions(+) > > create mode 100644 > UefiCpuPkg/CpuDxe/Ia32/EnableInterruptsAndSleep.c > > create mode 100644 > > UefiCpuPkg/CpuDxe/X64/EnableInterruptsAndSleep.nasm > >