From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: zhichao.gao@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Thu, 18 Jul 2019 18:08:16 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Jul 2019 18:08:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,280,1559545200"; d="scan'208";a="162253991" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga008.jf.intel.com with ESMTP; 18 Jul 2019 18:08:15 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 18 Jul 2019 18:08:15 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 18 Jul 2019 18:08:15 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.134]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.240]) with mapi id 14.03.0439.000; Fri, 19 Jul 2019 09:08:12 +0800 From: "Gao, Zhichao" To: Krzysztof Koch , "devel@edk2.groups.io" CC: "Carsey, Jaben" , "Ni, Ray" , "Sami.Mujawar@arm.com" , "Matteo.Carlini@arm.com" , "nd@arm.com" Subject: Re: [PATCH v1 0/8] Remove redundant forward declarations in acpiview Thread-Topic: [PATCH v1 0/8] Remove redundant forward declarations in acpiview Thread-Index: AQHVPVBk9Ddj+kRx60i9KK2VvLdSqabRIWAg Date: Fri, 19 Jul 2019 01:08:12 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B808D7C@SHSMSX101.ccr.corp.intel.com> References: <20190718100502.24688-1-krzysztof.koch@arm.com> In-Reply-To: <20190718100502.24688-1-krzysztof.koch@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I am reviewing your previous patch "Add security checks in the Acpiview tab= le parsers". That takes times and I didn't finish reviewing them yet. You do a pretty good separation. That makes the review more easier. I would= give some comments on your previous one 10/10 patches to help your further= work after I finish reviewing them. This patch set is good for me.=20 Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: Krzysztof Koch [mailto:krzysztof.koch@arm.com] > Sent: Thursday, July 18, 2019 6:05 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao ; Sami.Mujawar@arm.com; > Matteo.Carlini@arm.com; nd@arm.com > Subject: [PATCH v1 0/8] Remove redundant forward declarations in acpiview >=20 > This patch series removes forward static function declarations in the acp= iview > table parsers. After repositioning blocks of code, these forward declarat= ions > are no longer needed and they increase the code size. >=20 > What is more, some of the existing ACPI table parsers don't have these > duplicate declarations, so this set of patches makes the code structure > consistent across all acpiview parsers. >=20 > Changes can be seen at: > https://github.com/KrzysztofKoch1/edk2/tree/612_remove_forward_decl_ > v1 >=20 > Krzysztof Koch (8): > ShellPkg: acpiview: RSDP: Remove redundant forward declarations > ShellPkg: acpiview: FADT: Remove redundant forward declarations > ShellPkg: acpiview: SPCR: Remove redundant forward declaration > ShellPkg: acpiview: SRAT: Remove redundant forward declarations > ShellPkg: acpiview: MADT: Remove redundant forward declarations > ShellPkg: acpiview: IORT: Remove redundant forward declarations > ShellPkg: acpiview: GTDT: Remove redundant forward declarations > ShellPkg: acpiview: DBG2: Remove redundant forward declarations >=20 >=20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c > | 62 +++------- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Fadt/FadtParser.c > | 113 ++++++------------- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c > | 91 ++++++--------- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | > 58 +++------- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser. > c | 118 ++++++++------------ > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c > | 116 +++++++------------ > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Spcr/SpcrParser.c | > 98 ++++++---------- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c | > 64 +++-------- > 8 files changed, 236 insertions(+), 484 deletions(-) >=20 > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20