From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: zhichao.gao@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Mon, 22 Jul 2019 02:11:36 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jul 2019 02:11:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,294,1559545200"; d="scan'208";a="171581950" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga003.jf.intel.com with ESMTP; 22 Jul 2019 02:11:32 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 22 Jul 2019 02:11:32 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 22 Jul 2019 02:11:30 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.134]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.232]) with mapi id 14.03.0439.000; Mon, 22 Jul 2019 17:11:28 +0800 From: "Gao, Zhichao" To: Krzysztof Koch , "devel@edk2.groups.io" CC: "Carsey, Jaben" , "Ni, Ray" , "Sami.Mujawar@arm.com" , "Matteo.Carlini@arm.com" , "nd@arm.com" Subject: Re: [PATCH v2 0/6] Acpiview table parsers code style enhancements and refactoring Thread-Topic: [PATCH v2 0/6] Acpiview table parsers code style enhancements and refactoring Thread-Index: AQHVQGIzPuYyl7akHU+FTdUWFOjD4abWV9bA Date: Mon, 22 Jul 2019 09:11:28 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B809587@SHSMSX101.ccr.corp.intel.com> References: <20190722075026.20244-1-krzysztof.koch@arm.com> In-Reply-To: <20190722075026.20244-1-krzysztof.koch@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Series: Reviewed-by: Zhichao Gao > -----Original Message----- > From: Krzysztof Koch [mailto:krzysztof.koch@arm.com] > Sent: Monday, July 22, 2019 3:50 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; G= ao, > Zhichao ; Sami.Mujawar@arm.com; > Matteo.Carlini@arm.com; nd@arm.com > Subject: [PATCH v2 0/6] Acpiview table parsers code style enhancements an= d > refactoring >=20 > This set of patches consists of a number of changes which make the code > structure consistent across the existing ACPI table parsers. These are al= l > refactoring changes which do not modify the existing functionality of the > acpiview UEFI shell tool. >=20 > Changes can be seen at: > https://github.com/KrzysztofKoch1/edk2/tree/612_acpiview_code_style_enhan > ce_v2 >=20 > Krzysztof Koch (6): > ShellPkg: acpiview: Allow passing buffer length to DumpGasStruct() > ShellPkg: acpiview: XSDT: Remove redundant ParseAcpi() call > ShellPkg: acpiview: RSDP: Make code consistent with other parsers > ShellPkg: acpiview: SRAT: Minor code style enhancements > ShellPkg: acpiview: MADT: Split structure length validation > ShellPkg: acpiview: IORT: Refactor PMCG node mapping count validation >=20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c |= 26 > +++++++++------- > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h |= 8 > +++-- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c | > 2 +- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParse= r.c > | 32 ++++++++++++++------ > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c | > 30 +++++++++++++----- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c | > 11 +++++-- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c | = 3 > +- ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.= c > | 18 +++-------- > 8 files changed, 82 insertions(+), 48 deletions(-) >=20 > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20