From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=fail (domain: intel.com, ip: , mailfrom: zhichao.gao@intel.com) Received: from mga06.intel.com (mga06.intel.com []) by groups.io with SMTP; Fri, 26 Jul 2019 00:46:50 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Jul 2019 00:46:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,310,1559545200"; d="scan'208";a="164497456" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga008.jf.intel.com with ESMTP; 26 Jul 2019 00:46:49 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 26 Jul 2019 00:46:49 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Fri, 26 Jul 2019 00:46:48 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.80]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.204]) with mapi id 14.03.0439.000; Fri, 26 Jul 2019 15:46:46 +0800 From: "Gao, Zhichao" To: "devel@edk2.groups.io" CC: "Carsey, Jaben" , "Ni, Ray" , "oleksiyy@ami.com" Subject: FW: [edk2-devel] [PATCH V2] ShellPkg/Pci.c: Update supported link speed to PCI4.0 Thread-Topic: [edk2-devel] [PATCH V2] ShellPkg/Pci.c: Update supported link speed to PCI4.0 Thread-Index: AQHVQFrbbuxL+mw8dUabGvYIJqf+f6bci2+g Date: Fri, 26 Jul 2019 07:46:45 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B817D52@SHSMSX101.ccr.corp.intel.com> References: <15B3A870CD7E1156.22671@groups.io> In-Reply-To: <15B3A870CD7E1156.22671@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ping. Please help to review it. Thanks, Zhichao -----Original Message----- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Gao,= Zhichao Sent: Monday, July 22, 2019 2:58 PM To: devel@edk2.groups.io Cc: Carsey, Jaben ; Ni, Ray ; Ol= eksiy Subject: [edk2-devel] [PATCH V2] ShellPkg/Pci.c: Update supported link spe= ed to PCI4.0 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1955 Refer PCI express base specification Reversion 4.0, Version 1.0, Table 7-3= 2, Supported Link Speeds Vector bit 3 indicate the speed 16 GT/s. Add it to= shell command 'pci ...'. Change the MaxLinkSpeed other values' result from 'Unknown' to 'Reserved'. Cc: Jaben Carsey Cc: Ray Ni Cc: Oleksiy Signed-off-by: Zhichao Gao --- V2: Update the copyright. And remind that this patch isn't update the code to match PCI 5.0. I didn'= t find edk repo update the related code to PCI 5.0. Please let me know if t= here is a requirement to update this code to PCI 5.0. ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c b/ShellPkg/= Library/UefiShellDebug1CommandsLib/Pci.c index ba9caa7743..b58ce3c2f0 100644 --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/Pci.c @@ -1,7 +1,7 @@ /** @file Main file for Pci shell Debug1 function. =20 - Copyright (c) 2005 - 2018, Intel Corporation. All rights reserved.
+ Copyright (c) 2005 - 2019, Intel Corporation. All rights=20 + reserved.
(C) Copyright 2013-2015 Hewlett-Packard Development Company, L.P.
(C) Copyright 2016 Hewlett Packard Enterprise Development LP
SPDX-License-Identifier: BSD-2-Clause-Patent @@ -4515,8 +4515,11 @@ Exp= lainPcieLinkCap ( case 3: MaxLinkSpeed =3D L"8.0 GT/s"; break; + case 4: + MaxLinkSpeed =3D L"16.0 GT/s"; + break; default: - MaxLinkSpeed =3D L"Unknown"; + MaxLinkSpeed =3D L"Reserved"; break; } ShellPrintEx (-1, -1, @@ -4672,6 +4675,9 @@ ExplainPcieLinkStatus ( case 3: CurLinkSpeed =3D L"8.0 GT/s"; break; + case 4: + CurLinkSpeed =3D L"16.0 GT/s"; + break; default: CurLinkSpeed =3D L"Reserved"; break; -- 2.21.0.windows.1