From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: zhichao.gao@intel.com) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by groups.io with SMTP; Sun, 28 Jul 2019 23:29:51 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 28 Jul 2019 23:29:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,321,1559545200"; d="scan'208";a="173132664" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga007.fm.intel.com with ESMTP; 28 Jul 2019 23:29:46 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 28 Jul 2019 23:29:46 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.80]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.62]) with mapi id 14.03.0439.000; Mon, 29 Jul 2019 14:29:43 +0800 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "'krzysztof.koch@arm.com'" CC: "Carsey, Jaben" , "Ni, Ray" , nd Subject: Re: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code style enhancements and refactoring Thread-Topic: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code style enhancements and refactoring Thread-Index: AQHVQGIvzXs3u+EzxkOyi2f9ZoJx6abWTBGAgAGsESCABSTPAIAD4esQ Date: Mon, 29 Jul 2019 06:29:43 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B81B94F@SHSMSX101.ccr.corp.intel.com> References: <15B3AB4E8413227A.7925@groups.io> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNmM0M2RlMDQtZDgwMi00YjVmLTlkM2EtM2RkZmNmOWZkMDMxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiYm9WdGVIN2VFSFAxdW05RE1sUkt6NFdcL0p4TmF2dlJ6VDlJa2tHWFBQN0o3U3lNMlBcL1dHbjhDMHdHOGQwbGU3In0= x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable The review work is done. Please wait for the maintainer to push the patch s= et. I would remind them if the pending time is too long. Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Krzysztof Koch > Sent: Saturday, July 27, 2019 12:33 AM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao ; nd > Subject: Re: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code sty= le > enhancements and refactoring >=20 > Hi, >=20 > Is there any way I can help get this patch merged? I have a couple of sm= all > patch sets ready to submit but they are pending on this series. >=20 > These small sets of patches are a result of me breaking down the "[PATCH= v1 > 00/11] Add security checks in the Acpiview table parsers" series into sm= aller > functional units as requested in the review comments. >=20 > Kind regards, >=20 > Krzysztof >=20 > -----Original Message----- > From: Sami Mujawar > Sent: Tuesday, July 23, 2019 10:57 > To: Krzysztof Koch ; devel@edk2.groups.io > Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; nd > > Subject: RE: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code sty= le > enhancements and refactoring >=20 > Reviewed-by: Sami Mujawar >=20 > -----Original Message----- > From: Krzysztof Koch > Sent: 22 July 2019 09:25 AM > To: devel@edk2.groups.io; Krzysztof Koch > Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; Sam= i > Mujawar ; nd > Subject: RE: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code sty= le > enhancements and refactoring >=20 > Hi Everyone, >=20 > Just to let you know, only "ShellPkg: acpiview: Allow passing buffer len= gth to > DumpGasStruct()" is changed compared to v1. I had a wrong understanding > of how to post revised patches to the upstream community. >=20 > Kind regards, >=20 > Krzysztof >=20 > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of > Krzysztof Koch via Groups.Io > Sent: Monday, July 22, 2019 8:50 > To: devel@edk2.groups.io > Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; Sam= i > Mujawar ; Matteo Carlini > ; nd > Subject: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code style > enhancements and refactoring >=20 > This set of patches consists of a number of changes which make the code > structure consistent across the existing ACPI table parsers. These are a= ll > refactoring changes which do not modify the existing functionality of th= e > acpiview UEFI shell tool. >=20 > Changes can be seen at: > https://github.com/KrzysztofKoch1/edk2/tree/612_acpiview_code_style_e > nhance_v2 >=20 > Krzysztof Koch (6): > ShellPkg: acpiview: Allow passing buffer length to DumpGasStruct() > ShellPkg: acpiview: XSDT: Remove redundant ParseAcpi() call > ShellPkg: acpiview: RSDP: Make code consistent with other parsers > ShellPkg: acpiview: SRAT: Minor code style enhancements > ShellPkg: acpiview: MADT: Split structure length validation > ShellPkg: acpiview: IORT: Refactor PMCG node mapping count validation >=20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c = | 26 > +++++++++------- > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h = | 8 > +++-- >=20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c > | 2 +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | > 32 ++++++++++++++------ > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser. > c | 30 +++++++++++++----- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c > | 11 +++++-- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c | > 3 +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c > | 18 +++-------- > 8 files changed, 82 insertions(+), 48 deletions(-) >=20 > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20 >=20 >=20 >=20 >=20 >=20 >=20