Re: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code style enhancements and refactoring

["Gao, Zhichao" <zhichao.gao@intel.com>]

Pushed at 58cc0ffe68e249ffcc73ee3d8e2120be27793f28..05f8e85fa7d83222310e471c9a43a6d2ab532c95

Thanks,
Zhichao

> -----Original Message-----
> From: Gao, Zhichao
> Sent: Monday, July 29, 2019 2:30 PM
> To: devel@edk2.groups.io; 'krzysztof.koch@arm.com'
> <krzysztof.koch@arm.com>
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>; nd
> <nd@arm.com>
> Subject: RE: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code style
> enhancements and refactoring
> 
> The review work is done. Please wait for the maintainer to push the patch
> set.
> I would remind them if the pending time is too long.
> 
> Thanks,
> Zhichao
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> > Krzysztof Koch
> > Sent: Saturday, July 27, 2019 12:33 AM
> > To: devel@edk2.groups.io
> > Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray
> > <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>; nd
> > <nd@arm.com>
> > Subject: Re: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code
> > style enhancements and refactoring
> >
> > Hi,
> >
> > Is there any way I can help get this patch merged? I have a couple of
> > small patch sets ready to submit but they are pending on this series.
> >
> > These small sets of patches are a result of me breaking down the
> > "[PATCH v1 00/11] Add security checks in the Acpiview table parsers"
> > series into smaller functional units as requested in the review comments.
> >
> > Kind regards,
> >
> > Krzysztof
> >
> > -----Original Message-----
> > From: Sami Mujawar <Sami.Mujawar@arm.com>
> > Sent: Tuesday, July 23, 2019 10:57
> > To: Krzysztof Koch <Krzysztof.Koch@arm.com>; devel@edk2.groups.io
> > Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com;
> > nd <nd@arm.com>
> > Subject: RE: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code
> > style enhancements and refactoring
> >
> > Reviewed-by: Sami Mujawar <sami.mujawar@arm.com>
> >
> > -----Original Message-----
> > From: Krzysztof Koch <Krzysztof.Koch@arm.com>
> > Sent: 22 July 2019 09:25 AM
> > To: devel@edk2.groups.io; Krzysztof Koch <Krzysztof.Koch@arm.com>
> > Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com;
> > Sami Mujawar <Sami.Mujawar@arm.com>; nd <nd@arm.com>
> > Subject: RE: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code
> > style enhancements and refactoring
> >
> > Hi Everyone,
> >
> > Just to let you know, only "ShellPkg: acpiview: Allow passing buffer
> > length to DumpGasStruct()" is changed compared to v1. I had a wrong
> > understanding of how to post revised patches to the upstream community.
> >
> > Kind regards,
> >
> > Krzysztof
> >
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of
> > Krzysztof Koch via Groups.Io
> > Sent: Monday, July 22, 2019 8:50
> > To: devel@edk2.groups.io
> > Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com;
> > Sami Mujawar <Sami.Mujawar@arm.com>; Matteo Carlini
> > <Matteo.Carlini@arm.com>; nd <nd@arm.com>
> > Subject: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code style
> > enhancements and refactoring
> >
> > This set of patches consists of a number of changes which make the
> > code structure consistent across the existing ACPI table parsers.
> > These are all refactoring changes which do not modify the existing
> > functionality of the acpiview UEFI shell tool.
> >
> > Changes can be seen at:
> >
> https://github.com/KrzysztofKoch1/edk2/tree/612_acpiview_code_style_e
> > nhance_v2
> >
> > Krzysztof Koch (6):
> >   ShellPkg: acpiview: Allow passing buffer length to DumpGasStruct()
> >   ShellPkg: acpiview: XSDT: Remove redundant ParseAcpi() call
> >   ShellPkg: acpiview: RSDP: Make code consistent with other parsers
> >   ShellPkg: acpiview: SRAT: Minor code style enhancements
> >   ShellPkg: acpiview: MADT: Split structure length validation
> >   ShellPkg: acpiview: IORT: Refactor PMCG node mapping count
> > validation
> >
> >  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c              | 26
> > +++++++++-------
> >  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h              |  8
> > +++--
> >
> >
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c
> > |  2 +-
> > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> > |
> > 32 ++++++++++++++------
> >
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.
> > c | 30 +++++++++++++-----
> >
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c
> > | 11 +++++--
> > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c
> > |
> > 3 +-
> >
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c
> > | 18 +++--------
> >  8 files changed, 82 insertions(+), 48 deletions(-)
> >
> > --
> > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
> >
> >
> >
> >
> >
> >
> >