From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: zhichao.gao@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Wed, 31 Jul 2019 19:32:23 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jul 2019 19:32:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,332,1559545200"; d="scan'208";a="371811310" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga005.fm.intel.com with ESMTP; 31 Jul 2019 19:32:23 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 31 Jul 2019 19:32:23 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 31 Jul 2019 19:32:23 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.80]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.65]) with mapi id 14.03.0439.000; Thu, 1 Aug 2019 10:32:20 +0800 From: "Gao, Zhichao" To: "'devel@edk2.groups.io'" , "'krzysztof.koch@arm.com'" CC: "Carsey, Jaben" , "Ni, Ray" , 'nd' Subject: Re: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code style enhancements and refactoring Thread-Topic: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code style enhancements and refactoring Thread-Index: AQHVQGIvzXs3u+EzxkOyi2f9ZoJx6abWTBGAgAGsESCABSTPAIAD4esQgAR8wpA= Date: Thu, 1 Aug 2019 02:32:20 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B81D608@SHSMSX101.ccr.corp.intel.com> References: <15B3AB4E8413227A.7925@groups.io> <3CE959C139B4C44DBEA1810E3AA6F9000B81B94F@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <3CE959C139B4C44DBEA1810E3AA6F9000B81B94F@SHSMSX101.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Pushed at 58cc0ffe68e249ffcc73ee3d8e2120be27793f28..05f8e85fa7d83222310e471= c9a43a6d2ab532c95 Thanks, Zhichao > -----Original Message----- > From: Gao, Zhichao > Sent: Monday, July 29, 2019 2:30 PM > To: devel@edk2.groups.io; 'krzysztof.koch@arm.com' > > Cc: Carsey, Jaben ; Ni, Ray ; = nd > > Subject: RE: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code sty= le > enhancements and refactoring >=20 > The review work is done. Please wait for the maintainer to push the patc= h > set. > I would remind them if the pending time is too long. >=20 > Thanks, > Zhichao >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Krzysztof Koch > > Sent: Saturday, July 27, 2019 12:33 AM > > To: devel@edk2.groups.io > > Cc: Carsey, Jaben ; Ni, Ray > > ; Gao, Zhichao ; nd > > > > Subject: Re: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code > > style enhancements and refactoring > > > > Hi, > > > > Is there any way I can help get this patch merged? I have a couple of > > small patch sets ready to submit but they are pending on this series. > > > > These small sets of patches are a result of me breaking down the > > "[PATCH v1 00/11] Add security checks in the Acpiview table parsers" > > series into smaller functional units as requested in the review commen= ts. > > > > Kind regards, > > > > Krzysztof > > > > -----Original Message----- > > From: Sami Mujawar > > Sent: Tuesday, July 23, 2019 10:57 > > To: Krzysztof Koch ; devel@edk2.groups.io > > Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; > > nd > > Subject: RE: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code > > style enhancements and refactoring > > > > Reviewed-by: Sami Mujawar > > > > -----Original Message----- > > From: Krzysztof Koch > > Sent: 22 July 2019 09:25 AM > > To: devel@edk2.groups.io; Krzysztof Koch > > Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; > > Sami Mujawar ; nd > > Subject: RE: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code > > style enhancements and refactoring > > > > Hi Everyone, > > > > Just to let you know, only "ShellPkg: acpiview: Allow passing buffer > > length to DumpGasStruct()" is changed compared to v1. I had a wrong > > understanding of how to post revised patches to the upstream community= . > > > > Kind regards, > > > > Krzysztof > > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of > > Krzysztof Koch via Groups.Io > > Sent: Monday, July 22, 2019 8:50 > > To: devel@edk2.groups.io > > Cc: jaben.carsey@intel.com; ray.ni@intel.com; zhichao.gao@intel.com; > > Sami Mujawar ; Matteo Carlini > > ; nd > > Subject: [edk2-devel] [PATCH v2 0/6] Acpiview table parsers code style > > enhancements and refactoring > > > > This set of patches consists of a number of changes which make the > > code structure consistent across the existing ACPI table parsers. > > These are all refactoring changes which do not modify the existing > > functionality of the acpiview UEFI shell tool. > > > > Changes can be seen at: > > > https://github.com/KrzysztofKoch1/edk2/tree/612_acpiview_code_style_e > > nhance_v2 > > > > Krzysztof Koch (6): > > ShellPkg: acpiview: Allow passing buffer length to DumpGasStruct() > > ShellPkg: acpiview: XSDT: Remove redundant ParseAcpi() call > > ShellPkg: acpiview: RSDP: Make code consistent with other parsers > > ShellPkg: acpiview: SRAT: Minor code style enhancements > > ShellPkg: acpiview: MADT: Split structure length validation > > ShellPkg: acpiview: IORT: Refactor PMCG node mapping count > > validation > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c = | 26 > > +++++++++------- > > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.h = | 8 > > +++-- > > > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c > > | 2 +- > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c > > | > > 32 ++++++++++++++------ > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser. > > c | 30 +++++++++++++----- > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Rsdp/RsdpParser.c > > | 11 +++++-- > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c > > | > > 3 +- > > > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Xsdt/XsdtParser.c > > | 18 +++-------- > > 8 files changed, 82 insertions(+), 48 deletions(-) > > > > -- > > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' > > > > > > > > > > > > > >=20