From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: zhichao.gao@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Thu, 01 Aug 2019 22:35:44 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Aug 2019 22:35:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,337,1559545200"; d="scan'208";a="372262334" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 01 Aug 2019 22:35:43 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 1 Aug 2019 22:35:43 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 1 Aug 2019 22:35:42 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.80]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.62]) with mapi id 14.03.0439.000; Fri, 2 Aug 2019 13:35:40 +0800 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "Kinney, Michael D" CC: "Carsey, Jaben" , "Ni, Ray" , Sami Mujawar Subject: Re: [edk2-devel] [Patch v2 2/2] ShellPkg: Add shell with all commands integrated Thread-Topic: [edk2-devel] [Patch v2 2/2] ShellPkg: Add shell with all commands integrated Thread-Index: AQHVSKuH/p0IMFTMNkqnk/su4FcyxabnVNow Date: Fri, 2 Aug 2019 05:35:40 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B81E444@SHSMSX101.ccr.corp.intel.com> References: <20190801205541.24792-1-michael.d.kinney@intel.com> <20190801205541.24792-3-michael.d.kinney@intel.com> In-Reply-To: <20190801205541.24792-3-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I used to use the shellpkg.dsc to build a shell.efi binary release. Full configuration of shell is fine. But the acpiview is under developing = and the shell spec doesn't contain 'acpiview' yet. Is it OK to add an additional cmd that the spec isn't mentioned? Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Michael D Kinney > Sent: Friday, August 2, 2019 4:56 AM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao ; Sami Mujawar > > Subject: [edk2-devel] [Patch v2 2/2] ShellPkg: Add shell with all comman= ds > integrated >=20 > https://bugzilla.tianocore.org/show_bug.cgi?id=3D1970 >=20 > Update ShellPkg DSC file to build an extra version of the Shell with all > commands integrated. This verifies that the shell can build in this max > configuration. >=20 > Cc: Jaben Carsey > Cc: Ray Ni > Cc: Zhichao Gao > Cc: Sami Mujawar > Signed-off-by: Michael D Kinney > --- > ShellPkg/ShellPkg.dsc | 22 +++++++++++++++++++++- > 1 file changed, 21 insertions(+), 1 deletion(-) >=20 > diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc index > 6a139b3b91..b2065dc028 100644 > --- a/ShellPkg/ShellPkg.dsc > +++ b/ShellPkg/ShellPkg.dsc > @@ -1,7 +1,7 @@ > ## @file > # Shell Package > # > -# Copyright (c) 2007 - 2018, Intel Corporation. All rights reserved. > +# Copyright (c) 2007 - 2019, Intel Corporation. All rights > +reserved.
> # Copyright (c) 2018, Arm Limited. All rights reserved.
# > # SPDX-License-Identifier: BSD-2-Clause-Patent > @@ -115,6 +115,26 @@ [Components] > !endif #$(NO_SHELL_PROFILES) > } >=20 > + # > + # Build a second version of the shell with all commands integrated # > + ShellPkg/Application/Shell/Shell.inf { > + > + FILE_GUID =3D EA4BB293-2D7F-4456-A681-1F22F42CD0BC > + > + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > + > + > NULL|ShellPkg/Library/UefiShellLevel2CommandsLib/UefiShellLevel2Comma > ndsLib.inf > + > NULL|ShellPkg/Library/UefiShellLevel1CommandsLib/UefiShellLevel1Comma > ndsLib.inf > + > NULL|ShellPkg/Library/UefiShellLevel3CommandsLib/UefiShellLevel3Comma > ndsLib.inf > + > NULL|ShellPkg/Library/UefiShellDriver1CommandsLib/UefiShellDriver1Com > mandsLib.inf > + > NULL|ShellPkg/Library/UefiShellInstall1CommandsLib/UefiShellInstall1Com > mandsLib.inf > + > NULL|ShellPkg/Library/UefiShellDebug1CommandsLib/UefiShellDebug1Com > mandsLib.inf > + > NULL|ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1 > CommandsLib.inf > + > NULL|ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2 > CommandsLib.inf > + > + > NULL|ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCo > m > + mandLib.inf > + } > + >=20 > ShellPkg/DynamicCommand/TftpDynamicCommand/TftpDynamicCommand. > inf { > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > -- > 2.21.0.windows.1 >=20 >=20 >=20