public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Carsey, Jaben" <jaben.carsey@intel.com>,
	"Ni, Ray" <ray.ni@intel.com>, Sami Mujawar <sami.mujawar@arm.com>
Subject: Re: [Patch v3 0/2] ShellPkg: Fix IA32 build failure in acpiview
Date: Mon, 5 Aug 2019 00:51:52 +0000	[thread overview]
Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B81E806@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20190803014655.11184-1-michael.d.kinney@intel.com>

Series: Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: Kinney, Michael D
> Sent: Saturday, August 3, 2019 9:47 AM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Gao, Zhichao <zhichao.gao@intel.com>; Sami Mujawar
> <sami.mujawar@arm.com>
> Subject: [Patch v3 0/2] ShellPkg: Fix IA32 build failure in acpiview
> 
> Use BaseLib MultuU64x64() to prevent intrinsics being added on IA32 builds.
> Add acpiview to a version of the Shell that is build with ShellPkg.dsc to catch
> this type of issue in ShellPkg builds.
> 
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> 
> Michael D Kinney (2):
>   ShellPkg/AcpiView: Fix IA32 link error
>   ShellPkg: Add shell with all commands integrated
> 
>  .../Parsers/Slit/SlitParser.c                 |  2 +-
>  ShellPkg/ShellPkg.dsc                         | 22 ++++++++++++++++++-
>  2 files changed, 22 insertions(+), 2 deletions(-)
> 
> --
> 2.21.0.windows.1


  parent reply	other threads:[~2019-08-05  0:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-03  1:46 [Patch v3 0/2] ShellPkg: Fix IA32 build failure in acpiview Michael D Kinney
2019-08-03  1:46 ` [Patch v3 1/2] ShellPkg/AcpiView: Fix IA32 link error Michael D Kinney
2019-08-03  1:46 ` [Patch v3 2/2] ShellPkg: Add shell with all commands integrated Michael D Kinney
2019-08-05  0:51 ` Gao, Zhichao [this message]
2019-08-05 10:47 ` [edk2-devel] [Patch v3 0/2] ShellPkg: Fix IA32 build failure in acpiview Sami Mujawar
2019-08-05 20:28   ` Carsey, Jaben

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CE959C139B4C44DBEA1810E3AA6F9000B81E806@SHSMSX101.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox