From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: zhichao.gao@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Tue, 06 Aug 2019 01:10:38 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 06 Aug 2019 01:10:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,352,1559545200"; d="scan'208";a="164908827" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga007.jf.intel.com with ESMTP; 06 Aug 2019 01:10:37 -0700 Received: from fmsmsx118.amr.corp.intel.com (10.18.116.18) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 6 Aug 2019 01:10:36 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx118.amr.corp.intel.com (10.18.116.18) with Microsoft SMTP Server (TLS) id 14.3.439.0; Tue, 6 Aug 2019 01:10:36 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.80]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.250]) with mapi id 14.03.0439.000; Tue, 6 Aug 2019 16:10:34 +0800 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "krzysztof.koch@arm.com" CC: "Carsey, Jaben" , "Ni, Ray" , "Sami.Mujawar@arm.com" , "Matteo.Carlini@arm.com" , "nd@arm.com" Subject: Re: [edk2-devel] [PATCH v1 0/6] Prevent buffer overruns in acpiview table parsers Thread-Topic: [edk2-devel] [PATCH v1 0/6] Prevent buffer overruns in acpiview table parsers Thread-Index: AQHVSEVuUPm3joknR0io/K+Hi04AJabtyztg Date: Tue, 6 Aug 2019 08:10:33 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B81FE8C@SHSMSX101.ccr.corp.intel.com> References: <20190801084407.48712-1-krzysztof.koch@arm.com> In-Reply-To: <20190801084407.48712-1-krzysztof.koch@arm.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable For 3 - 6: Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Krzysztof Koch > Sent: Thursday, August 1, 2019 4:44 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao ; Sami.Mujawar@arm.com; > Matteo.Carlini@arm.com; nd@arm.com > Subject: [edk2-devel] [PATCH v1 0/6] Prevent buffer overruns in acpiview > table parsers >=20 > This patch series makes minor modifications to a number of ACPI table > parsers with a goal to minimize the risk of buffer overruns. Some of the= se > overruns can be caused by invalid ACPI table data. >=20 > Changes can be seet at: > https://github.com/KrzysztofKoch1/edk2/tree/612_prevent_buffer_overru > ns_v1 >=20 > Krzysztof Koch (6): > ShellPkg: acpiview: DBG2: Prevent buffer overruns > ShellPkg: acpiview: GTDT: Prevent buffer overruns > ShellPkg: acpiview: IORT: Prevent buffer overruns > ShellPkg: acpiview: MADT: Prevent buffer overruns > ShellPkg: acpiview: PPTT: Prevent buffer overruns > ShellPkg: acpiview: SRAT: Prevent buffer overruns >=20 >=20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c > | 141 ++++++++++----- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Gtdt/GtdtParser.c > | 147 +++++++-------- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | > 191 +++++++++++--------- >=20 > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser. > c | 2 +- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Pptt/PpttParser.c > | 38 ++-- > ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Srat/SratParser.c | > 14 +- > 6 files changed, 314 insertions(+), 219 deletions(-) >=20 > -- > 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >=20 >=20 >=20 >=20