public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Zhang, Shenglei" <shenglei.zhang@intel.com>
Cc: "Carsey, Jaben" <jaben.carsey@intel.com>, "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [edk2-devel] [PATCH 2/3] ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF
Date: Thu, 8 Aug 2019 08:58:47 +0000	[thread overview]
Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B821073@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20190808062456.6116-3-shenglei.zhang@intel.com>

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Thursday, August 8, 2019 2:25 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Gao, Zhichao <zhichao.gao@intel.com>
> Subject: [edk2-devel] [PATCH 2/3] ShellPkg/UefiShellAcpiViewCommandLib:
> Add missing header files in INF
> 
> MadtParser.h and PpttParser.h are actually used but missing INF file, which
> will generate warning message when building this package.
> 
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  .../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.inf | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> andLib.inf
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> andLib.inf
> index e06e2082a197..1e2fa52b00a3 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> andLib.inf
> +++
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewComm
> +++ andLib.inf
> @@ -43,6 +43,8 @@ [Sources.common]
>    Parsers/Srat/SratParser.c
>    Parsers/Ssdt/SsdtParser.c
>    Parsers/Xsdt/XsdtParser.c
> +  Parsers/Madt/MadtParser.h
> +  Parsers/Pptt/PpttParser.h
> 
>  [Packages]
>    MdePkg/MdePkg.dec
> --
> 2.18.0.windows.1
> 
> 
> 


  reply	other threads:[~2019-08-08  8:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-08  6:24 [PATCH 0/3] Fix warning message issues Zhang, Shenglei
2019-08-08  6:24 ` [PATCH 1/3] MdeModulePkg: Add missing header files in INF files Zhang, Shenglei
2019-08-12  1:59   ` [edk2-devel] " Wu, Hao A
2019-08-12  5:19     ` Zhang, Shenglei
2019-08-08  6:24 ` [PATCH 2/3] ShellPkg/UefiShellAcpiViewCommandLib: Add missing header files in INF Zhang, Shenglei
2019-08-08  8:58   ` Gao, Zhichao [this message]
2019-08-08 14:51     ` [edk2-devel] " Carsey, Jaben
2019-08-08  6:24 ` [PATCH 3/3] IntelFsp2Pkg/FspSecCore: Add missing header file in INF file Zhang, Shenglei
2019-08-08  6:58   ` Chiu, Chasel
2019-08-08 14:56     ` Zeng, Star
2019-08-08 20:47       ` Nate DeSimone

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CE959C139B4C44DBEA1810E3AA6F9000B821073@SHSMSX101.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox