From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Carsey, Jaben" <jaben.carsey@intel.com>, "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove the variable "Index"
Date: Wed, 14 Aug 2019 03:36:45 +0000 [thread overview]
Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B8227D7@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20190814030716.10892-1-shenglei.zhang@intel.com>
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
Thanks,
Zhichao
> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Wednesday, August 14, 2019 11:07 AM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Gao, Zhichao <zhichao.gao@intel.com>
> Subject: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove the
> variable "Index"
>
> In IortParser.c ,the variable Index is set but not used in function
> DumpIortNodeNamedComponent. This will cause build failure when building
> ShellPkg with GCC.
>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> .../UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> index 8912d415a755..f1cdb9ac01d8 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortPars
> +++ er.c
> @@ -472,7 +472,6 @@ DumpIortNodeNamedComponent (
> )
> {
> UINT32 Offset;
> - UINT32 Index;
>
> Offset = ParseAcpi (
> TRUE,
> @@ -485,7 +484,6 @@ DumpIortNodeNamedComponent (
>
> // Estimate the Device Name length
> PrintFieldName (2, L"Device Object Name");
> - Index = 0;
>
> while ((*(Ptr + Offset) != 0) &&
> (Offset < Length)) {
> --
> 2.18.0.windows.1
next prev parent reply other threads:[~2019-08-14 3:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-14 3:07 [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove the variable "Index" Zhang, Shenglei
2019-08-14 3:36 ` Gao, Zhichao [this message]
2019-08-14 15:03 ` Carsey, Jaben
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CE959C139B4C44DBEA1810E3AA6F9000B8227D7@SHSMSX101.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox