From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.136, mailfrom: zhichao.gao@intel.com)
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by groups.io with SMTP; Tue, 13 Aug 2019 20:36:51 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga002.jf.intel.com ([10.7.209.21])
  by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Aug 2019 20:36:51 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,383,1559545200"; 
   d="scan'208";a="187987197"
Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201])
  by orsmga002.jf.intel.com with ESMTP; 13 Aug 2019 20:36:51 -0700
Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by
 FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Tue, 13 Aug 2019 20:36:50 -0700
Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by
 fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.1713.5; Tue, 13 Aug 2019 20:36:49 -0700
Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by
 fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1713.5
 via Frontend Transport; Tue, 13 Aug 2019 20:36:49 -0700
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.80]) by
 shsmsx102.ccr.corp.intel.com ([169.254.2.19]) with mapi id 14.03.0439.000;
 Wed, 14 Aug 2019 11:36:46 +0800
From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Carsey, Jaben" <jaben.carsey@intel.com>, "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove the variable "Index"
Thread-Topic: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove the
 variable "Index"
Thread-Index: AQHVUk1kdgGQYb+COE+pLWxpVHD64Kb5/UNg
Date: Wed, 14 Aug 2019 03:36:45 +0000
Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B8227D7@SHSMSX101.ccr.corp.intel.com>
References: <20190814030716.10892-1-shenglei.zhang@intel.com>
In-Reply-To: <20190814030716.10892-1-shenglei.zhang@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWVlODY0YzEtYzFjMi00YmQwLThmMTEtOTJjYWZiMTE5ZmUwIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieFZZUDB5WGlJVnVvYXhiQ1cyYlIyeWxycWJcL3lweTVaTmdaM1wvazdvVURvd24rYis2RzNIbGo1ellhaEJZVHZQIn0=
x-ctpclassification: CTP_NT
dlp-product: dlpe-windows
dlp-version: 11.2.0.6
dlp-reaction: no-action
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: zhichao.gao@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Wednesday, August 14, 2019 11:07 AM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Gao, Zhichao <zhichao.gao@intel.com>
> Subject: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove the
> variable "Index"
>=20
> In IortParser.c ,the variable Index is set but not used in function
> DumpIortNodeNamedComponent. This will cause build failure when building
> ShellPkg with GCC.
>=20
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
>  .../UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c       | 2 --
>  1 file changed, 2 deletions(-)
>=20
> diff --git
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> index 8912d415a755..f1cdb9ac01d8 100644
> ---
> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortPars
> +++ er.c
> @@ -472,7 +472,6 @@ DumpIortNodeNamedComponent (
>    )
>  {
>    UINT32 Offset;
> -  UINT32 Index;
>=20
>    Offset =3D ParseAcpi (
>               TRUE,
> @@ -485,7 +484,6 @@ DumpIortNodeNamedComponent (
>=20
>    // Estimate the Device Name length
>    PrintFieldName (2, L"Device Object Name");
> -  Index =3D 0;
>=20
>    while ((*(Ptr + Offset) !=3D 0) &&
>           (Offset < Length)) {
> --
> 2.18.0.windows.1