* [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove the variable "Index" @ 2019-08-14 3:07 Zhang, Shenglei 2019-08-14 3:36 ` Gao, Zhichao 0 siblings, 1 reply; 3+ messages in thread From: Zhang, Shenglei @ 2019-08-14 3:07 UTC (permalink / raw) To: devel; +Cc: Jaben Carsey, Ray Ni, Zhichao Gao In IortParser.c ,the variable Index is set but not used in function DumpIortNodeNamedComponent. This will cause build failure when building ShellPkg with GCC. Cc: Jaben Carsey <jaben.carsey@intel.com> Cc: Ray Ni <ray.ni@intel.com> Cc: Zhichao Gao <zhichao.gao@intel.com> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com> --- .../UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c index 8912d415a755..f1cdb9ac01d8 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c @@ -472,7 +472,6 @@ DumpIortNodeNamedComponent ( ) { UINT32 Offset; - UINT32 Index; Offset = ParseAcpi ( TRUE, @@ -485,7 +484,6 @@ DumpIortNodeNamedComponent ( // Estimate the Device Name length PrintFieldName (2, L"Device Object Name"); - Index = 0; while ((*(Ptr + Offset) != 0) && (Offset < Length)) { -- 2.18.0.windows.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove the variable "Index" 2019-08-14 3:07 [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove the variable "Index" Zhang, Shenglei @ 2019-08-14 3:36 ` Gao, Zhichao 2019-08-14 15:03 ` Carsey, Jaben 0 siblings, 1 reply; 3+ messages in thread From: Gao, Zhichao @ 2019-08-14 3:36 UTC (permalink / raw) To: Zhang, Shenglei, devel@edk2.groups.io; +Cc: Carsey, Jaben, Ni, Ray Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> Thanks, Zhichao > -----Original Message----- > From: Zhang, Shenglei > Sent: Wednesday, August 14, 2019 11:07 AM > To: devel@edk2.groups.io > Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>; > Gao, Zhichao <zhichao.gao@intel.com> > Subject: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove the > variable "Index" > > In IortParser.c ,the variable Index is set but not used in function > DumpIortNodeNamedComponent. This will cause build failure when building > ShellPkg with GCC. > > Cc: Jaben Carsey <jaben.carsey@intel.com> > Cc: Ray Ni <ray.ni@intel.com> > Cc: Zhichao Gao <zhichao.gao@intel.com> > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com> > --- > .../UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c > index 8912d415a755..f1cdb9ac01d8 100644 > --- > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortPars > +++ er.c > @@ -472,7 +472,6 @@ DumpIortNodeNamedComponent ( > ) > { > UINT32 Offset; > - UINT32 Index; > > Offset = ParseAcpi ( > TRUE, > @@ -485,7 +484,6 @@ DumpIortNodeNamedComponent ( > > // Estimate the Device Name length > PrintFieldName (2, L"Device Object Name"); > - Index = 0; > > while ((*(Ptr + Offset) != 0) && > (Offset < Length)) { > -- > 2.18.0.windows.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove the variable "Index" 2019-08-14 3:36 ` Gao, Zhichao @ 2019-08-14 15:03 ` Carsey, Jaben 0 siblings, 0 replies; 3+ messages in thread From: Carsey, Jaben @ 2019-08-14 15:03 UTC (permalink / raw) To: Gao, Zhichao, Zhang, Shenglei, devel@edk2.groups.io; +Cc: Ni, Ray Reviewed-by: Jaben Carsey <jaben.carsey@intel.com> Thanks -Jaben > -----Original Message----- > From: Gao, Zhichao > Sent: Tuesday, August 13, 2019 8:37 PM > To: Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io > Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com> > Subject: RE: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove > the variable "Index" > > Reviewed-by: Zhichao Gao <zhichao.gao@intel.com> > > Thanks, > Zhichao > > > -----Original Message----- > > From: Zhang, Shenglei > > Sent: Wednesday, August 14, 2019 11:07 AM > > To: devel@edk2.groups.io > > Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>; > > Gao, Zhichao <zhichao.gao@intel.com> > > Subject: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove > the > > variable "Index" > > > > In IortParser.c ,the variable Index is set but not used in function > > DumpIortNodeNamedComponent. This will cause build failure when > building > > ShellPkg with GCC. > > > > Cc: Jaben Carsey <jaben.carsey@intel.com> > > Cc: Ray Ni <ray.ni@intel.com> > > Cc: Zhichao Gao <zhichao.gao@intel.com> > > Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com> > > --- > > .../UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | 2 -- > > 1 file changed, 2 deletions(-) > > > > diff --git > > > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c > > > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c > > index 8912d415a755..f1cdb9ac01d8 100644 > > --- > > > a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c > > +++ > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortPars > > +++ er.c > > @@ -472,7 +472,6 @@ DumpIortNodeNamedComponent ( > > ) > > { > > UINT32 Offset; > > - UINT32 Index; > > > > Offset = ParseAcpi ( > > TRUE, > > @@ -485,7 +484,6 @@ DumpIortNodeNamedComponent ( > > > > // Estimate the Device Name length > > PrintFieldName (2, L"Device Object Name"); > > - Index = 0; > > > > while ((*(Ptr + Offset) != 0) && > > (Offset < Length)) { > > -- > > 2.18.0.windows.1 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-08-14 15:03 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-08-14 3:07 [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Remove the variable "Index" Zhang, Shenglei 2019-08-14 3:36 ` Gao, Zhichao 2019-08-14 15:03 ` Carsey, Jaben
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox