From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: zhichao.gao@intel.com) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by groups.io with SMTP; Thu, 15 Aug 2019 21:09:22 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Aug 2019 21:07:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,391,1559545200"; d="scan'208";a="328570148" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 15 Aug 2019 21:07:36 -0700 Received: from fmsmsx152.amr.corp.intel.com (10.18.125.5) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 15 Aug 2019 21:07:36 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX152.amr.corp.intel.com (10.18.125.5) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 15 Aug 2019 21:07:35 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.80]) by shsmsx102.ccr.corp.intel.com ([169.254.2.19]) with mapi id 14.03.0439.000; Fri, 16 Aug 2019 12:07:32 +0800 From: "Gao, Zhichao" To: "Zhang, Shenglei" , "devel@edk2.groups.io" CC: "Carsey, Jaben" , "Ni, Ray" Subject: Re: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left Thread-Topic: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left Thread-Index: AQHVUzxZRELd6CDq5U6A5k4ktD+UkKb9CcOw Date: Fri, 16 Aug 2019 04:07:32 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B823100@SHSMSX101.ccr.corp.intel.com> References: <20190815073747.16316-1-shenglei.zhang@intel.com> In-Reply-To: <20190815073747.16316-1-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNDEwNWI1OWUtNTJhMi00Mjk4LWJmOTEtODM0N2EzNTA4Y2Q2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoieGRtMnllNEtvMVRmWE5BZGVVajdvb1J5NWJIR0VqdGI3XC9Pa1VmOVJTYTNFZU9aZ0JmcGxEUzNtcjN5cnByVnQifQ== x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhichao Gao Thanks, Zhichao > -----Original Message----- > From: Zhang, Shenglei > Sent: Thursday, August 15, 2019 3:38 PM > To: devel@edk2.groups.io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao > Subject: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift > logical left >=20 > Replace the operation to shift logical left with the function LShiftU64, = which > has the same functionality. > The original code causes ShellPkg build failure with build target"-b NOOP= T". >=20 > Cc: Jaben Carsey > Cc: Ray Ni > Cc: Zhichao Gao > Signed-off-by: Shenglei Zhang > --- > ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > index 2d6ff80e299e..2e6d99145beb 100644 > --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > @@ -290,7 +290,7 @@ DumpUint64 ( >=20 > Val =3D *(UINT32*)(Ptr + sizeof (UINT32)); >=20 > - Val <<=3D 32; > + LShiftU64(Val,32); > Val |=3D (UINT64)*(UINT32*)Ptr; >=20 > Print (Format, Val); > -- > 2.18.0.windows.1