* [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Initialize local variables
@ 2019-08-15 5:41 Zhang, Shenglei
2019-08-16 4:07 ` [edk2-devel] " Gao, Zhichao
0 siblings, 1 reply; 2+ messages in thread
From: Zhang, Shenglei @ 2019-08-15 5:41 UTC (permalink / raw)
To: devel; +Cc: Jaben Carsey, Ray Ni, Zhichao Gao
At latest edk2 version, there is build failure when building ShellPkg
with VS2012x86, which results from uninitialized local variables.
Cc: Jaben Carsey <jaben.carsey@intel.com>
Cc: Ray Ni <ray.ni@intel.com>
Cc: Zhichao Gao <zhichao.gao@intel.com>
Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
---
.../Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 8 ++++++++
.../Library/UefiShellAcpiViewCommandLib/AcpiView.c | 10 ++++++++++
2 files changed, 18 insertions(+)
diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
index 2d6ff80e299e..94bafa22ef4c 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
@@ -121,6 +121,10 @@ VerifyChecksum (
UINT8 Checksum;
UINTN OriginalAttribute;
+ //
+ // set local variables to suppress incorrect compiler/analyzer warnings
+ //
+ OriginalAttribute = 0;
ByteCount = 0;
Checksum = 0;
@@ -472,6 +476,10 @@ ParseAcpi (
BOOLEAN HighLight;
UINTN OriginalAttribute;
+ //
+ // set local variables to suppress incorrect compiler/analyzer warnings
+ //
+ OriginalAttribute = 0;
Offset = 0;
// Increment the Indent
diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
index 9feb2df2078f..de0851dd5fba 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
@@ -211,6 +211,10 @@ ProcessTableReportOptions (
BOOLEAN Log;
BOOLEAN HighLight;
+ //
+ // set local variables to suppress incorrect compiler/analyzer warnings
+ //
+ OriginalAttribute = 0;
SignaturePtr = (UINT8*)(UINTN)&Signature;
Log = FALSE;
HighLight = GetColourHighlighting ();
@@ -347,6 +351,12 @@ AcpiView (
PARSE_ACPI_TABLE_PROC RsdpParserProc;
BOOLEAN Trace;
+ //
+ // set local variables to suppress incorrect compiler/analyzer warnings
+ //
+ EfiConfigurationTable = NULL;
+ OriginalAttribute = 0;
+
// Search the table for an entry that matches the ACPI Table Guid
FoundAcpiTable = FALSE;
for (Index = 0; Index < SystemTable->NumberOfTableEntries; Index++) {
--
2.18.0.windows.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [edk2-devel] [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Initialize local variables
2019-08-15 5:41 [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Initialize local variables Zhang, Shenglei
@ 2019-08-16 4:07 ` Gao, Zhichao
0 siblings, 0 replies; 2+ messages in thread
From: Gao, Zhichao @ 2019-08-16 4:07 UTC (permalink / raw)
To: devel@edk2.groups.io, Zhang, Shenglei; +Cc: Carsey, Jaben, Ni, Ray
Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
Thanks,
Zhichao
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Zhang, Shenglei
> Sent: Thursday, August 15, 2019 1:42 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Gao, Zhichao <zhichao.gao@intel.com>
> Subject: [edk2-devel] [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib:
> Initialize local variables
>
> At latest edk2 version, there is build failure when building ShellPkg with
> VS2012x86, which results from uninitialized local variables.
>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> .../Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 8 ++++++++
> .../Library/UefiShellAcpiViewCommandLib/AcpiView.c | 10 ++++++++++
> 2 files changed, 18 insertions(+)
>
> diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> index 2d6ff80e299e..94bafa22ef4c 100644
> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> @@ -121,6 +121,10 @@ VerifyChecksum (
> UINT8 Checksum;
> UINTN OriginalAttribute;
>
> + //
> + // set local variables to suppress incorrect compiler/analyzer
> + warnings // OriginalAttribute = 0;
> ByteCount = 0;
> Checksum = 0;
>
> @@ -472,6 +476,10 @@ ParseAcpi (
> BOOLEAN HighLight;
> UINTN OriginalAttribute;
>
> + //
> + // set local variables to suppress incorrect compiler/analyzer
> + warnings // OriginalAttribute = 0;
> Offset = 0;
>
> // Increment the Indent
> diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
> index 9feb2df2078f..de0851dd5fba 100644
> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
> @@ -211,6 +211,10 @@ ProcessTableReportOptions (
> BOOLEAN Log;
> BOOLEAN HighLight;
>
> + //
> + // set local variables to suppress incorrect compiler/analyzer
> + warnings // OriginalAttribute = 0;
> SignaturePtr = (UINT8*)(UINTN)&Signature;
> Log = FALSE;
> HighLight = GetColourHighlighting (); @@ -347,6 +351,12 @@ AcpiView (
> PARSE_ACPI_TABLE_PROC RsdpParserProc;
> BOOLEAN Trace;
>
> + //
> + // set local variables to suppress incorrect compiler/analyzer
> + warnings // EfiConfigurationTable = NULL; OriginalAttribute = 0;
> +
> // Search the table for an entry that matches the ACPI Table Guid
> FoundAcpiTable = FALSE;
> for (Index = 0; Index < SystemTable->NumberOfTableEntries; Index++) {
> --
> 2.18.0.windows.1
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-08-16 4:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-15 5:41 [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Initialize local variables Zhang, Shenglei
2019-08-16 4:07 ` [edk2-devel] " Gao, Zhichao
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox