Re: [edk2-devel] [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left

["Gao, Zhichao" <zhichao.gao@intel.com>]

Thanks for correcting my mistake.

Shenglei,
  Please fix it.

Thanks,
Zhichao

> -----Original Message-----
> From: Gao, Liming
> Sent: Friday, August 16, 2019 2:00 PM
> To: devel@edk2.groups.io; Gao, Zhichao <zhichao.gao@intel.com>; Zhang,
> Shenglei <shenglei.zhang@intel.com>
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>
> Subject: RE: [edk2-devel] [PATCH 1/1]
> ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left
> 
> Shenglei:
> 
> >-----Original Message-----
> >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> >Gao, Zhichao
> >Sent: Friday, August 16, 2019 12:08 PM
> >To: Zhang, Shenglei <shenglei.zhang@intel.com>; devel@edk2.groups.io
> >Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>
> >Subject: Re: [edk2-devel] [PATCH 1/1]
> >ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left
> >
> >Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>
> >
> >Thanks,
> >Zhichao
> >
> >> -----Original Message-----
> >> From: Zhang, Shenglei
> >> Sent: Thursday, August 15, 2019 3:38 PM
> >> To: devel@edk2.groups.io
> >> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray
> >> <ray.ni@intel.com>; Gao, Zhichao <zhichao.gao@intel.com>
> >> Subject: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace
> >> shift logical left
> >>
> >> Replace the operation to shift logical left with the function
> >> LShiftU64, which has the same functionality.
> >> The original code causes ShellPkg build failure with build target"-b
> NOOPT".
> >>
> >> Cc: Jaben Carsey <jaben.carsey@intel.com>
> >> Cc: Ray Ni <ray.ni@intel.com>
> >> Cc: Zhichao Gao <zhichao.gao@intel.com>
> >> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> >> ---
> >>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git
> >> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> >> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> >> index 2d6ff80e299e..2e6d99145beb 100644
> >> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> >> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> >> @@ -290,7 +290,7 @@ DumpUint64 (
> >>
> >>    Val = *(UINT32*)(Ptr + sizeof (UINT32));
> >>
> >> -  Val <<= 32;
> >> +  LShiftU64(Val,32);
> 
> The logic should be:
> 
> Val = LShiftU64(Val,32);
> 
> Thanks
> Liming
> 
> >>    Val |= (UINT64)*(UINT32*)Ptr;
> >>
> >>    Print (Format, Val);
> >> --
> >> 2.18.0.windows.1
> >
> >
> >