From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: zhichao.gao@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Thu, 15 Aug 2019 23:10:34 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Aug 2019 23:10:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,391,1559545200"; d="scan'208";a="376617987" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 15 Aug 2019 23:10:33 -0700 Received: from fmsmsx155.amr.corp.intel.com (10.18.116.71) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 15 Aug 2019 23:10:33 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by FMSMSX155.amr.corp.intel.com (10.18.116.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 15 Aug 2019 23:10:33 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.80]) by shsmsx102.ccr.corp.intel.com ([169.254.2.19]) with mapi id 14.03.0439.000; Fri, 16 Aug 2019 14:10:30 +0800 From: "Gao, Zhichao" To: "Gao, Liming" , "devel@edk2.groups.io" , "Zhang, Shenglei" CC: "Carsey, Jaben" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left Thread-Topic: [edk2-devel] [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left Thread-Index: AQHVUzxZRELd6CDq5U6A5k4ktD+UkKb9CcOw//+5dgCAAIgBcA== Date: Fri, 16 Aug 2019 06:10:29 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B823189@SHSMSX101.ccr.corp.intel.com> References: <20190815073747.16316-1-shenglei.zhang@intel.com> <3CE959C139B4C44DBEA1810E3AA6F9000B823100@SHSMSX101.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D2454@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4D2454@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for correcting my mistake. Shenglei, Please fix it. Thanks, Zhichao > -----Original Message----- > From: Gao, Liming > Sent: Friday, August 16, 2019 2:00 PM > To: devel@edk2.groups.io; Gao, Zhichao ; Zhang, > Shenglei > Cc: Carsey, Jaben ; Ni, Ray > Subject: RE: [edk2-devel] [PATCH 1/1] > ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left >=20 > Shenglei: >=20 > >-----Original Message----- > >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > >Gao, Zhichao > >Sent: Friday, August 16, 2019 12:08 PM > >To: Zhang, Shenglei ; devel@edk2.groups.io > >Cc: Carsey, Jaben ; Ni, Ray > >Subject: Re: [edk2-devel] [PATCH 1/1] > >ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left > > > >Reviewed-by: Zhichao Gao > > > >Thanks, > >Zhichao > > > >> -----Original Message----- > >> From: Zhang, Shenglei > >> Sent: Thursday, August 15, 2019 3:38 PM > >> To: devel@edk2.groups.io > >> Cc: Carsey, Jaben ; Ni, Ray > >> ; Gao, Zhichao > >> Subject: [PATCH 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace > >> shift logical left > >> > >> Replace the operation to shift logical left with the function > >> LShiftU64, which has the same functionality. > >> The original code causes ShellPkg build failure with build target"-b > NOOPT". > >> > >> Cc: Jaben Carsey > >> Cc: Ray Ni > >> Cc: Zhichao Gao > >> Signed-off-by: Shenglei Zhang > >> --- > >> ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git > >> a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > >> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > >> index 2d6ff80e299e..2e6d99145beb 100644 > >> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > >> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c > >> @@ -290,7 +290,7 @@ DumpUint64 ( > >> > >> Val =3D *(UINT32*)(Ptr + sizeof (UINT32)); > >> > >> - Val <<=3D 32; > >> + LShiftU64(Val,32); >=20 > The logic should be: >=20 > Val =3D LShiftU64(Val,32); >=20 > Thanks > Liming >=20 > >> Val |=3D (UINT64)*(UINT32*)Ptr; > >> > >> Print (Format, Val); > >> -- > >> 2.18.0.windows.1 > > > > > >