From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: zhichao.gao@intel.com)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by groups.io with SMTP; Thu, 15 Aug 2019 23:19:13 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga004.jf.intel.com ([10.7.209.38])
  by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Aug 2019 23:19:12 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.64,391,1559545200"; 
   d="scan'208";a="328595324"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
  by orsmga004.jf.intel.com with ESMTP; 15 Aug 2019 23:19:12 -0700
Received: from fmsmsx125.amr.corp.intel.com (10.18.125.40) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Thu, 15 Aug 2019 23:19:12 -0700
Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by
 FMSMSX125.amr.corp.intel.com (10.18.125.40) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Thu, 15 Aug 2019 23:19:11 -0700
Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.80]) by
 shsmsx102.ccr.corp.intel.com ([169.254.2.19]) with mapi id 14.03.0439.000;
 Fri, 16 Aug 2019 14:19:09 +0800
From: "Gao, Zhichao" <zhichao.gao@intel.com>
To: "Zhang, Shenglei" <shenglei.zhang@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Carsey, Jaben" <jaben.carsey@intel.com>, "Ni, Ray" <ray.ni@intel.com>
Subject: Re: [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace shift logical left
Thread-Topic: [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace
 shift logical left
Thread-Index: AQHVU/lVmhP+ijzs0E6EQvehkLI+g6b9TP0Q
Date: Fri, 16 Aug 2019 06:19:09 +0000
Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B8231AC@SHSMSX101.ccr.corp.intel.com>
References: <20190816061034.23528-1-shenglei.zhang@intel.com>
In-Reply-To: <20190816061034.23528-1-shenglei.zhang@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: zhichao.gao@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Zhichao Gao <zhichao.gao@intel.com>

Thanks,
Zhichao

> -----Original Message-----
> From: Zhang, Shenglei
> Sent: Friday, August 16, 2019 2:11 PM
> To: devel@edk2.groups.io
> Cc: Carsey, Jaben <jaben.carsey@intel.com>; Ni, Ray <ray.ni@intel.com>;
> Gao, Zhichao <zhichao.gao@intel.com>
> Subject: [PATCH v2 1/1] ShellPkg/UefiShellAcpiViewCommandLib: Replace
> shift logical left
>=20
> Replace the operation to shift logical left with the function LShiftU64, =
which
> has the same functionality.
> The original code causes ShellPkg build failure with build target"-b NOOP=
T".
>=20
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Zhichao Gao <zhichao.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> v2: There is no return target from LShiftU64 in v1 patch.
>     So update code to "Val =3D LShiftU64(Val,32)".
>=20
>  ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> index 94bafa22ef4c..a569c3c55406 100644
> --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
> @@ -294,7 +294,7 @@ DumpUint64 (
>=20
>    Val =3D *(UINT32*)(Ptr + sizeof (UINT32));
>=20
> -  Val <<=3D 32;
> +  Val =3D LShiftU64(Val,32);
>    Val |=3D (UINT64)*(UINT32*)Ptr;
>=20
>    Print (Format, Val);
> --
> 2.18.0.windows.1