From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: zhichao.gao@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Wed, 04 Sep 2019 19:20:24 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 04 Sep 2019 19:20:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,469,1559545200"; d="scan'208";a="173781133" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga007.jf.intel.com with ESMTP; 04 Sep 2019 19:20:23 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 4 Sep 2019 19:20:23 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.92]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.23]) with mapi id 14.03.0439.000; Thu, 5 Sep 2019 10:20:21 +0800 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "leif.lindholm@linaro.org" , Ard Biesheuvel CC: "Carsey, Jaben" , "Ni, Ray" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH] ShellPkg/ShellPkg.dsc AARCH64: enable stack protector Thread-Topic: [edk2-devel] [PATCH] ShellPkg/ShellPkg.dsc AARCH64: enable stack protector Thread-Index: AQHVYz6pWbaPbqwLI0SRu3GJ0q9eQKcbMYYAgAELI2A= Date: Thu, 5 Sep 2019 02:20:20 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B836669@SHSMSX101.ccr.corp.intel.com> References: <20190904163434.16836-1-ard.biesheuvel@linaro.org> <20190904163738.GN29255@bivouac.eciton.net> In-Reply-To: <20190904163738.GN29255@bivouac.eciton.net> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Acked-by: Zhichao Gao > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Thursday, September 5, 2019 12:38 AM > To: Ard Biesheuvel > Cc: devel@edk2.groups.io; Carsey, Jaben ; Ni, Ra= y > ; Gao, Zhichao ; Gao, Liming > > Subject: Re: [edk2-devel] [PATCH] ShellPkg/ShellPkg.dsc AARCH64: enable > stack protector >=20 > On Wed, Sep 04, 2019 at 09:34:34AM -0700, Ard Biesheuvel wrote: > > Incorporate the stack protector library into the AARCH64 build of the > > Shell binaries as a NULL library resolution, to avoid build errors > > when the compiler injects stack integrity checks. > > > > Signed-off-by: Ard Biesheuvel >=20 > Surprised we hadn't triggered this earlier. > Reviewed-by: Leif Lindholm >=20 >=20 > > --- > > ShellPkg/ShellPkg.dsc | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc index > > b2065dc028d8..91493400cab7 100644 > > --- a/ShellPkg/ShellPkg.dsc > > +++ b/ShellPkg/ShellPkg.dsc > > @@ -58,7 +58,7 @@ > > DxeServicesLib|MdePkg/Library/DxeServicesLib/DxeServicesLib.inf > > > > > ReportStatusCodeLib|MdePkg/Library/BaseReportStatusCodeLibNull/BaseR > ep > > ortStatusCodeLibNull.inf > > > > -[LibraryClasses.ARM] > > +[LibraryClasses.ARM,LibraryClasses.AARCH64] > > # > > # It is not possible to prevent the ARM compiler for generic intrin= sic > functions. > > # This library provides the instrinsic functions generate by a give= n > compiler. > > @@ -69,9 +69,6 @@ > > # Add support for GCC stack protector > > NULL|MdePkg/Library/BaseStackCheckLib/BaseStackCheckLib.inf > > > > -[LibraryClasses.AARCH64] > > - NULL|ArmPkg/Library/CompilerIntrinsicsLib/CompilerIntrinsicsLib.inf > > - > > [PcdsFixedAtBuild] > > gEfiMdePkgTokenSpaceGuid.PcdDebugPropertyMask|0xFF > > gEfiMdePkgTokenSpaceGuid.PcdUefiLibMaxPrintBufferSize|16000 > > -- > > 2.17.1 > > >=20 >=20