From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: zhichao.gao@intel.com) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by groups.io with SMTP; Sun, 15 Sep 2019 17:33:53 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Sep 2019 17:33:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,492,1559545200"; d="scan'208";a="176895553" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga007.jf.intel.com with ESMTP; 15 Sep 2019 17:33:52 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 15 Sep 2019 17:33:52 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.92]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.89]) with mapi id 14.03.0439.000; Mon, 16 Sep 2019 08:32:47 +0800 From: "Gao, Zhichao" To: "Wu, Hao A" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Ni, Ray" Subject: Re: [PATCH 1/3] MdeModulePkg: Entend the support keyboard type of Terminal console Thread-Topic: [PATCH 1/3] MdeModulePkg: Entend the support keyboard type of Terminal console Thread-Index: AQHVaQXzYm9M/iJZ6keCi6HpFLPZF6cnTtZwgAYqH3A= Date: Mon, 16 Sep 2019 00:32:46 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B83A691@SHSMSX101.ccr.corp.intel.com> References: <20190912010231.19544-1-zhichao.gao@intel.com> <20190912010231.19544-2-zhichao.gao@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: Wu, Hao A > Sent: Thursday, September 12, 2019 10:43 AM > To: Gao, Zhichao ; devel@edk2.groups.io > Cc: Wang, Jian J ; Ni, Ray > Subject: RE: [PATCH 1/3] MdeModulePkg: Entend the support keyboard type > of Terminal console >=20 > > -----Original Message----- > > From: Gao, Zhichao > > Sent: Thursday, September 12, 2019 9:02 AM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray > > Subject: [PATCH 1/3] MdeModulePkg: Entend the support keyboard type > of > > Terminal console >=20 >=20 > Hello, >=20 > Entend -> Extend I would update it later. >=20 >=20 > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2186 > > > > A common terminal console software Putty support various types of > > keyboard type, such as normal mode, Linux mode, Xterm R6, Vt400, > > VT100+ and SCO. Refer to the link: > > https://www.ssh.com/ssh/putty/putty- > manuals/0.68/Chapter4.html#config- > > funkeys > > > > Cc: Jian J Wang > > Cc: Hao A Wu > > Cc: Ray Ni > > Signed-off-by: Zhichao Gao > > --- > > .../Include/Guid/TerminalConExtendedType.h | 25 > > +++++++++++++++++++ > > MdeModulePkg/MdeModulePkg.dec | 6 +++++ > > 2 files changed, 31 insertions(+) > > create mode 100644 > > MdeModulePkg/Include/Guid/TerminalConExtendedType.h > > > > diff --git a/MdeModulePkg/Include/Guid/TerminalConExtendedType.h > > b/MdeModulePkg/Include/Guid/TerminalConExtendedType.h > > new file mode 100644 > > index 0000000000..18667413e8 > > --- /dev/null > > +++ b/MdeModulePkg/Include/Guid/TerminalConExtendedType.h > > @@ -0,0 +1,25 @@ > > +/** @file > > + GUID definition for Linux, XtermR6, Vt400 and SCO terminal type. > > + > > + > > + Copyright (c) 2019, Intel Corporation. All rights reserved.
> > + SPDX-License-Identifier: BSD-2-Clause-Patent > > + > > +**/ > > + > > +#ifndef __TERMINAL_CON_EXTENDED_TYPE_H__ #define > > +__TERMINAL_CON_EXTENDED_TYPE_H__ > > + > > +#define EDKII_LINUX_MODE_GUID \ > > + { 0xe4364a7f, 0xf825, 0x430e, { 0x9d, 0x3a, 0x9c, 0x9b, 0xe6, > > +0x81, 0x7c, > > 0xa5 } } > > + > > +#define EDKII_XTERM_R6_GUID \ > > + { 0xfbfca56b, 0xbb36, 0x4b78, { 0xaa, 0xab, 0xbe, 0x1b, 0x97, > > +0xec, 0x7c, > > 0xcb } } > > + > > +#define EDKII_VT400_GUID \ > > + { 0x8e46dddd, 0x3d49, 0x4a9d, { 0xb8, 0x75, 0x3c, 0x08, 0x6f, > > +0x6a, 0xa2, > > 0xbd } } > > + > > +#define EDKII_SCO_GUID \ > > + { 0xfc7dd6e0, 0x813c, 0x434d, { 0xb4, 0xda, 0x3b, 0xd6, 0x49, > > +0xe9, 0xe1, > > 0x5a } } > > + >=20 >=20 > I would suggest to add corresponding GUID declarations just as what has > been done in: >=20 > MdePkg/Include/Guid/PcAnsi.h > MdeModulePkg/Include/Guid/TtyTerm.h >=20 >=20 > > +#endif > > diff --git a/MdeModulePkg/MdeModulePkg.dec > > b/MdeModulePkg/MdeModulePkg.dec index 17beb45235..7528d52fcb > 100644 > > --- a/MdeModulePkg/MdeModulePkg.dec > > +++ b/MdeModulePkg/MdeModulePkg.dec > > @@ -343,6 +343,12 @@ > > ## Include/Guid/TtyTerm.h > > gEfiTtyTermGuid =3D { 0x7d916d80, 0x5bb1, 0x458c, {0x= a4, 0x8f, 0xe2, > > 0x5f, 0xdd, 0x51, 0xef, 0x94 }} > > > > + ## Include/Guid/TerminalConExtendedType.h > > + gEdkiiLinuxModeGuid =3D { 0xe4364a7f, 0xf825, 0x430e, { 0x= 9d, 0x3a, > > 0x9c, 0x9b, 0xe6, 0x81, 0x7c, 0xa5 } } > > + gEdkiiXtermR6Guid =3D { 0xfbfca56b, 0xbb36, 0x4b78, { 0x= aa, 0xab, > > 0xbe, 0x1b, 0x97, 0xec, 0x7c, 0xcb } } > > + gEdkiiVT400Guid =3D { 0x8e46dddd, 0x3d49, 0x4a9d, { 0x= b8, 0x75, > 0x3c, > > 0x08, 0x6f, 0x6a, 0xa2, 0xbd } } > > + gEdkiiSCOGuid =3D { 0xfc7dd6e0, 0x813c, 0x434d, { 0x= b4, 0xda, 0x3b, > > 0xd6, 0x49, 0xe9, 0xe1, 0x5a } } > > + >=20 >=20 > After this patch, there will be 3 header files that describe different te= rminal > modes supported in TerminalDxe driver: >=20 > MdePkg/Include/Guid/PcAnsi.h (PcAnsi, VT100, VT100+, VTUTF8) > MdeModulePkg/Include/Guid/TtyTerm.h (TtyTerm) > MdeModulePkg/Include/Guid/TerminalConExtendedType.h (Linux, Xterm > R6, Vt400, SCO) >=20 > Do we have a plan to add those 5 non-UEFI modes in the UEFI spec? No, we don't. But that can be taken into consideration. >=20 > If not, I am wondering is it possible to at least merge TtyTerm.h and > TerminalConExtendedType.h into one file so that we can avoid introducing > new header files every time new terminal modes are being added. Great suggestion. For now, I would merge the TerminatlConExtendedType.h in= to TtyTerm.h. If the uefi spec would add the new types, then we can put all= the types into one header file. Thanks, Zhichao >=20 > Best Regards, > Hao Wu >=20 >=20 > > ## Include/Guid/HiiBootMaintenanceFormset.h > > gEfiIfrBootMaintenanceGuid =3D { 0xb2dedc91, 0xd59f, 0x48d2, { = 0x89, > 0x8a, > > 0x12, 0x49, 0xc, 0x74, 0xa4, 0xe0 }} > > > > -- > > 2.21.0.windows.1