From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.31, mailfrom: zhichao.gao@intel.com) Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by groups.io with SMTP; Mon, 16 Sep 2019 18:07:12 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Sep 2019 18:07:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,514,1559545200"; d="scan'208";a="193610118" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 16 Sep 2019 18:07:11 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 16 Sep 2019 18:07:10 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.92]) by shsmsx102.ccr.corp.intel.com ([169.254.2.113]) with mapi id 14.03.0439.000; Tue, 17 Sep 2019 09:07:08 +0800 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "vit9696@protonmail.com" CC: "Gao, Liming" , "Wu, Hao A" Subject: Re: [edk2-devel] [PATCH v1 1/3] MdeModulePkg/ResetUtilityLib: Use STATIC_ASSERT macro Thread-Topic: [edk2-devel] [PATCH v1 1/3] MdeModulePkg/ResetUtilityLib: Use STATIC_ASSERT macro Thread-Index: AQHVVI6MjOq/+vfw0kS0X++BW85aV6cvPZlg Date: Tue, 17 Sep 2019 01:07:07 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B83AB70@SHSMSX101.ccr.corp.intel.com> References: <20190816235808.16019-1-vit9696@protonmail.com> <20190816235808.16019-2-vit9696@protonmail.com> In-Reply-To: <20190816235808.16019-2-vit9696@protonmail.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhichao Gao > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Vitaly Cheptsov via Groups.Io > Sent: Saturday, August 17, 2019 7:58 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH v1 1/3] MdeModulePkg/ResetUtilityLib: Use > STATIC_ASSERT macro >=20 > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3D2048 >=20 > Use new STATIC_ASSERT macro instead of VERIFY_SIZE_OF. >=20 > Signed-off-by: Vitaly Cheptsov > --- > MdeModulePkg/Library/ResetUtilityLib/ResetUtility.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) >=20 > diff --git a/MdeModulePkg/Library/ResetUtilityLib/ResetUtility.c > b/MdeModulePkg/Library/ResetUtilityLib/ResetUtility.c > index 2b5af4b95a..bb151d0331 100644 > --- a/MdeModulePkg/Library/ResetUtilityLib/ResetUtility.c > +++ b/MdeModulePkg/Library/ResetUtilityLib/ResetUtility.c > @@ -20,7 +20,10 @@ typedef struct { > } RESET_UTILITY_GUID_SPECIFIC_RESET_DATA; > #pragma pack() >=20 > -VERIFY_SIZE_OF (RESET_UTILITY_GUID_SPECIFIC_RESET_DATA, 18); > +STATIC_ASSERT ( > + sizeof (RESET_UTILITY_GUID_SPECIFIC_RESET_DATA) =3D=3D 18, > + "sizeof (RESET_UTILITY_GUID_SPECIFIC_RESET_DATA) is expected to be > 18 bytes" > + ); >=20 > /** > This is a shorthand helper function to reset with reset type and a sub= type > -- > 2.20.1 (Apple Git-117) >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#45870): https://edk2.groups.io/g/devel/message/45870 > Mute This Topic: https://groups.io/mt/32918009/1768756 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [zhichao.gao@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D