From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: zhichao.gao@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Wed, 18 Sep 2019 21:28:15 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Sep 2019 21:28:15 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,522,1559545200"; d="scan'208";a="186681964" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga008.fm.intel.com with ESMTP; 18 Sep 2019 21:28:15 -0700 Received: from fmsmsx162.amr.corp.intel.com (10.18.125.71) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Sep 2019 21:28:15 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx162.amr.corp.intel.com (10.18.125.71) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 18 Sep 2019 21:28:14 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.92]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.53]) with mapi id 14.03.0439.000; Thu, 19 Sep 2019 12:28:12 +0800 From: "Gao, Zhichao" To: "Wu, Hao A" , "devel@edk2.groups.io" CC: "Wang, Jian J" , "Ni, Ray" , "Ard Biesheuvel" , Laszlo Ersek , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH V3 1/3] MdeModulePkg: Extend the support keyboard type of Terminal console Thread-Topic: [edk2-devel] [PATCH V3 1/3] MdeModulePkg: Extend the support keyboard type of Terminal console Thread-Index: AQHVbeKzNfB6WACXZUOGHEHpWk/QhKcyPeHAgAAbRPA= Date: Thu, 19 Sep 2019 04:28:11 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B83BD44@SHSMSX101.ccr.corp.intel.com> References: <20190918053355.19892-1-zhichao.gao@intel.com> <20190918053355.19892-2-zhichao.gao@intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi Hao, I used to get comments from Mike not to add MARCO name and extern declarat= ion of the GUIDs to the header file. See https://edk2.groups.io/g/devel/message/40054. The MARCO is used in the patch #3, so I kept it. Thanks, Zhichao > -----Original Message----- > From: Wu, Hao A > Sent: Thursday, September 19, 2019 9:55 AM > To: devel@edk2.groups.io; Gao, Zhichao > Cc: Wang, Jian J ; Ni, Ray ; Ar= d > Biesheuvel ; Laszlo Ersek = ; > Gao, Liming > Subject: RE: [edk2-devel] [PATCH V3 1/3] MdeModulePkg: Extend the > support keyboard type of Terminal console >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Gao, Zhichao > > Sent: Wednesday, September 18, 2019 1:34 PM > > To: devel@edk2.groups.io > > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Ard Biesheuvel; Laszlo Ersek; > > Gao, Liming > > Subject: [edk2-devel] [PATCH V3 1/3] MdeModulePkg: Extend the support > > keyboard type of Terminal console > > > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D2186 > > > > A common terminal console software Putty support various types of > > keyboard type, such as normal mode, Linux mode, Xterm R6, Vt400, > > VT100+ and SCO. Refer to the link: > > https://www.ssh.com/ssh/putty/putty- > manuals/0.68/Chapter4.html#config- > > funkeys > > > > Cc: Jian J Wang > > Cc: Hao A Wu > > Cc: Ray Ni > > Cc: Ard Biesheuvel > > Cc: Laszlo Ersek > > Cc: Liming Gao > > Signed-off-by: Zhichao Gao > > --- > > MdeModulePkg/Include/Guid/TtyTerm.h | 13 +++++++++++++ > > MdeModulePkg/MdeModulePkg.dec | 4 ++++ > > 2 files changed, 17 insertions(+) > > > > diff --git a/MdeModulePkg/Include/Guid/TtyTerm.h > > b/MdeModulePkg/Include/Guid/TtyTerm.h > > index 8333344b9d..471a651d4d 100644 > > --- a/MdeModulePkg/Include/Guid/TtyTerm.h > > +++ b/MdeModulePkg/Include/Guid/TtyTerm.h > > @@ -4,6 +4,7 @@ provide support for modern *nix terminals. > > > > > > Copyright (c) 2015 Linaro Ltd. > > +Copyright (c) 2019, Intel Corporation. All rights reserved.
> > SPDX-License-Identifier: BSD-2-Clause-Patent > > > > **/ > > @@ -14,6 +15,18 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > > #define EFI_TTY_TERM_GUID \ > > {0x7d916d80, 0x5bb1, 0x458c, {0xa4, 0x8f, 0xe2, 0x5f, 0xdd, 0x51, > > 0xef, > > 0x94 } } > > > > +#define EDKII_LINUX_TERM_GUID \ > > + {0xe4364a7f, 0xf825, 0x430e, {0x9d, 0x3a, 0x9c, 0x9b, 0xe6, 0x81, > > +0x7c, > > 0xa5 } } > > + > > +#define EDKII_XTERM_R6_GUID \ > > + {0xfbfca56b, 0xbb36, 0x4b78, {0xaa, 0xab, 0xbe, 0x1b, 0x97, 0xec, > > +0x7c, > > 0xcb } } > > + > > +#define EDKII_VT400_GUID \ > > + {0x8e46dddd, 0x3d49, 0x4a9d, {0xb8, 0x75, 0x3c, 0x08, 0x6f, 0x6a, > > +0xa2, > > 0xbd } } > > + > > +#define EDKII_SCO_TERM_GUID \ > > + {0xfc7dd6e0, 0x813c, 0x434d, {0xb4, 0xda, 0x3b, 0xd6, 0x49, 0xe9, > > +0xe1, > > 0x5a } } > > + > > extern EFI_GUID gEfiTtyTermGuid; > > > > #endif > > diff --git a/MdeModulePkg/MdeModulePkg.dec > > b/MdeModulePkg/MdeModulePkg.dec index 17beb45235..7f72c122fc > 100644 > > --- a/MdeModulePkg/MdeModulePkg.dec > > +++ b/MdeModulePkg/MdeModulePkg.dec > > @@ -342,6 +342,10 @@ > > > > ## Include/Guid/TtyTerm.h > > gEfiTtyTermGuid =3D { 0x7d916d80, 0x5bb1, 0x458c, {0= xa4, 0x8f, 0xe2, > > 0x5f, 0xdd, 0x51, 0xef, 0x94 }} > > + gEdkiiLinuxTermGuid =3D { 0xe4364a7f, 0xf825, 0x430e, {0= x9d, 0x3a, > > 0x9c, 0x9b, 0xe6, 0x81, 0x7c, 0xa5 }} > > + gEdkiiXtermR6Guid =3D { 0xfbfca56b, 0xbb36, 0x4b78, {0= xaa, 0xab, > > 0xbe, 0x1b, 0x97, 0xec, 0x7c, 0xcb }} > > + gEdkiiVT400Guid =3D { 0x8e46dddd, 0x3d49, 0x4a9d, {0= xb8, 0x75, > 0x3c, > > 0x08, 0x6f, 0x6a, 0xa2, 0xbd }} > > + gEdkiiSCOTermGuid =3D { 0xfc7dd6e0, 0x813c, 0x434d, {0= xb4, 0xda, > > 0x3b, 0xd6, 0x49, 0xe9, 0xe1, 0x5a }} >=20 >=20 > Since these 4 new GUIDs are listed under comments for file 'TtyTerm.h', = I > would suggest to add these variable declarations in TtyTerm.h: >=20 > extern EFI_GUID gEdkiiLinuxTermGuid; > extern EFI_GUID gEdkiiXtermR6Guid; > extern EFI_GUID gEdkiiVT400Guid; > extern EFI_GUID gEdkiiSCOTermGuid; >=20 > With this handled, > Reviewed-by: Hao A Wu >=20 > Best Regards, > Hao Wu >=20 >=20 > > > > ## Include/Guid/HiiBootMaintenanceFormset.h > > gEfiIfrBootMaintenanceGuid =3D { 0xb2dedc91, 0xd59f, 0x48d2, {= 0x89, > 0x8a, > > 0x12, 0x49, 0xc, 0x74, 0xa4, 0xe0 }} > > -- > > 2.21.0.windows.1 > > > > > >=20