From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: zhichao.gao@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Mon, 23 Sep 2019 18:18:59 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Sep 2019 18:18:58 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,542,1559545200"; d="scan'208";a="200734036" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga002.jf.intel.com with ESMTP; 23 Sep 2019 18:18:58 -0700 Received: from fmsmsx126.amr.corp.intel.com (10.18.125.43) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Sep 2019 18:18:57 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by FMSMSX126.amr.corp.intel.com (10.18.125.43) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 23 Sep 2019 18:18:57 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.92]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.23]) with mapi id 14.03.0439.000; Tue, 24 Sep 2019 09:18:55 +0800 From: "Gao, Zhichao" To: "Carsey, Jaben" , =?utf-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= , "devel@edk2.groups.io" , "lersek@redhat.com" CC: "Ni, Ray" Subject: Re: [edk2-devel] [PATCH 31/35] ShellPkg/UefiShellDebug1CommandsLib: fix ShellCloseFile() call Thread-Topic: [edk2-devel] [PATCH 31/35] ShellPkg/UefiShellDebug1CommandsLib: fix ShellCloseFile() call Thread-Index: AQHVbZE5JYcE9TAGMkCm+L6ffls7dKc4il0AgABKxoCAATu1kA== Date: Tue, 24 Sep 2019 01:18:54 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B83D133@SHSMSX101.ccr.corp.intel.com> References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-32-lersek@redhat.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 UmV2aWV3ZWQtYnk6IFpoaWNoYW8gR2FvIDx6aGljaGFvLmdhb0BpbnRlbC5jb20+DQoNCj4gLS0t LS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogQ2Fyc2V5LCBKYWJlbg0KPiBTZW50OiBN b25kYXksIFNlcHRlbWJlciAyMywgMjAxOSAxMDoyOSBQTQ0KPiBUbzogUGhpbGlwcGUgTWF0aGll dS1EYXVkw6kgPHBoaWxtZEByZWRoYXQuY29tPjsgZGV2ZWxAZWRrMi5ncm91cHMuaW87DQo+IGxl cnNla0ByZWRoYXQuY29tDQo+IENjOiBOaSwgUmF5IDxyYXkubmlAaW50ZWwuY29tPjsgR2FvLCBa aGljaGFvIDx6aGljaGFvLmdhb0BpbnRlbC5jb20+DQo+IFN1YmplY3Q6IFJFOiBbZWRrMi1kZXZl bF0gW1BBVENIIDMxLzM1XQ0KPiBTaGVsbFBrZy9VZWZpU2hlbGxEZWJ1ZzFDb21tYW5kc0xpYjog Zml4IFNoZWxsQ2xvc2VGaWxlKCkgY2FsbA0KPiANCj4gUmV2aWV3ZWQtYnk6IEphYmVuIENhcnNl eSA8amFiZW4uY2Fyc2V5QGludGVsLmNvbT4NCj4gDQo+IFRoYW5rcw0KPiAtSmFiZW4NCj4gDQo+ ID4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gPiBGcm9tOiBQaGlsaXBwZSBNYXRoaWV1 LURhdWTDqSBbbWFpbHRvOnBoaWxtZEByZWRoYXQuY29tXQ0KPiA+IFNlbnQ6IE1vbmRheSwgU2Vw dGVtYmVyIDIzLCAyMDE5IDM6MDEgQU0NCj4gPiBUbzogZGV2ZWxAZWRrMi5ncm91cHMuaW87IGxl cnNla0ByZWRoYXQuY29tDQo+ID4gQ2M6IENhcnNleSwgSmFiZW4gPGphYmVuLmNhcnNleUBpbnRl bC5jb20+OyBOaSwgUmF5DQo+ID4gPHJheS5uaUBpbnRlbC5jb20+OyBHYW8sIFpoaWNoYW8gPHpo aWNoYW8uZ2FvQGludGVsLmNvbT4NCj4gPiBTdWJqZWN0OiBSZTogW2VkazItZGV2ZWxdIFtQQVRD SCAzMS8zNV0NCj4gPiBTaGVsbFBrZy9VZWZpU2hlbGxEZWJ1ZzFDb21tYW5kc0xpYjogZml4IFNo ZWxsQ2xvc2VGaWxlKCkgY2FsbA0KPiA+DQo+ID4gT24gOS8xNy8xOSA5OjQ5IFBNLCBMYXN6bG8g RXJzZWsgd3JvdGU6DQo+ID4gPiBJbiB0aGUgRmlsZUJ1ZmZlclNhdmUoKSBmdW5jdGlvbiwgd2Ug aW52b2tlIFNoZWxsQ2xvc2VGaWxlKCkgaWYNCj4gPiA+ICJEaXJlY3RvcnkgQ2FuIE5vdCBCZSBT YXZlZCIuDQo+ID4gPg0KPiA+ID4gVGhlIFNoZWxsQ2xvc2VGaWxlKCkgZnVuY3Rpb24gdGFrZXMg YSAoU0hFTExfRklMRV9IQU5ETEUqKSBwYXJhbWV0ZXINCj4gPiA+IGNhbGxlZCAiRmlsZUhhbmRs ZSIsIGFuZCBjb3JyZWN0bHkgcGFzc2VzIHRoZSBkZS1yZWZlcmVuY2VkDQo+ID4gPiAoKkZpbGVI YW5kbGUpIHRvIEVGSV9TSEVMTF9DTE9TRV9GSUxFLCB3aGljaCB0YWtlcyBhDQo+IFNIRUxMX0ZJ TEVfSEFORExFLg0KPiA+ID4NCj4gPiA+IEhvd2V2ZXIsIEZpbGVCdWZmZXJTYXZlKCkgcGFzc2Vz IFNIRUxMX0ZJTEVfSEFORExFIHRvDQo+ID4gPiBTaGVsbENsb3NlRmlsZSgpLCBub3QgdGhlIGV4 cGVjdGVkIChTSEVMTF9GSUxFX0hBTkRMRSopLiBDb3JyZWN0IGl0Lg0KPiA+ID4NCj4gPiA+IFRo aXMgZml4ZXMgYW4gYWN0dWFsIGJ1ZyB0aGF0IGhhcyByZW1haW5lZCBoaWRkZW4gZm9yIHR3byBy ZWFzb25zOg0KPiA+ID4NCj4gPiA+IC0gcG9pbnRlci10by1WT0lEIGNvbnZlcnRzIGZyb20vdG8g YW55IHBvaW50ZXItdG8tb2JqZWN0IHR5cGUNCj4gPiA+IHNpbGVudGx5LA0KPiA+ID4gLSB0aGUg YnVnIGlzIG9uIGFuIGVycm9yIHBhdGggd2hpY2ggaGFzIGxpa2VseSBuZXZlciBmaXJlZCBpbiBw cmFjdGljZS4NCj4gPiA+DQo+ID4gPiBDYzogSmFiZW4gQ2Fyc2V5IDxqYWJlbi5jYXJzZXlAaW50 ZWwuY29tPg0KPiA+ID4gQ2M6IFJheSBOaSA8cmF5Lm5pQGludGVsLmNvbT4NCj4gPiA+IENjOiBa aGljaGFvIEdhbyA8emhpY2hhby5nYW9AaW50ZWwuY29tPg0KPiA+ID4gU2lnbmVkLW9mZi1ieTog TGFzemxvIEVyc2VrIDxsZXJzZWtAcmVkaGF0LmNvbT4NCj4gPiA+IC0tLQ0KPiA+ID4NCj4gPiA+ IE5vdGVzOg0KPiA+ID4gICAgIHRlc3RlZDogZWRpdCAoc2F2aW5nIGEgZmlsZSkNCj4gPiA+DQo+ ID4gPiAgU2hlbGxQa2cvTGlicmFyeS9VZWZpU2hlbGxEZWJ1ZzFDb21tYW5kc0xpYi9FZGl0L0Zp bGVCdWZmZXIuYyB8IDINCj4gPiA+ICstDQo+ID4gPiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0 aW9uKCspLCAxIGRlbGV0aW9uKC0pDQo+ID4gPg0KPiA+ID4gZGlmZiAtLWdpdA0KPiA+IGEvU2hl bGxQa2cvTGlicmFyeS9VZWZpU2hlbGxEZWJ1ZzFDb21tYW5kc0xpYi9FZGl0L0ZpbGVCdWZmZXIu Yw0KPiA+IGIvU2hlbGxQa2cvTGlicmFyeS9VZWZpU2hlbGxEZWJ1ZzFDb21tYW5kc0xpYi9FZGl0 L0ZpbGVCdWZmZXIuYw0KPiA+ID4gaW5kZXggNDY0ZjlkZTM4ZTUyLi5mZDMyNGNjNGE4NjEgMTAw NjQ0DQo+ID4gPiAtLS0gYS9TaGVsbFBrZy9MaWJyYXJ5L1VlZmlTaGVsbERlYnVnMUNvbW1hbmRz TGliL0VkaXQvRmlsZUJ1ZmZlci5jDQo+ID4gPiArKysgYi9TaGVsbFBrZy9MaWJyYXJ5L1VlZmlT aGVsbERlYnVnMUNvbW1hbmRzTGliL0VkaXQvRmlsZUJ1ZmZlci5jDQo+ID4gPiBAQCAtMTQ2Miw3 ICsxNDYyLDcgQEAgRmlsZUJ1ZmZlclNhdmUgKA0KPiA+ID4NCj4gPiA+ICAgICAgaWYgKEluZm8g IT0gTlVMTCAmJiBJbmZvLT5BdHRyaWJ1dGUgJiBFRklfRklMRV9ESVJFQ1RPUlkpIHsNCj4gPiA+ ICAgICAgICBTdGF0dXNCYXJTZXRTdGF0dXNTdHJpbmcgKEwiRGlyZWN0b3J5IENhbiBOb3QgQmUg U2F2ZWQiKTsNCj4gPiA+IC0gICAgICBTaGVsbENsb3NlRmlsZShGaWxlSGFuZGxlKTsNCj4gPiA+ ICsgICAgICBTaGVsbENsb3NlRmlsZSAoJkZpbGVIYW5kbGUpOw0KPiA+ID4gICAgICAgIEZyZWVQ b29sKEluZm8pOw0KPiA+ID4gICAgICAgIHJldHVybiBFRklfTE9BRF9FUlJPUjsNCj4gPiA+ICAg ICAgfQ0KPiA+ID4NCj4gPg0KPiA+IFJldmlld2VkLWJ5OiBQaGlsaXBwZSBNYXRoaWV1LURhdWRl IDxwaGlsbWRAcmVkaGF0LmNvbT4NCg==