From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: zhichao.gao@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Wed, 25 Sep 2019 18:03:20 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2019 18:03:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,549,1559545200"; d="scan'208";a="389429633" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 25 Sep 2019 18:03:20 -0700 Received: from fmsmsx163.amr.corp.intel.com (10.18.125.72) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 25 Sep 2019 18:03:19 -0700 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx163.amr.corp.intel.com (10.18.125.72) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 25 Sep 2019 18:03:19 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.92]) by shsmsx102.ccr.corp.intel.com ([169.254.2.113]) with mapi id 14.03.0439.000; Thu, 26 Sep 2019 09:03:17 +0800 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "Gao, Zhichao" , "Ni, Ray" CC: "Wang, Jian J" , "Wu, Hao A" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: Enhance the arrow keys support Thread-Topic: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: Enhance the arrow keys support Thread-Index: AQHVc5rEL7Ode9un70Wqj9qVpjaAo6c8sizQgABnKKCAAAnxoA== Date: Thu, 26 Sep 2019 01:03:17 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B83F04B@SHSMSX101.ccr.corp.intel.com> References: <20190925120925.12600-1-zhichao.gao@intel.com> <734D49CCEBEEF84792F5B80ED585239D5C2F1BE6@SHSMSX104.ccr.corp.intel.com> <15C7D6B899193667.11273@groups.io> In-Reply-To: <15C7D6B899193667.11273@groups.io> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable To answer your questions: 1. As you say, putty may not be not standard terminal. So removing it from = comment is inappropriate in my opinion. 2. Terminal DXE driver doesn't have the related mode (normal or application= mode). It wouldn't make other terminal software unhappy except they input = the special sequence keys. Thanks, Zhichao > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Thursday, September 26, 2019 8:51 AM > To: Ni, Ray ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A ; > Gao, Liming > Subject: Re: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: Enhance > the arrow keys support >=20 >=20 >=20 > > -----Original Message----- > > From: Ni, Ray > > Sent: Thursday, September 26, 2019 2:17 AM > > To: devel@edk2.groups.io; Gao, Zhichao > > Cc: Wang, Jian J ; Wu, Hao A > > ; Gao, Liming > > Subject: RE: [edk2-devel] [PATCH] MdeModulePkg/TerminalDxe: Enhance > > the arrow keys support > > > > Zhichao, > > The four new modes you newly added are supported by putty. But I do > > not think Putty is the standard the terminal driver needs to follow. > > So, > > 1. can you please remove the "putty" from the comments (maybe code)? >=20 > Unfortunately, the terminal type doesn't have a spec or document except > Putty's website. That's why I add it to the comment. >=20 > > 2. can you please find the sources where each mode is defined and > > double check whether the change you make is following the mode > > definition? It avoids you make Putty happy but make other > > good-behavior terminal software unhappy. >=20 > The normal mode and application mode the Putty's own mode for the cursor > keys, such as arrow keys. There are *no such modes* in the terminal drive= r. > So I add the patch to support them all. > The special keys usually send a sequence keys, such as ESC + [ + A, thru = the > terminal ConIn. And it is terminal DXE driver's duty to recognize these > sequence keys and transfer the actual key value. Different terminal softw= are > may have different sequence keys for the special keys, but It would be > ignored if we don't add the support. > The only affected thing is that if you input a sequence of keys quickly, = such as > ESC + [ + A or ESC + O + A, thru the terminal software, then it would be = seen > as arrow key 'UP' regardless of the terminal type. Same to other new arro= w > keys. >=20 > I made a mistake in the previous patch to add the new terminal types. I > remove the VT100Plus's arrow key function incorrectly and that make the > arrow key not work with the terminal type VT100Plus. And then I think it = is > better to add the whole support of arrow key. >=20 > Thanks, > Zhichao >=20 > > > > Thanks, > > Ray > >