From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: zhichao.gao@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Wed, 25 Sep 2019 19:46:43 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2019 19:46:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,550,1559545200"; d="scan'208";a="203749161" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga001.fm.intel.com with ESMTP; 25 Sep 2019 19:46:43 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 25 Sep 2019 19:46:42 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 25 Sep 2019 19:46:42 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.92]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.86]) with mapi id 14.03.0439.000; Thu, 26 Sep 2019 10:46:40 +0800 From: "Gao, Zhichao" To: Laszlo Ersek , edk2-devel-groups-io CC: "Carsey, Jaben" , "Ni, Ray" Subject: Re: [PATCH 28/35] ShellPkg/UefiShellDriver1CommandsLib: fix parameter list typo Thread-Topic: [PATCH 28/35] ShellPkg/UefiShellDriver1CommandsLib: fix parameter list typo Thread-Index: AQHVbZE0ge+OPDgCi0qHTfyodMmEtKc9Terw Date: Thu, 26 Sep 2019 02:46:40 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B83F0E6@SHSMSX101.ccr.corp.intel.com> References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-29-lersek@redhat.com> In-Reply-To: <20190917194935.24322-29-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zhichao Gao > -----Original Message----- > From: Laszlo Ersek [mailto:lersek@redhat.com] > Sent: Wednesday, September 18, 2019 3:49 AM > To: edk2-devel-groups-io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao > Subject: [PATCH 28/35] ShellPkg/UefiShellDriver1CommandsLib: fix > parameter list typo >=20 > The ShellCommandRunConnect() function passes EFI_HANDLE -- (VOID*) -- > objects to ConvertAndConnectControllers(), and > ConvertAndConnectControllers() passes those to gBS->OpenProtocol(). >=20 > Accordingly, ConvertAndConnectControllers() should specify EFI_HANDLE > parameter types, not (EFI_HANDLE*) -- (VOID**) -- types. >=20 > This typo is masked because (VOID*) converts to and from any pointer-to- > object type silently. >=20 > Note that functionally speaking there is no problem, so this patch does n= ot > change beavior, only cleans up the code. >=20 > Cc: Jaben Carsey > Cc: Ray Ni > Cc: Zhichao Gao > Signed-off-by: Laszlo Ersek > --- >=20 > Notes: > tested with "connect -r" >=20 > ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c > b/ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c > index 359394dfd291..3f4e132674ea 100644 > --- a/ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c > +++ b/ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c > @@ -346,8 +346,8 @@ ShellConnectFromDevPaths ( **/ EFI_STATUS > ConvertAndConnectControllers ( > - IN EFI_HANDLE *Handle1 OPTIONAL, > - IN EFI_HANDLE *Handle2 OPTIONAL, > + IN EFI_HANDLE Handle1 OPTIONAL, > + IN EFI_HANDLE Handle2 OPTIONAL, > IN CONST BOOLEAN Recursive, > IN CONST BOOLEAN Output > ) > -- > 2.19.1.3.g30247aa5d201 >=20