From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: zhichao.gao@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Wed, 25 Sep 2019 19:53:37 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Sep 2019 19:53:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,550,1559545200"; d="scan'208";a="189864712" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga007.fm.intel.com with ESMTP; 25 Sep 2019 19:53:37 -0700 Received: from fmsmsx161.amr.corp.intel.com (10.18.125.9) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 25 Sep 2019 19:53:37 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX161.amr.corp.intel.com (10.18.125.9) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 25 Sep 2019 19:53:36 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.92]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.53]) with mapi id 14.03.0439.000; Thu, 26 Sep 2019 10:53:33 +0800 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "lersek@redhat.com" CC: "Carsey, Jaben" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH 30/35] ShellPkg: stop taking EFI_HANDLE in place of SHELL_FILE_HANDLE Thread-Topic: [edk2-devel] [PATCH 30/35] ShellPkg: stop taking EFI_HANDLE in place of SHELL_FILE_HANDLE Thread-Index: AQHVbZE24fwAO4tOgEeIr075jaAHY6c9Twfg Date: Thu, 26 Sep 2019 02:53:32 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B83F0FF@SHSMSX101.ccr.corp.intel.com> References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-31-lersek@redhat.com> In-Reply-To: <20190917194935.24322-31-lersek@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Laszlo Ersek > Sent: Wednesday, September 18, 2019 3:50 AM > To: edk2-devel-groups-io > Cc: Carsey, Jaben ; Ni, Ray ; > Gao, Zhichao > Subject: [edk2-devel] [PATCH 30/35] ShellPkg: stop taking EFI_HANDLE in > place of SHELL_FILE_HANDLE >=20 > The TouchFileByHandle() and IsDirectoryEmpty() functions are passed > SHELL_FILE_HANDLE parameters, and they use those parameters correctly. > However, their parameter lists say EFI_HANDLE. >=20 > Spell out the right type in the parameter lists. >=20 > In practice, this change is a no-op (because, quite regrettably, both > EFI_HANDLE and SHELL_FILE_HANDLE are specified to be typedefs of > (VOID*)). >=20 > Cc: Jaben Carsey > Cc: Ray Ni > Cc: Zhichao Gao > Signed-off-by: Laszlo Ersek > --- >=20 > Notes: > tested: rm, touch >=20 > ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c | 2 +- > ShellPkg/Library/UefiShellLevel3CommandsLib/Touch.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c > b/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c > index 3a1196f1529e..59f7eec376f2 100644 > --- a/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c > +++ b/ShellPkg/Library/UefiShellLevel2CommandsLib/Rm.c > @@ -24,7 +24,7 @@ STATIC CONST SHELL_PARAM_ITEM ParamList[] =3D { **/ > BOOLEAN IsDirectoryEmpty ( > - IN EFI_HANDLE FileHandle > + IN SHELL_FILE_HANDLE FileHandle Here may be EFI_FILE_HANDLE. > ) > { > EFI_STATUS Status; > diff --git a/ShellPkg/Library/UefiShellLevel3CommandsLib/Touch.c > b/ShellPkg/Library/UefiShellLevel3CommandsLib/Touch.c > index 0f00344c815e..a215f5774c69 100644 > --- a/ShellPkg/Library/UefiShellLevel3CommandsLib/Touch.c > +++ b/ShellPkg/Library/UefiShellLevel3CommandsLib/Touch.c > @@ -21,7 +21,7 @@ > **/ > EFI_STATUS > TouchFileByHandle ( > - IN EFI_HANDLE Handle > + IN SHELL_FILE_HANDLE Handle Here is OK. Thanks, Zhichao > ) > { > EFI_STATUS Status; > -- > 2.19.1.3.g30247aa5d201 >=20 >=20 >=20 > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. >=20 > View/Reply Online (#47417): https://edk2.groups.io/g/devel/message/47417 > Mute This Topic: https://groups.io/mt/34180233/1768756 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub > [zhichao.gao@intel.com] > -=3D-=3D-=3D-=3D-=3D-=3D