From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: zhichao.gao@intel.com) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by groups.io with SMTP; Thu, 26 Sep 2019 07:43:52 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 26 Sep 2019 07:43:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,552,1559545200"; d="scan'208";a="273420287" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga001.jf.intel.com with ESMTP; 26 Sep 2019 07:43:49 -0700 Received: from fmsmsx122.amr.corp.intel.com (10.18.125.37) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 26 Sep 2019 07:43:49 -0700 Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by fmsmsx122.amr.corp.intel.com (10.18.125.37) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 26 Sep 2019 07:43:49 -0700 Received: from shsmsx101.ccr.corp.intel.com ([169.254.1.92]) by SHSMSX105.ccr.corp.intel.com ([169.254.11.23]) with mapi id 14.03.0439.000; Thu, 26 Sep 2019 22:43:46 +0800 From: "Gao, Zhichao" To: "devel@edk2.groups.io" , "lersek@redhat.com" CC: "Carsey, Jaben" , "Ni, Ray" Subject: Re: [edk2-devel] [PATCH 30/35] ShellPkg: stop taking EFI_HANDLE in place of SHELL_FILE_HANDLE Thread-Topic: [edk2-devel] [PATCH 30/35] ShellPkg: stop taking EFI_HANDLE in place of SHELL_FILE_HANDLE Thread-Index: AQHVbZE24fwAO4tOgEeIr075jaAHY6c9TwfggAAWC4CAAKtEIA== Date: Thu, 26 Sep 2019 14:43:45 +0000 Message-ID: <3CE959C139B4C44DBEA1810E3AA6F9000B83F4CC@SHSMSX101.ccr.corp.intel.com> References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-31-lersek@redhat.com> <3CE959C139B4C44DBEA1810E3AA6F9000B83F0FF@SHSMSX101.ccr.corp.intel.com> <8a6e416e-30d3-13d8-f089-f43740fbe5ac@redhat.com> In-Reply-To: <8a6e416e-30d3-13d8-f089-f43740fbe5ac@redhat.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zhichao.gao@intel.com Content-Language: en-US Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 T0suIEkgZGlkbid0IHZpZXcgdGhlIHdob2xlIGNhbGxpbmcgc3RhY2suIFRoYW5rcyBmb3IgeW91 ciBjbGVhciBleHBsYWluLg0KVGhlbiB3aHkgd2UgbmVlZCB0d28gZXhhY3Qgc2FtZSBoYW5kbGUg dHlwZT8gTWF5IGJlIHdlIHNob3VsZCBrZWVwIG9ubHkgb25lIG9mIHRoZW0uIFNhbWUgd2l0aCB0 aGUgREVCVUdfWFhYIGFuZCBFRklfRF9YWFguDQoNCkJhY2sgdG8gdGhlIHBhdGNoLCBpdCBpcyBP SyB0byBtZSBub3cuIFJldmlld2VkLWJ5OiBaaGljaGFvIEdhbyA8emhpY2hhby5nYW9AaW50ZWwu Y29tPg0KDQo+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+IEZyb206IGRldmVsQGVkazIu Z3JvdXBzLmlvIFttYWlsdG86ZGV2ZWxAZWRrMi5ncm91cHMuaW9dIE9uIEJlaGFsZiBPZg0KPiBM YXN6bG8gRXJzZWsNCj4gU2VudDogVGh1cnNkYXksIFNlcHRlbWJlciAyNiwgMjAxOSA4OjA5IFBN DQo+IFRvOiBkZXZlbEBlZGsyLmdyb3Vwcy5pbzsgR2FvLCBaaGljaGFvIDx6aGljaGFvLmdhb0Bp bnRlbC5jb20+DQo+IENjOiBDYXJzZXksIEphYmVuIDxqYWJlbi5jYXJzZXlAaW50ZWwuY29tPjsg TmksIFJheSA8cmF5Lm5pQGludGVsLmNvbT4NCj4gU3ViamVjdDogUmU6IFtlZGsyLWRldmVsXSBb UEFUQ0ggMzAvMzVdIFNoZWxsUGtnOiBzdG9wIHRha2luZyBFRklfSEFORExFIGluDQo+IHBsYWNl IG9mIFNIRUxMX0ZJTEVfSEFORExFDQo+IA0KPiBPbiAwOS8yNi8xOSAwNDo1MywgR2FvLCBaaGlj aGFvIHdyb3RlOg0KPiA+DQo+ID4NCj4gPj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4g Pj4gRnJvbTogZGV2ZWxAZWRrMi5ncm91cHMuaW8gW21haWx0bzpkZXZlbEBlZGsyLmdyb3Vwcy5p b10gT24gQmVoYWxmIE9mDQo+ID4+IExhc3psbyBFcnNlaw0KPiA+PiBTZW50OiBXZWRuZXNkYXks IFNlcHRlbWJlciAxOCwgMjAxOSAzOjUwIEFNDQo+ID4+IFRvOiBlZGsyLWRldmVsLWdyb3Vwcy1p byA8ZGV2ZWxAZWRrMi5ncm91cHMuaW8+DQo+ID4+IENjOiBDYXJzZXksIEphYmVuIDxqYWJlbi5j YXJzZXlAaW50ZWwuY29tPjsgTmksIFJheQ0KPiA+PiA8cmF5Lm5pQGludGVsLmNvbT47IEdhbywg WmhpY2hhbyA8emhpY2hhby5nYW9AaW50ZWwuY29tPg0KPiA+PiBTdWJqZWN0OiBbZWRrMi1kZXZl bF0gW1BBVENIIDMwLzM1XSBTaGVsbFBrZzogc3RvcCB0YWtpbmcgRUZJX0hBTkRMRQ0KPiA+PiBp biBwbGFjZSBvZiBTSEVMTF9GSUxFX0hBTkRMRQ0KPiA+Pg0KPiA+PiBUaGUgVG91Y2hGaWxlQnlI YW5kbGUoKSBhbmQgSXNEaXJlY3RvcnlFbXB0eSgpIGZ1bmN0aW9ucyBhcmUgcGFzc2VkDQo+ID4+ IFNIRUxMX0ZJTEVfSEFORExFIHBhcmFtZXRlcnMsIGFuZCB0aGV5IHVzZSB0aG9zZSBwYXJhbWV0 ZXJzDQo+IGNvcnJlY3RseS4NCj4gPj4gSG93ZXZlciwgdGhlaXIgcGFyYW1ldGVyIGxpc3RzIHNh eSBFRklfSEFORExFLg0KPiA+Pg0KPiA+PiBTcGVsbCBvdXQgdGhlIHJpZ2h0IHR5cGUgaW4gdGhl IHBhcmFtZXRlciBsaXN0cy4NCj4gPj4NCj4gPj4gSW4gcHJhY3RpY2UsIHRoaXMgY2hhbmdlIGlz IGEgbm8tb3AgKGJlY2F1c2UsIHF1aXRlIHJlZ3JldHRhYmx5LCBib3RoDQo+ID4+IEVGSV9IQU5E TEUgYW5kIFNIRUxMX0ZJTEVfSEFORExFIGFyZSBzcGVjaWZpZWQgdG8gYmUgdHlwZWRlZnMgb2YN Cj4gPj4gKFZPSUQqKSkuDQo+ID4+DQo+ID4+IENjOiBKYWJlbiBDYXJzZXkgPGphYmVuLmNhcnNl eUBpbnRlbC5jb20+DQo+ID4+IENjOiBSYXkgTmkgPHJheS5uaUBpbnRlbC5jb20+DQo+ID4+IENj OiBaaGljaGFvIEdhbyA8emhpY2hhby5nYW9AaW50ZWwuY29tPg0KPiA+PiBTaWduZWQtb2ZmLWJ5 OiBMYXN6bG8gRXJzZWsgPGxlcnNla0ByZWRoYXQuY29tPg0KPiA+PiAtLS0NCj4gPj4NCj4gPj4g Tm90ZXM6DQo+ID4+ICAgICB0ZXN0ZWQ6IHJtLCB0b3VjaA0KPiA+Pg0KPiA+PiAgU2hlbGxQa2cv TGlicmFyeS9VZWZpU2hlbGxMZXZlbDJDb21tYW5kc0xpYi9SbS5jICAgIHwgMiArLQ0KPiA+PiAg U2hlbGxQa2cvTGlicmFyeS9VZWZpU2hlbGxMZXZlbDNDb21tYW5kc0xpYi9Ub3VjaC5jIHwgMiAr LQ0KPiA+PiAgMiBmaWxlcyBjaGFuZ2VkLCAyIGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0p DQo+ID4+DQo+ID4+IGRpZmYgLS1naXQgYS9TaGVsbFBrZy9MaWJyYXJ5L1VlZmlTaGVsbExldmVs MkNvbW1hbmRzTGliL1JtLmMNCj4gPj4gYi9TaGVsbFBrZy9MaWJyYXJ5L1VlZmlTaGVsbExldmVs MkNvbW1hbmRzTGliL1JtLmMNCj4gPj4gaW5kZXggM2ExMTk2ZjE1MjllLi41OWY3ZWVjMzc2ZjIg MTAwNjQ0DQo+ID4+IC0tLSBhL1NoZWxsUGtnL0xpYnJhcnkvVWVmaVNoZWxsTGV2ZWwyQ29tbWFu ZHNMaWIvUm0uYw0KPiA+PiArKysgYi9TaGVsbFBrZy9MaWJyYXJ5L1VlZmlTaGVsbExldmVsMkNv bW1hbmRzTGliL1JtLmMNCj4gPj4gQEAgLTI0LDcgKzI0LDcgQEAgU1RBVElDIENPTlNUIFNIRUxM X1BBUkFNX0lURU0gUGFyYW1MaXN0W10gPQ0KPiB7ICAqKi8NCj4gPj4gQk9PTEVBTiAgSXNEaXJl Y3RvcnlFbXB0eSAoDQo+ID4+IC0gIElOIEVGSV9IQU5ETEUgICBGaWxlSGFuZGxlDQo+ID4+ICsg IElOIFNIRUxMX0ZJTEVfSEFORExFICAgRmlsZUhhbmRsZQ0KPiA+DQo+ID4gSGVyZSBtYXkgYmUg RUZJX0ZJTEVfSEFORExFLg0KPiANCj4gWWVzLCBpdCAqbWF5KiwgYnV0IGRvZXNuJ3QgKmhhdmUq IHRvLg0KPiANCj4gV2UgaGF2ZSB0aGUgZm9sbG93aW5nIGNhbGwgdHJlZToNCj4gDQo+ICAgQ2Fz Y2FkZURlbGV0ZSgpDQo+ICAgICBJc0RpcmVjdG9yeUVtcHR5KCkNCj4gICAgICAgRmlsZUhhbmRs ZUZpbmRGaXJzdEZpbGUoKQ0KPiAgICAgICBGaWxlSGFuZGxlRmluZE5leHRGaWxlKCkNCj4gDQo+ IFdpdGggdGhpcyBwYXRjaCwgd2UgaGF2ZToNCj4gDQo+ICAgIk5vZGUtPkhhbmRsZSINCj4gICAg IHwNCj4gICAgIFtTSEVMTF9GSUxFX0hBTkRMRV0NCj4gICAgIHwNCj4gICAgIHYNCj4gICBDYXNj YWRlRGVsZXRlKCkNCj4gICAgIHwNCj4gICAgIFtTSEVMTF9GSUxFX0hBTkRMRV0NCj4gICAgIHwN Cj4gICAgIHYNCj4gICAgIElzRGlyZWN0b3J5RW1wdHkoKQ0KPiAgICAgICB8DQo+ICAgICAgIFtF RklfRklMRV9IQU5ETEVdDQo+ICAgICAgIHwNCj4gICAgICAgdg0KPiAgICAgICBGaWxlSGFuZGxl RmluZEZpcnN0RmlsZSgpDQo+ICAgICAgIEZpbGVIYW5kbGVGaW5kTmV4dEZpbGUoKQ0KPiANCj4g d2l0aCB5b3VyIHByb3Bvc2FsLCB3ZSB3b3VsZCBoYXZlOg0KPiANCj4gICAiTm9kZS0+SGFuZGxl Ig0KPiAgICAgfA0KPiAgICAgW1NIRUxMX0ZJTEVfSEFORExFXQ0KPiAgICAgfA0KPiAgICAgdg0K PiAgIENhc2NhZGVEZWxldGUoKQ0KPiAgICAgfA0KPiAgICAgW0VGSV9GSUxFX0hBTkRMRV0NCj4g ICAgIHwNCj4gICAgIHYNCj4gICAgIElzRGlyZWN0b3J5RW1wdHkoKQ0KPiAgICAgICB8DQo+ICAg ICAgIFtFRklfRklMRV9IQU5ETEVdDQo+ICAgICAgIHwNCj4gICAgICAgdg0KPiAgICAgICBGaWxl SGFuZGxlRmluZEZpcnN0RmlsZSgpDQo+ICAgICAgIEZpbGVIYW5kbGVGaW5kTmV4dEZpbGUoKQ0K PiANCj4gSW4gYm90aCBjYXNlcywgd2UgZGVwZW5kIG9uIFNIRUxMX0ZJTEVfSEFORExFIGJlaW5n IGVxdWl2YWxlbnQgdG8NCj4gRUZJX0ZJTEVfSEFORExFLiBJbiB0aGUgZW5kLCBib3RoIHR5cGVz IGFyZToNCj4gDQo+ICAgKHN0cnVjdCBfRUZJX0ZJTEVfUFJPVE9DT0wgKikNCj4gDQo+IEluIGJv dGggY2FzZXMsIHdlIGdvIGZyb20gU0hFTExfRklMRV9IQU5ETEUgdG8gRUZJX0ZJTEVfSEFORExF LCBhbmQNCj4gZXhwbG9pdCB0aGF0IHRoZXkgYXJlIGlkZW50aWNhbDsgdGhlIGRpZmZlcmVuY2Ug aXMgb25seSAqd2hlcmUqIHdlIGV4cGxvaXQgdGhhdC4NCj4gDQo+IC0gSW4gdGhpcyBwYXRjaCwg d2UgZXhwbG9pdCB0aGUgaWRlbnRpdHkgaW4gSXNEaXJlY3RvcnlFbXB0eSgpOiB3ZSB0YWtlIGEN Cj4gU0hFTExfRklMRV9IQU5ETEUsIGFuZCBnaXZlIGl0IHRvIGZ1bmN0aW9ucyB0aGF0IHRha2Ug RUZJX0ZJTEVfSEFORExFLg0KPiANCj4gLSBJbiB5b3VyIHByb3Bvc2FsLCB3ZSB3b3VsZCBleHBs b2l0IHRoZSBleGFjdCBzYW1lIGlkZW50aXR5LCBqdXN0IGluDQo+IENhc2NhZGVEZWxldGUoKTog Ik5vZGUtPkhhbmRsZSIgaXMgYSBTSEVMTF9GSUxFX0hBTkRMRSAoc2VlDQo+IEVGSV9TSEVMTF9G SUxFX0lORk8uSGFuZGxlKSwgYW5kIHdlJ2QgcGFzcyBpdCB0byBhIGZ1bmN0aW9uIChuYW1lbHkN Cj4gSXNEaXJlY3RvcnlFbXB0eSgpKSB0YWtpbmcgYW4gRUZJX0ZJTEVfSEFORExFLg0KPiANCj4g R2l2ZW4gdGhhdCB5b3VyIHByb3Bvc2FsIHdvdWxkbid0IGNoYW5nZSBvdXIgZGVwZW5kZW5jZSBv biB0aGUNCj4gU0hFTExfRklMRV9IQU5ETEU9PT1FRklfRklMRV9IQU5ETEUgaWRlbnRpdHksIEkg cHJlZmVyIHRvIHN0aWNrIHdpdGggdGhlDQo+IGN1cnJlbnQgcGF0Y2guDQo+IA0KPiBUaGFua3MN Cj4gTGFzemxvDQo+IA0KPiA+DQo+ID4+ICAgICkNCj4gPj4gIHsNCj4gPj4gICAgRUZJX1NUQVRV UyAgICAgIFN0YXR1czsNCj4gPj4gZGlmZiAtLWdpdCBhL1NoZWxsUGtnL0xpYnJhcnkvVWVmaVNo ZWxsTGV2ZWwzQ29tbWFuZHNMaWIvVG91Y2guYw0KPiA+PiBiL1NoZWxsUGtnL0xpYnJhcnkvVWVm aVNoZWxsTGV2ZWwzQ29tbWFuZHNMaWIvVG91Y2guYw0KPiA+PiBpbmRleCAwZjAwMzQ0YzgxNWUu LmEyMTVmNTc3NGM2OSAxMDA2NDQNCj4gPj4gLS0tIGEvU2hlbGxQa2cvTGlicmFyeS9VZWZpU2hl bGxMZXZlbDNDb21tYW5kc0xpYi9Ub3VjaC5jDQo+ID4+ICsrKyBiL1NoZWxsUGtnL0xpYnJhcnkv VWVmaVNoZWxsTGV2ZWwzQ29tbWFuZHNMaWIvVG91Y2guYw0KPiA+PiBAQCAtMjEsNyArMjEsNyBA QA0KPiA+PiAgKiovDQo+ID4+ICBFRklfU1RBVFVTDQo+ID4+ICBUb3VjaEZpbGVCeUhhbmRsZSAo DQo+ID4+IC0gIElOIEVGSV9IQU5ETEUgSGFuZGxlDQo+ID4+ICsgIElOIFNIRUxMX0ZJTEVfSEFO RExFIEhhbmRsZQ0KPiA+DQo+ID4gSGVyZSBpcyBPSy4NCj4gPg0KPiA+IFRoYW5rcywNCj4gPiBa aGljaGFvDQo+ID4NCj4gPj4gICAgKQ0KPiA+PiAgew0KPiA+PiAgICBFRklfU1RBVFVTICAgIFN0 YXR1czsNCj4gPj4gLS0NCj4gPj4gMi4xOS4xLjMuZzMwMjQ3YWE1ZDIwMQ0KPiA+Pg0KPiA+Pg0K PiA+Pg0KPiA+PiAtPS09LT0tPS09LT0NCj4gPj4gR3JvdXBzLmlvIExpbmtzOiBZb3UgcmVjZWl2 ZSBhbGwgbWVzc2FnZXMgc2VudCB0byB0aGlzIGdyb3VwLg0KPiA+Pg0KPiA+PiBWaWV3L1JlcGx5 IE9ubGluZSAoIzQ3NDE3KToNCj4gPj4gaHR0cHM6Ly9lZGsyLmdyb3Vwcy5pby9nL2RldmVsL21l c3NhZ2UvNDc0MTcNCj4gPj4gTXV0ZSBUaGlzIFRvcGljOiBodHRwczovL2dyb3Vwcy5pby9tdC8z NDE4MDIzMy8xNzY4NzU2DQo+ID4+IEdyb3VwIE93bmVyOiBkZXZlbCtvd25lckBlZGsyLmdyb3Vw cy5pbw0KPiA+PiBVbnN1YnNjcmliZTogaHR0cHM6Ly9lZGsyLmdyb3Vwcy5pby9nL2RldmVsL3Vu c3ViDQo+ID4+IFt6aGljaGFvLmdhb0BpbnRlbC5jb21dDQo+ID4+IC09LT0tPS09LT0tPQ0KPiA+ DQo+ID4NCj4gPg0KPiA+DQo+IA0KPiANCj4gDQoNCg==